From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC87FC6FA83 for ; Tue, 27 Sep 2022 07:14:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229851AbiI0HO5 (ORCPT ); Tue, 27 Sep 2022 03:14:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229738AbiI0HOy (ORCPT ); Tue, 27 Sep 2022 03:14:54 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 200D9642EE; Tue, 27 Sep 2022 00:14:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AF08F6162A; Tue, 27 Sep 2022 07:14:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 042C4C433D6; Tue, 27 Sep 2022 07:14:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664262892; bh=AXaJuNbMdlA3wyGDnt3C65MZ5fPprSXOkBzMm29GxKU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Lg4xfg3HPJJgLOswp5R4rRvhCSHY80EEGlrkDDVTVmIf2RUUaZq4gKG1UC71/6yLz sPW8a/BHJdKNLENWTlp2IZMlB37kPRyLzwizM0Y+fg2pGMGSB8RRPAIVVFiWYph/GI /PD0BNHVcy0b2gUBr33oPPSpFsFGWijRzO/kaFrDiw5v1bMca3zoPgr5Bs9EyuH3UQ Kv7FLpRzeSCWj/rCg+FaZFP0GaWsoiyd2rbO06yL+HygmEOq49g3dFpPedckH9Cux7 Ntod7/E2gqpN1vNIOeGBdmB+TcNsp5fbDNY7Z5Or9rRdoROehDde0FZJa1UAfydqhv PW+swX5ksnP+Q== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1od4nx-0005GW-Jb; Tue, 27 Sep 2022 09:14:57 +0200 Date: Tue, 27 Sep 2022 09:14:57 +0200 From: Johan Hovold To: Abhinav Kumar Cc: Johan Hovold , Douglas Anderson , Dmitry Baryshkov , Rob Clark , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Daniel Vetter , Sean Paul , Stephen Boyd , Bjorn Andersson , Manivannan Sadhasivam , Kuogee Hsieh , Steev Klimaszewski , dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 09/10] drm/msm/dp: drop modeset sanity checks Message-ID: References: <20220913085320.8577-1-johan+linaro@kernel.org> <20220913085320.8577-10-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, Sep 26, 2022 at 11:17:20AM -0700, Abhinav Kumar wrote: > On 9/13/2022 1:53 AM, Johan Hovold wrote: > > Drop the overly defensive modeset sanity checks of function parameters > > which have already been checked or used by the callers. > > > > Reviewed-by: Dmitry Baryshkov > > Signed-off-by: Johan Hovold > > The change LGTM, hence > > Reviewed-by: Abhinav Kumar > > I think we can use below fixes tag so that we can pick up this entire > series for the fixes cycle. > > Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support") Perhaps that's a requirement for drm, but I wouldn't add a Fixes tag for this otherwise as it's not a bug. You also have to watch out for Sasha and his autosel scripts which will probably try to backport this to stable if it finds a Fixes tag. Johan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1462BC6FA86 for ; Tue, 27 Sep 2022 07:15:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 045A710E06D; Tue, 27 Sep 2022 07:14:59 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id EBD4210E06D; Tue, 27 Sep 2022 07:14:54 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5E9F4B819DC; Tue, 27 Sep 2022 07:14:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 042C4C433D6; Tue, 27 Sep 2022 07:14:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664262892; bh=AXaJuNbMdlA3wyGDnt3C65MZ5fPprSXOkBzMm29GxKU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Lg4xfg3HPJJgLOswp5R4rRvhCSHY80EEGlrkDDVTVmIf2RUUaZq4gKG1UC71/6yLz sPW8a/BHJdKNLENWTlp2IZMlB37kPRyLzwizM0Y+fg2pGMGSB8RRPAIVVFiWYph/GI /PD0BNHVcy0b2gUBr33oPPSpFsFGWijRzO/kaFrDiw5v1bMca3zoPgr5Bs9EyuH3UQ Kv7FLpRzeSCWj/rCg+FaZFP0GaWsoiyd2rbO06yL+HygmEOq49g3dFpPedckH9Cux7 Ntod7/E2gqpN1vNIOeGBdmB+TcNsp5fbDNY7Z5Or9rRdoROehDde0FZJa1UAfydqhv PW+swX5ksnP+Q== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1od4nx-0005GW-Jb; Tue, 27 Sep 2022 09:14:57 +0200 Date: Tue, 27 Sep 2022 09:14:57 +0200 From: Johan Hovold To: Abhinav Kumar Subject: Re: [PATCH v2 09/10] drm/msm/dp: drop modeset sanity checks Message-ID: References: <20220913085320.8577-1-johan+linaro@kernel.org> <20220913085320.8577-10-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Neil Armstrong , Jernej Skrabec , linux-kernel@vger.kernel.org, Jonas Karlman , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Steev Klimaszewski , freedreno@lists.freedesktop.org, Douglas Anderson , Robert Foss , Stephen Boyd , Laurent Pinchart , Andrzej Hajda , Manivannan Sadhasivam , Dmitry Baryshkov , Kuogee Hsieh , Sean Paul , Johan Hovold Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Sep 26, 2022 at 11:17:20AM -0700, Abhinav Kumar wrote: > On 9/13/2022 1:53 AM, Johan Hovold wrote: > > Drop the overly defensive modeset sanity checks of function parameters > > which have already been checked or used by the callers. > > > > Reviewed-by: Dmitry Baryshkov > > Signed-off-by: Johan Hovold > > The change LGTM, hence > > Reviewed-by: Abhinav Kumar > > I think we can use below fixes tag so that we can pick up this entire > series for the fixes cycle. > > Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support") Perhaps that's a requirement for drm, but I wouldn't add a Fixes tag for this otherwise as it's not a bug. You also have to watch out for Sasha and his autosel scripts which will probably try to backport this to stable if it finds a Fixes tag. Johan