From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFE4CC04A95 for ; Wed, 28 Sep 2022 12:14:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230140AbiI1MOn (ORCPT ); Wed, 28 Sep 2022 08:14:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230064AbiI1MOk (ORCPT ); Wed, 28 Sep 2022 08:14:40 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07663645C for ; Wed, 28 Sep 2022 05:14:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qDfNcxR4PZwQzGc3aGCJZCt8MxsrwYbwS0ZGRLtOrLU=; b=t0ITpa0F56NZNCExQUSx1JsoCr W9qxPGQAhUqbLTEwOgX2LohY52mTpgFosRja72bTYXEAwniSsyJWNn3H1DObXdu46TTR3tZIgaNxR 9XYiaScnwArIMH2HIY2gcrzo4up99aF4IRHtVRypG28ACCOMpYFWj9PpW3ZAtOEkx/V/q/NCKI0fh pv+yiS1v+gAszOzUUNAi+6g/SDS4vSCjW1i0zwf/rA74fC+9yizO0ctjHt3k5VBARF/gTu7qJNdn3 qg2Qfz/U5CtkT8GntZERl5Y5vT8RhZ2kQUEdD+NRJ5Lw3/u/TkSOUoF04D0zbzuLzJsn7VyxxoLEo CLkV/t9w==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1odVxO-00GAkC-MR; Wed, 28 Sep 2022 12:14:30 +0000 Date: Wed, 28 Sep 2022 05:14:30 -0700 From: Christoph Hellwig To: Palmer Dabbelt Cc: apatel@ventanamicro.com, Paul Walmsley , atishp@atishpatra.org, heiko@sntech.de, anup@brainfault.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, mchitale@ventanamicro.com Subject: Re: [PATCH v2 1/4] RISC-V: Fix ioremap_cache() and ioremap_wc() for systems with Svpbmt Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 22, 2022 at 09:35:56AM -0700, Palmer Dabbelt wrote: > Sorry I missed this, I thought it was just part of the rest of this patch > set. That said, I'm not actually sure this is a critical fix: sure it's a > performance problem, and if some driver is expecting ioremap_cache() to go > fast then possibly a pretty big one, but the only Svpmbt hardware that More importantly nothing should be using ioremap_cache at all. It is an API that has long been deprecated in favor of memremap. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3D4BC54EE9 for ; Wed, 28 Sep 2022 12:14:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Wy2M5hFaWWjY3AzVEEuRX291gYwqg0+aAanyuJYVYZI=; b=FFxrmxhRySjIMV kgcI14Slr4u/qwVhdRZ9QyHIbIxB/wU81MrXfsz6jKiEvPs9oOjyCkrHbZKkwnaKy2Wms+/bs3FpL lf+KRv9Sa65PImiEKtGGqOSBgu5bgUO7/CeMC4Q2Kt+AwcjmVmat38TP9zzJlmZ0DBme9l1JkxMTb SYAfFGRCgJQKIf/iKxpeLBsKd3W6Hv71Y4Hzi2PxnSzebWLUdhj5zGHT1GyMP9Gq0rWqTaEauaR+t lofMNJogYiZqPTowU2K7GUC5fo9KeOXJoEBetp+wj9ypvVdc8JzuL3U+7d/pcljs5Rp6zFUpKS4+O iJPxunzK/AvdziaNPq4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odVxR-00GAlV-1B; Wed, 28 Sep 2022 12:14:33 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1odVxO-00GAkC-MR; Wed, 28 Sep 2022 12:14:30 +0000 Date: Wed, 28 Sep 2022 05:14:30 -0700 From: Christoph Hellwig To: Palmer Dabbelt Cc: apatel@ventanamicro.com, Paul Walmsley , atishp@atishpatra.org, heiko@sntech.de, anup@brainfault.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, mchitale@ventanamicro.com Subject: Re: [PATCH v2 1/4] RISC-V: Fix ioremap_cache() and ioremap_wc() for systems with Svpbmt Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, Sep 22, 2022 at 09:35:56AM -0700, Palmer Dabbelt wrote: > Sorry I missed this, I thought it was just part of the rest of this patch > set. That said, I'm not actually sure this is a critical fix: sure it's a > performance problem, and if some driver is expecting ioremap_cache() to go > fast then possibly a pretty big one, but the only Svpmbt hardware that More importantly nothing should be using ioremap_cache at all. It is an API that has long been deprecated in favor of memremap. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv