From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 720A2C433F5 for ; Fri, 30 Sep 2022 21:05:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232331AbiI3VFi (ORCPT ); Fri, 30 Sep 2022 17:05:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232192AbiI3VFf (ORCPT ); Fri, 30 Sep 2022 17:05:35 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF6C18C020; Fri, 30 Sep 2022 14:05:29 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5DBFA4D5; Fri, 30 Sep 2022 23:05:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1664571927; bh=yMPbFOlWA6DnUrGYk0efelboSLYqi558kgrzCCOcZss=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sgQIyFYxgzelUKNDM9EkplmoUAS7EnjG1MlPNcTrXxXb1BrmUpMTqbKodj8yQBfCl 6y4Wg1Qh/lAwAE82AH6EH9LpmeXgrdfBud868Za0b6MMTxaklfGv3U6r18dGkp85mR V3reQtJyugrKYkgOSQaZXq1fAHGIUQzC4J13LEFs= Date: Sat, 1 Oct 2022 00:05:25 +0300 From: Laurent Pinchart To: "Lad, Prabhakar" Cc: Krzysztof Kozlowski , Lad Prabhakar , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Philipp Zabel , Jacopo Mondi , Niklas =?utf-8?Q?S=C3=B6derlund?= , Sakari Ailus , Hans Verkuil , Geert Uytterhoeven , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Biju Das Subject: Re: [PATCH v2 2/4] media: dt-bindings: Document Renesas RZ/G2L CRU block Message-ID: References: <20220905230406.30801-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20220905230406.30801-3-prabhakar.mahadev-lad.rj@bp.renesas.com> <29d456ed-620c-8dc9-01f0-54f96b670b94@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Prabhakar, On Fri, Sep 30, 2022 at 11:49:22AM +0100, Lad, Prabhakar wrote: > On Thu, Sep 22, 2022 at 2:46 PM Laurent Pinchart wrote: > > On Wed, Sep 21, 2022 at 08:58:26PM +0200, Krzysztof Kozlowski wrote: > > > On 21/09/2022 19:29, Laurent Pinchart wrote: > > > >>>>> + clock-names: > > > >>>>> + items: > > > >>>>> + - const: vclk > > > >>>>> + - const: pclk > > > >>>>> + - const: aclk > > > >>>> > > > >>>> Drop the "clk" suffixes. Remaining names could be made a bit more readable. > > > >>> > > > >>> These names come from the documentation, isn't it better to match the > > > >>> datasheet ? > > > >> > > > >> If datasheet calls it "vclk_really_clk_it_is_clk_clk", it's not the > > > >> reason to use it. :) > > > >> > > > >> The "clk" is redundant even if the hardware engineer thought different. > > > >> > > > >> The same for IRQs ("tx" not "txirq"), for dmas ("tx" not "txdma"). > > > > > > > > I'd argue that naming clocks "v", "p" and "a" would be less readable and > > > > more confusing. Is this a new rule ? > > > > > > Not really, but also it's only a style issue. > > > > > > Indeed "v" and "p" are not much better... but still "vclk" does not > > > bring any additional information over "v". It's redundant. > > > > > > You can also drop entire entry - unless it helps in particular > > > implementation. > > > > There are multiple clocks, so I think names are better than indices. If > > you really insist we could name them "v", "p" and "a", but I think the > > clk suffix here improves readability. If those clocks were named > > "videoclk", "pixelclk" and "axiclk" I'd be fine dropping the suffix, but > > that's not the case here. > > I have got the below details from the HW team: > > CRU_SYSCLK -> System clock for CSI-2 DPHY > CRU_VCLK -> video clock > CRU_PCLK -> APB clock > CRU_ACLK -> AXI clock > > So I'll rename the clocks to below respectively: > > + clock-names: > + items: > + - const: system > + - const: video > + - const: apb > + - const: axi > > Does the above sound good? That's great, thank you ! -- Regards, Laurent Pinchart