From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3C94C433FE for ; Mon, 3 Oct 2022 09:51:10 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9BD8A84DCC; Mon, 3 Oct 2022 11:51:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="y0SKv42p"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 820F784DD2; Mon, 3 Oct 2022 11:51:07 +0200 (CEST) Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8A2E384D77 for ; Mon, 3 Oct 2022 11:51:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-ed1-x52c.google.com with SMTP id e18so13800095edj.3 for ; Mon, 03 Oct 2022 02:51:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=OyXWmVXBqcQgRc710NSjPi7plM3XhLUUpkhbdwXpIsc=; b=y0SKv42pqO83IusVFqumNeiHjqbtGVF+XR3nG2RfIkKSjlmDkz9B5APh25sipnFuwP 0/kV+BIVxhr1DncFf5gz5l/jP8cFdx1Qh6gjl6+KYs+detgiXHn24XDESwIuXvUTZmf8 ww4hc0eOl8cwO+kuKF7yVnFv9THCS9bUW2uzMDuqlZjOVx4yba5KUN8l0cpSMobt1vaT brJXFE4SjJu+i7WCRK48GYgBLRlStYI8RQJtwmguQ/lbitslMOGVDDfsDgGwReKgw31o LBGT86R7s8BHbmC+FPvhSUmOcWdZOWplBlOKRHUW/HO4wk3V6qj3TaPLepXtrgwwpZ+x +Ugg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=OyXWmVXBqcQgRc710NSjPi7plM3XhLUUpkhbdwXpIsc=; b=l8LIlbjAkZaCRf6rl0rR6Vp47AWh+Pga/dfz6xD0kOBJKlF8Or7QNVhcLf0pTSMmoJ 84MJ5VyFyqNjDIeX17zqWOlCBHYWVhlxczQkvtpskfDFKJUI4M2ToN2yr4kKYawu1RVH YqIR8icTl5UT5npHnSrdD4E0nM5NEZtk7pyKaevKgaDyZSFZ6cdxZ3x3VYoAl81K0xjT HvYDhBWkY83RhEop2c1zHKyTOibiKVev79SQKcdzmDP6NUjHLBIjfrs14Xehi9LcB17T EoUgSUICpDrdrDCo1XL6pe5OhFSXGi+tqgSOWdY22CcETocFF+L/4ti1SToslolcjybd 8V6w== X-Gm-Message-State: ACrzQf0lPdZJjhLuCe6aXEZdKREXgPAu3WntkaiUyBJ/xijMvrPMpHBo xvxEDBoq8ujArHNH1CZQ6lyy7g== X-Google-Smtp-Source: AMsMyM7aAV5cogdq1oFBoTpy+ZrD8iwcUMoDEXM8flTUCzA4RpsMk5ZcRTVpHNvf/uyphP5Oe/ihog== X-Received: by 2002:aa7:c050:0:b0:453:4427:a947 with SMTP id k16-20020aa7c050000000b004534427a947mr17974252edo.172.1664790664133; Mon, 03 Oct 2022 02:51:04 -0700 (PDT) Received: from hades (ppp046103015185.access.hol.gr. [46.103.15.185]) by smtp.gmail.com with ESMTPSA id kw10-20020a170907770a00b0073d7e58b1bcsm5134483ejc.157.2022.10.03.02.51.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Oct 2022 02:51:03 -0700 (PDT) Date: Mon, 3 Oct 2022 12:51:00 +0300 From: Ilias Apalodimas To: Sughosh Ganu Cc: u-boot@lists.denx.de, Heinrich Schuchardt , Takahiro Akashi , Patrick Delaunay , Patrice Chotard , Simon Glass , Bin Meng , Tom Rini , Etienne Carriere , Michal Simek , Jassi Brar Subject: Re: [PATCH v11 06/15] FWU: Add helper functions for accessing FWU metadata Message-ID: References: <20220928092956.2535777-1-sughosh.ganu@linaro.org> <20220928092956.2535777-7-sughosh.ganu@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220928092956.2535777-7-sughosh.ganu@linaro.org> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Wed, Sep 28, 2022 at 02:59:47PM +0530, Sughosh Ganu wrote: > Add weak functions for getting the update index value and dfu > alternate number needed for FWU Multi Bank update > functionality. > > The current implementation for getting the update index value is for > platforms with 2 banks. If a platform supports more than 2 banks, it > can implement it's own function. The function to get the dfu alternate > number has been added for platforms with GPT partitioned storage > devices. Platforms with other storage partition scheme need to > implement their own function. > > Signed-off-by: Sughosh Ganu > Reviewed-by: Patrick Delaunay > Acked-by: Etienne Carriere > --- > Changes since V10: None > > Note: I have not changed the logic of the check in > fwu_gpt_get_alt_num(). This can be extended if and when another GPT > based device gets added to the DFU framework. > > include/fwu.h | 29 ++++++++++ > lib/fwu_updates/fwu.c | 27 +++++++++ > lib/fwu_updates/fwu_gpt.c | 114 ++++++++++++++++++++++++++++++++++++++ > 3 files changed, 170 insertions(+) > create mode 100644 lib/fwu_updates/fwu_gpt.c > > diff --git a/include/fwu.h b/include/fwu.h > index 167f91388e..99f43f07b0 100644 > --- a/include/fwu.h > +++ b/include/fwu.h > @@ -212,4 +212,33 @@ int fwu_accept_image(efi_guid_t *img_type_id, u32 bank); > */ > int fwu_clear_accept_image(efi_guid_t *img_type_id, u32 bank); > > +/** > + * fwu_plat_get_alt_num() - Get the DFU Alt Num for the image from the platform > + * @dev: FWU device > + * @image_guid: Image GUID for which DFU alt number needs to be retrieved > + * @alt_num: Pointer to the alt_num > + * > + * Get the DFU alt number from the platform for the image specified by the > + * image GUID. > + * > + * Return: 0 if OK, -ve on error > + * > + */ > +int fwu_plat_get_alt_num(struct udevice *dev, efi_guid_t *image_guid, > + u8 *alt_num); > + > +/** > + * fwu_plat_get_update_index() - Get the value of the update bank > + * @update_idx: Bank number to which images are to be updated > + * > + * Get the value of the bank(partition) to which the update needs to be > + * made. > + * > + * Note: This is a weak function and platforms can override this with > + * their own implementation for selection of the update bank. > + * > + * Return: 0 if OK, -ve on error > + * > + */ > +int fwu_plat_get_update_index(uint *update_idx); > #endif /* _FWU_H_ */ > diff --git a/lib/fwu_updates/fwu.c b/lib/fwu_updates/fwu.c > index fe8058bc37..5cf6bec6a0 100644 > --- a/lib/fwu_updates/fwu.c > +++ b/lib/fwu_updates/fwu.c > @@ -361,3 +361,30 @@ int fwu_clear_accept_image(efi_guid_t *img_type_id, u32 bank) > return fwu_clrset_image_accept(img_type_id, bank, > IMAGE_ACCEPT_CLEAR); > } > + > +/** > + * fwu_plat_get_update_index() - Get the value of the update bank > + * @update_idx: Bank number to which images are to be updated > + * > + * Get the value of the bank(partition) to which the update needs to be > + * made. > + * > + * Note: This is a weak function and platforms can override this with > + * their own implementation for selection of the update bank. > + * > + * Return: 0 if OK, -ve on error > + * > + */ > +__weak int fwu_plat_get_update_index(uint *update_idx) > +{ > + int ret; > + u32 active_idx; > + > + ret = fwu_get_active_index(&active_idx); > + if (ret < 0) > + return -1; > + > + *update_idx = (active_idx + 1) % CONFIG_FWU_NUM_BANKS; > + > + return ret; > +} > diff --git a/lib/fwu_updates/fwu_gpt.c b/lib/fwu_updates/fwu_gpt.c > new file mode 100644 > index 0000000000..a1b0f3bea7 > --- /dev/null > +++ b/lib/fwu_updates/fwu_gpt.c > @@ -0,0 +1,114 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > +/* > + * Copyright (c) 2022, Linaro Limited > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > + > +static int get_gpt_dfu_identifier(struct blk_desc *desc, efi_guid_t *image_guid) > +{ > + int i; > + struct disk_partition info; > + efi_guid_t unique_part_guid; > + > + for (i = 1; i < MAX_SEARCH_PARTITIONS; i++) { > + if (part_get_info(desc, i, &info)) > + continue; > + uuid_str_to_bin(info.uuid, unique_part_guid.b, > + UUID_STR_FORMAT_GUID); > + > + if (!guidcmp(&unique_part_guid, image_guid)) > + return i; > + } > + > + log_err("No partition found with image_guid %pUs\n", image_guid); > + return -ENOENT; > +} > + > +static int fwu_gpt_get_alt_num(struct blk_desc *desc, efi_guid_t *image_guid, > + u8 *alt_num, unsigned char dfu_dev) > +{ > + int ret = -1; > + int i, part, dev_num; > + int nalt; > + struct dfu_entity *dfu; > + > + dev_num = desc->devnum; > + part = get_gpt_dfu_identifier(desc, image_guid); > + if (part < 0) > + return -ENOENT; > + > + dfu_init_env_entities(NULL, NULL); > + > + nalt = 0; > + list_for_each_entry(dfu, &dfu_list, list) > + nalt++; Why do we have to do this? Can't we just call dfu_get_entity() on a for(;;) loop and break out if the result is NULL? > + > + if (!nalt) { > + log_warning("No entities in dfu_alt_info\n"); > + dfu_free_entities(); > + return -ENOENT; > + } > + > + for (i = 0; i < nalt; i++) { > + dfu = dfu_get_entity(i); > + > + if (!dfu) > + continue; > + > + /* > + * Currently, Multi Bank update > + * feature is being supported > + * only on GPT partitioned > + * MMC/SD devices. > + */ > + if (dfu->dev_type != dfu_dev) > + continue; > + > + if (dfu->layout == DFU_RAW_ADDR && > + dfu->data.mmc.dev_num == dev_num && > + dfu->data.mmc.part == part) { > + *alt_num = dfu->alt; > + ret = 0; > + break; > + } I still this needs to go into a different function. Maybe in one with switch/cases where you only check DFU_DEV_MMC for now and return -ENOTSUPP for other device types > + } > + > + dfu_free_entities(); > + > + return ret; > +} > + > +/** > + * fwu_plat_get_alt_num() - Get the DFU alt number > + * @dev: FWU metadata device > + * @image_guid: GUID value of the image for which the alt num is to > + * be obtained > + * @alt_num: The DFU alt number for the image that is to be updated > + * > + * Get the DFU alt number for the image that is to be updated. The > + * image is identified with the image_guid parameter that is passed > + * to the function. > + * > + * Note: This is a weak function and platforms can override this with > + * their own implementation for obtaining the alt number value. > + * > + * Return: 0 if OK, -ve on error > + * > + */ > +__weak int fwu_plat_get_alt_num(struct udevice *dev, efi_guid_t *image_guid, > + u8 *alt_num) > +{ > + struct fwu_mdata_gpt_blk_priv *priv = dev_get_priv(dev); > + > + return fwu_gpt_get_alt_num(dev_get_uclass_plat(priv->blk_dev), > + image_guid, alt_num, DFU_DEV_MMC); > +} > -- > 2.34.1 > Cheers /Ilias