From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DB1317E9 for ; Mon, 3 Oct 2022 17:45:28 +0000 (UTC) Received: from zn.tnic (p200300ea9733e749329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e749:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id E039F1EC026E; Mon, 3 Oct 2022 19:45:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1664819122; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=plJ2XzPIs7brq2OHEhWH7olZUohmW4drMik6bkobaK8=; b=h/NWZd03ZDDYChaZJG9X1m8XSdmrio7RdvYAB9fvU6LnkKsu556+yU34LFEPtT4S0+DtbK bkbEzT5/xoQqrTUBJf2dnKJofdXjuRz9CJjLNUDgzHADxBWNuBhA5+z32F5YXOvWQX6gwB 67IRwD39ZaSHFdkca/nu44PvYz/l40k= Date: Mon, 3 Oct 2022 19:45:18 +0200 From: Borislav Petkov To: "Kalra, Ashish" Cc: "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "linux-coco@lists.linux.dev" , "linux-mm@kvack.org" , "linux-crypto@vger.kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "jroedel@suse.de" , "Lendacky, Thomas" , "hpa@zytor.com" , "ardb@kernel.org" , "pbonzini@redhat.com" , "seanjc@google.com" , "vkuznets@redhat.com" , "jmattson@google.com" , "luto@kernel.org" , "dave.hansen@linux.intel.com" , "slp@redhat.com" , "pgonda@google.com" , "peterz@infradead.org" , "srinivas.pandruvada@linux.intel.com" , "rientjes@google.com" , "dovmurik@linux.ibm.com" , "tobin@ibm.com" , "Roth, Michael" , "vbabka@suse.cz" , "kirill@shutemov.name" , "ak@linux.intel.com" , "tony.luck@intel.com" , "marcorr@google.com" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "alpergun@google.com" , "dgilbert@redhat.com" , "jarkko@kernel.org" Subject: Re: [PATCH Part2 v6 13/49] crypto:ccp: Provide APIs to issue SEV-SNP commands Message-ID: References: Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Mon, Oct 03, 2022 at 05:11:05PM +0000, Kalra, Ashish wrote: > They are basically providing the APIs for the hypervisor to manage a > SNP guest. Yes, I know. But that is not my question. Lemme try again. My previous comment was: "I think you should simply export sev_do_cmd() and call it instead." In this case, the API is a single function - sev_do_cmd() - which the hypervisor calls. So my question still stands: why is it better to have silly wrappers of sev_do_cmd() instead of having the hypervisor call sev_do_cmd() directly? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette