From: Al Viro <viro@zeniv.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "J. R. Okajima" <hooanon05g@gmail.com>,
Ira Weiny <ira.weiny@intel.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH][CFT] [coredump] don't use __kernel_write() on kmap_local_page()
Date: Tue, 4 Oct 2022 01:31:02 +0100 [thread overview]
Message-ID: <Yzt+xvE88/OENka+@ZenIV> (raw)
In-Reply-To: <CAHk-=whsOyuRhjmUQ5c1dBQYt1E4ANhObAbEspWtUyt+Pq=Kmw@mail.gmail.com>
On Mon, Oct 03, 2022 at 05:20:03PM -0700, Linus Torvalds wrote:
> On Mon, Oct 3, 2022 at 4:37 PM Al Viro <viro@zeniv.linux.org.uk> wrote:
> >
> > One variant would be to revert the original patch, put its
> > (hopefully) fixed variant into -next and let it sit there for
> > a while. Another is to put this incremental into -next and
> > merge it into mainline once it gets a sane amount of testing.
>
> Just do the incremental fix. It looks obvious enough ("oops, we need
> to get the pos _after_ we've done any skip-lseeks on the core file")
> that I think it would be just harder to follow a "revert and follow up
> with a fix".
>
> I don't think it needs a ton of extra testing, with Okajima having
> already confirmed it fixes his problem case..
OK, incremental is in #fixes, pushed out.
next prev parent reply other threads:[~2022-10-04 0:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 22:51 [PATCH][CFT] [coredump] don't use __kernel_write() on kmap_local_page() Al Viro
2022-09-28 17:57 ` Eric W. Biederman
2022-09-28 18:29 ` Al Viro
2022-10-03 3:51 ` Ira Weiny
2022-10-03 10:48 ` J. R. Okajima
2022-10-03 19:31 ` Ira Weiny
2022-10-03 22:18 ` Al Viro
2022-10-03 22:58 ` J. R. Okajima
2022-10-03 23:37 ` Al Viro
2022-10-04 0:20 ` Linus Torvalds
2022-10-04 0:31 ` Al Viro [this message]
2022-10-04 0:37 ` Linus Torvalds
2022-10-04 0:52 ` Al Viro
2022-10-04 6:18 ` Sedat Dilek
2022-10-09 10:37 ` Sedat Dilek
2022-11-09 13:57 ` Geert Uytterhoeven
2022-10-04 2:17 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yzt+xvE88/OENka+@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=hooanon05g@gmail.com \
--cc=ira.weiny@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.