From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Andreas Schwab <schwab@linux-m68k.org>,
qemu-devel@nongnu.org, Laurent Vivier <laurent@vivier.eu>
Subject: Re: [PATCH for 7.1] linux-user: fix compat with glibc >= 2.36 sys/mount.h
Date: Tue, 4 Oct 2022 10:46:34 +0100 [thread overview]
Message-ID: <YzwA+oekCPBFeWKb@redhat.com> (raw)
In-Reply-To: <Yzqd+Pyuy7fC4wj3@redhat.com>
On Mon, Oct 03, 2022 at 09:31:52AM +0100, Daniel P. Berrangé wrote:
> On Sat, Oct 01, 2022 at 11:34:20PM +0200, Andreas Schwab wrote:
> > On Aug 02 2022, Daniel P. Berrangé wrote:
> >
> > > This patch removes linux/fs.h, meaning we have to define
> > > various FS_IOC constants that are now unavailable.
> >
> > This breaks a lot of ioctl emulations, as it lacks their definitions:
>
> Urgh, very sorry about that. I of course tested it compiled, but not
> realizing a bunch of ioctls were #ifdef'd, so we ended up silently
> disabling them.
>
> >
> > #define BLKGETSIZE64 _IOR(0x12,114,size_t)
> > #define BLKDISCARD _IO(0x12,119)
> > #define BLKIOMIN _IO(0x12,120)
> > #define BLKIOOPT _IO(0x12,121)
> > #define BLKALIGNOFF _IO(0x12,122)
> > #define BLKPBSZGET _IO(0x12,123)
> > #define BLKDISCARDZEROES _IO(0x12,124)
> > #define BLKSECDISCARD _IO(0x12,125)
> > #define BLKROTATIONAL _IO(0x12,126)
> > #define BLKZEROOUT _IO(0x12,127)
> >
> > #define FIBMAP _IO(0x00,1)
> > #define FICLONE _IOW(0x94, 9, int)
> > #define FIGETBSZ _IO(0x00,2)
>
> With the exception of FICLONE from 2015, all the others here have exited
> in Linux header since 2012. Given that length of time there's no reason
> for us to conditionalize their usage. We want to see failure if they're
> unexpectedly missing from headers.
>
> I'll prepare a patch to fix all this.
I have a patch series here:
https://lists.gnu.org/archive/html/qemu-devel/2022-10/msg00351.html
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2022-10-04 9:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 16:41 [PATCH for 7.1] linux-user: fix compat with glibc >= 2.36 sys/mount.h Daniel P. Berrangé
2022-08-02 18:29 ` Richard W.M. Jones
2022-08-02 18:34 ` Richard W.M. Jones
2022-08-02 19:01 ` Peter Maydell
2022-08-03 9:27 ` Daniel P. Berrangé
2022-08-05 7:33 ` Florian Weimer
2022-08-10 9:32 ` Daniel P. Berrangé
2022-08-10 16:37 ` Laurent Vivier
2022-10-01 21:34 ` Andreas Schwab
2022-10-03 8:31 ` Daniel P. Berrangé
2022-10-04 9:46 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzwA+oekCPBFeWKb@redhat.com \
--to=berrange@redhat.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.