From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
linux-media@vger.kernel.org,
Jacopo Mondi <jacopo+renesas@jmondi.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
niklas.soderlund+renesas@ragnatech.se,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Kishon Vijay Abraham <kishon@ti.com>,
satish.nagireddy@getcruise.com, Tomasz Figa <tfiga@chromium.org>,
Michal Simek <michal.simek@xilinx.com>
Subject: Re: [PATCH v15 05/19] media: subdev: Add [GS]_ROUTING subdev ioctls and operations
Date: Tue, 4 Oct 2022 10:05:57 +0000 [thread overview]
Message-ID: <YzwFhYtzh8hPoAYv@paasikivi.fi.intel.com> (raw)
In-Reply-To: <eea402df-7468-f9fc-ed05-8581ea67f5d3@xs4all.nl>
Hi Hans,
On Tue, Oct 04, 2022 at 10:43:55AM +0200, Hans Verkuil wrote:
> Hi Sakari,
>
> On 10/4/22 00:01, Sakari Ailus wrote:
> > Hi Hans,
> >
> > On Mon, Oct 03, 2022 at 04:26:32PM +0200, Hans Verkuil wrote:
> >>> +#define V4L2_SUBDEV_ROUTE_FL_SOURCE (1U << 1)
> >>
> >> Can we rename this to _FL_INTERNAL_SOURCE? Just 'SOURCE' is very confusing
> >> IMHO. The name 'INTERNAL_SOURCE' makes it clear that it is generated internally,
> >> and so does not come from an external sink-side endpoint.
> >>
> >> I also think that the documentation for this flag in patch 04/19 is very vague,
> >> I'll comment on that patch as well.
> >
> > Having descriptive names is important but I think "SOURCE" as such is fine
> > for the purpose. Adding "INTERNAL_" adds 9 characters to what is already a
> > very long name, making the flag very clumsy to use in code. That's why I
> > would prefer to keep it as-is.
> >
>
> _FL_SOURCE is meaningless (at least to me): there are so many 'source' and 'sink'
> references, that just plain 'SOURCE' doesn't help me understand what the flag
> means. I did consider INT_SOURCE, but I thought 'INT' is too close to 'interrupt'.
> I'm OK with that, though.
>
> Another alternative would be _FL_NO_SINK: that clearly conveys that 1) there is
> no sink, and implies that 2) the source is internally generated.
>
> Or perhaps: _FL_SOURCE_ONLY?
This appears as the best compromise IMO. NO_SINK is shorter but conveying
the meaning through negation is what I don't like too much.
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2022-10-04 10:15 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 12:18 [PATCH v15 00/19] v4l: routing and streams support Tomi Valkeinen
2022-10-03 12:18 ` [PATCH v15 01/19] media: v4l2-subdev: Sort includes Tomi Valkeinen
2022-10-03 16:53 ` Laurent Pinchart
2022-10-03 12:18 ` [PATCH v15 02/19] media: add V4L2_SUBDEV_FL_STREAMS Tomi Valkeinen
2022-10-03 12:18 ` [PATCH v15 03/19] media: add V4L2_SUBDEV_CAP_STREAMS Tomi Valkeinen
2022-10-03 12:18 ` [PATCH v15 04/19] media: Documentation: Add GS_ROUTING documentation Tomi Valkeinen
2022-10-03 14:31 ` Hans Verkuil
2022-10-12 10:01 ` Tomi Valkeinen
2022-10-03 12:18 ` [PATCH v15 05/19] media: subdev: Add [GS]_ROUTING subdev ioctls and operations Tomi Valkeinen
2022-10-03 14:26 ` Hans Verkuil
2022-10-03 22:01 ` Sakari Ailus
2022-10-04 8:43 ` Hans Verkuil
2022-10-04 10:05 ` Sakari Ailus [this message]
2022-10-12 8:15 ` Tomi Valkeinen
2022-10-03 12:18 ` [PATCH v15 06/19] media: subdev: add v4l2_subdev_has_pad_interdep() Tomi Valkeinen
2022-10-03 12:18 ` [PATCH v15 07/19] media: subdev: add v4l2_subdev_set_routing helper() Tomi Valkeinen
2022-10-12 6:22 ` Yunke Cao
2022-10-12 6:58 ` Tomi Valkeinen
2022-10-03 12:18 ` [PATCH v15 08/19] media: subdev: Add for_each_active_route() macro Tomi Valkeinen
2022-10-09 5:38 ` Dafna Hirschfeld
2022-10-12 6:15 ` Tomi Valkeinen
2022-10-13 7:41 ` Sakari Ailus
2022-10-03 12:18 ` [PATCH v15 09/19] media: Documentation: add multiplexed streams documentation Tomi Valkeinen
2022-10-11 10:47 ` [PATCH 1/1] media: Documentation: Interaction between routes, formats and selections Sakari Ailus
2022-10-12 10:30 ` Tomi Valkeinen
2022-12-07 10:38 ` Sakari Ailus
2022-10-03 12:18 ` [PATCH v15 10/19] media: subdev: add stream based configuration Tomi Valkeinen
2022-10-09 6:24 ` Dafna Hirschfeld
2022-10-12 6:36 ` Tomi Valkeinen
2022-10-03 12:18 ` [PATCH v15 11/19] media: subdev: use streams in v4l2_subdev_link_validate() Tomi Valkeinen
2022-10-14 10:54 ` Sakari Ailus
2022-10-14 11:10 ` Tomi Valkeinen
2022-10-16 22:37 ` Sakari Ailus
2022-10-27 10:43 ` Tomi Valkeinen
2022-10-03 12:18 ` [PATCH v15 12/19] media: subdev: add "opposite" stream helper funcs Tomi Valkeinen
2022-10-09 7:06 ` Dafna Hirschfeld
2022-10-12 6:46 ` Tomi Valkeinen
2022-10-03 12:18 ` [PATCH v15 13/19] media: subdev: add streams to v4l2_subdev_get_fmt() helper function Tomi Valkeinen
2022-10-03 12:18 ` [PATCH v15 14/19] media: subdev: add v4l2_subdev_set_routing_with_fmt() helper Tomi Valkeinen
2022-10-03 12:18 ` [PATCH v15 15/19] media: subdev: add v4l2_subdev_routing_validate() helper Tomi Valkeinen
2022-10-03 12:18 ` [PATCH v15 16/19] media: v4l2-subdev: Add v4l2_subdev_state_xlate_streams() helper Tomi Valkeinen
2022-10-03 12:18 ` [PATCH v15 17/19] media: v4l2-subdev: Add subdev .(enable|disable)_streams() operations Tomi Valkeinen
2022-10-10 16:53 ` Dafna Hirschfeld
2022-10-12 5:59 ` Tomi Valkeinen
2022-10-03 12:18 ` [PATCH v15 18/19] media: v4l2-subdev: Add v4l2_subdev_s_stream_helper() function Tomi Valkeinen
2022-10-03 12:18 ` [PATCH v15 19/19] media: Add stream to frame descriptor Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzwFhYtzh8hPoAYv@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jacopo+renesas@jmondi.org \
--cc=kishon@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=satish.nagireddy@getcruise.com \
--cc=tfiga@chromium.org \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.