From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F5A433E7 for ; Tue, 4 Oct 2022 12:35:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664886950; x=1696422950; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=rdu3aEnJE8QH/dv4RJLZeZW13gyomgEmJe9KE3XU0Oo=; b=Bp/Tu/6rqbo4uA8JqE5zdkbiN2uGmJnNIOxOX9ksbYrbjMg3FRPQExNw Ad07Wb4FwShgVccdTxyTo1x3K/HJ0FXm0mEytTEDhndnIXk97IoZXx6A8 QqV1js4KhduCpkx2asZWBpHadMyA1yQSF5oah8riXT3ZM1n98VGK8LfP5 nIadz0IQ+T9eXstTjo52fs+Krb/Jkn6k1i8vI74e6Tun6PxyDynyiMnso g/t1wbf1iCESy3xC1274EJ/QpM7OQGHwuQ2XD5PTejQ5C0DFoh/PRB3as N1wbLzuZeUaC4RBl5khYRDJdnOJo6xFSzXRMS3JsTg3DlCedgx79JULnX g==; X-IronPort-AV: E=McAfee;i="6500,9779,10489"; a="283265492" X-IronPort-AV: E=Sophos;i="5.93,157,1654585200"; d="scan'208";a="283265492" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2022 05:35:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10490"; a="657114222" X-IronPort-AV: E=Sophos;i="5.93,157,1654585200"; d="scan'208";a="657114222" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.191]) by orsmga001.jf.intel.com with SMTP; 04 Oct 2022 05:35:45 -0700 Received: by stinkbox (sSMTP sendmail emulation); Tue, 04 Oct 2022 15:35:44 +0300 Date: Tue, 4 Oct 2022 15:35:44 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Thorsten Leemhuis Cc: stable@vger.kernel.org, regressions@lists.linux.dev, Greg Kroah-Hartman , Slade Watkins , Jerry Ling , intel-gfx@lists.freedesktop.org, David Matthew Mattli Subject: Re: Regression on 5.19.12, display flickering on Framework laptop Message-ID: References: <55905860-adf9-312c-69cc-491ac8ce1a8b@cern.ch> <03147889-B21C-449B-B110-7E504C8B0EF4@sladewatkins.net> <714903fa-16c8-4247-d69d-74af6ef50bfa@leemhuis.info> Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <714903fa-16c8-4247-d69d-74af6ef50bfa@leemhuis.info> X-Patchwork-Hint: comment On Mon, Oct 03, 2022 at 08:28:50PM +0200, Thorsten Leemhuis wrote: > > > On 03.10.22 19:48, Ville Syrjälä wrote: > > On Mon, Oct 03, 2022 at 08:45:18PM +0300, Ville Syrjälä wrote: > >> On Sat, Oct 01, 2022 at 12:07:39PM +0200, Thorsten Leemhuis wrote: > >>> On 30.09.22 14:26, Jerry Ling wrote: > >>>> > >>>> looks like someone has done it: > >>>> https://bbs.archlinux.org/viewtopic.php?pid=2059823#p2059823 > >>>> > >>>> and the bisect points to: > >>>> > >>>> |# first bad commit: [fc6aff984b1c63d6b9e54f5eff9cc5ac5840bc8c] > >>>> drm/i915/bios: Split VBT data into per-panel vs. global parts Best, Jerry | > >>> > >>> FWIW, that's 3cf050762534 in mainline. Adding Ville, its author to the > >>> list of recipients. > >> > >> I definitely had no plans to backport any of that stuff, > >> but I guess the automagics did it anyway. > >> > >> Looks like stable is at least missing this pile of stuff: > >> 50759c13735d drm/i915/pps: Keep VDD enabled during eDP probe > >> 67090801489d drm/i915/pps: Reinit PPS delays after VBT has been fully parsed > >> 8e75e8f573e1 drm/i915/pps: Split PPS init+sanitize in two > >> 586294c3c186 drm/i915/pps: Stash away original BIOS programmed PPS delays > >> 89fcdf430599 drm/i915/pps: Don't apply quirks/etc. to the VBT PPS delays if they haven't been initialized > >> 60b02a09598f drm/i915/pps: Introduce pps_delays_valid() > >> > >> But dunno if even that is enough. > > If you need testers: David (now CCed) apparently has a affected machine > and offered to test patches in a different subthread of this thread. > > >> This bug report is probably the same thing: > >> https://gitlab.freedesktop.org/drm/intel/-/issues/7013 > > Sounds like it. > > > Also cc intel-gfx... > > Ahh, sorry, should have done that when I CCed you. After looking at some logs we do end up with potentially bogus panel power sequencing delays, which may harm the LCD panel. Greg, I recommend immediate revert of this stuff, and new stable release ASAP. Plus a recommendation that no one using laptops with Intel GPUs run 5.19.12. > > Ciao, Thorsten > > > >>> Did anyone check if a revert on top of 5.19.12 works easily and solves > >>> the problem? > >>> > >>> And does anybody known if mainline affected, too? > >>> > >>> Ciao, Thorsten > >>> > >>> > >>>> On 9/30/22 07:11, Slade Watkins wrote: > >>>>> Hey Greg, > >>>>> > >>>>>> On Sep 30, 2022, at 1:59 AM, Greg KH wrote: > >>>>>> > >>>>>> On Fri, Sep 30, 2022 at 06:37:48AM +0200, Greg KH wrote: > >>>>>>> On Thu, Sep 29, 2022 at 10:26:25PM -0400, Jerry Ling wrote: > >>>>>>>> Hi, > >>>>>>>> > >>>>>>>> It has been reported by multiple users across a handful of distros > >>>>>>>> that > >>>>>>>> there seems to be regression on Framework laptop (which presumably > >>>>>>>> is not > >>>>>>>> that special in terms of mobo and display) > >>>>>>>> > >>>>>>>> Ref: > >>>>>>>> https://community.frame.work/t/psa-dont-upgrade-to-linux-kernel-5-19-12-arch1-1-on-arch-linux-gen-11-model/23171 > >>>>>>> Can anyone do a 'git bisect' to find the offending commit? > >>>>>> Also, this works for me on a gen 12 framework laptop: > >>>>>>     $ uname -a > >>>>>>     Linux frame 5.19.12 #68 SMP PREEMPT_DYNAMIC Fri Sep 30 07:02:33 > >>>>>> CEST 2022 x86_64 GNU/Linux > >>>>>> > >>>>>> so there's something odd with the older hardware? > >>>>>> > >>>>>> greg k-h > >>>>> Could be. Running git bisect for 5.19.11 and 5.19.12 (as suggested by > >>>>> the linked forum thread) returned nothing on gen 11 for me. > >>>>> > >>>>> This is very odd, > >>>>> -srw > >>>> > >>>> > >> > >> -- > >> Ville Syrjälä > >> Intel > > -- Ville Syrjälä Intel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5104C433F5 for ; Tue, 4 Oct 2022 12:35:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0872910E5E1; Tue, 4 Oct 2022 12:35:57 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8179110E5E1 for ; Tue, 4 Oct 2022 12:35:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664886952; x=1696422952; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=rdu3aEnJE8QH/dv4RJLZeZW13gyomgEmJe9KE3XU0Oo=; b=PQM+jNuGP4WZn1XUH0ap8bzdEBrBY128Yf8j2/fgdA4Er/j2U7ht85zt wJD01k4NvvuYu7LSeyGg3qvPchrGZbh2G+1asxtrP/KLPO3Gxw+xitgnl 0Eb0/6liC0MOf+X1tQmBU0e3/3eJOjQhDlhx/xczKpXfUOAXgQPr4U4jI VJnVnC6sXmNO5l8uhvzYoF12WxAhs5dLK8EQtxtslxYzbdx1ynQbTN38V 7KyoABqjuaUilPNumo1R04OtiJtIJkq15s52owgmzin2HVf2hp21J+F7H 8y5w44gvm3weP9NOfNvf17tP3Z89JtqPMQhjA6gMDpQNuheQW2WjoO+PE w==; X-IronPort-AV: E=McAfee;i="6500,9779,10490"; a="389189120" X-IronPort-AV: E=Sophos;i="5.93,157,1654585200"; d="scan'208";a="389189120" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2022 05:35:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10490"; a="657114222" X-IronPort-AV: E=Sophos;i="5.93,157,1654585200"; d="scan'208";a="657114222" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.191]) by orsmga001.jf.intel.com with SMTP; 04 Oct 2022 05:35:45 -0700 Received: by stinkbox (sSMTP sendmail emulation); Tue, 04 Oct 2022 15:35:44 +0300 Date: Tue, 4 Oct 2022 15:35:44 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Thorsten Leemhuis Message-ID: References: <55905860-adf9-312c-69cc-491ac8ce1a8b@cern.ch> <03147889-B21C-449B-B110-7E504C8B0EF4@sladewatkins.net> <714903fa-16c8-4247-d69d-74af6ef50bfa@leemhuis.info> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <714903fa-16c8-4247-d69d-74af6ef50bfa@leemhuis.info> X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] Regression on 5.19.12, display flickering on Framework laptop X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: regressions@lists.linux.dev, Greg Kroah-Hartman , intel-gfx@lists.freedesktop.org, Slade Watkins , stable@vger.kernel.org, David Matthew Mattli , Jerry Ling Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Oct 03, 2022 at 08:28:50PM +0200, Thorsten Leemhuis wrote: > > > On 03.10.22 19:48, Ville Syrjälä wrote: > > On Mon, Oct 03, 2022 at 08:45:18PM +0300, Ville Syrjälä wrote: > >> On Sat, Oct 01, 2022 at 12:07:39PM +0200, Thorsten Leemhuis wrote: > >>> On 30.09.22 14:26, Jerry Ling wrote: > >>>> > >>>> looks like someone has done it: > >>>> https://bbs.archlinux.org/viewtopic.php?pid=2059823#p2059823 > >>>> > >>>> and the bisect points to: > >>>> > >>>> |# first bad commit: [fc6aff984b1c63d6b9e54f5eff9cc5ac5840bc8c] > >>>> drm/i915/bios: Split VBT data into per-panel vs. global parts Best, Jerry | > >>> > >>> FWIW, that's 3cf050762534 in mainline. Adding Ville, its author to the > >>> list of recipients. > >> > >> I definitely had no plans to backport any of that stuff, > >> but I guess the automagics did it anyway. > >> > >> Looks like stable is at least missing this pile of stuff: > >> 50759c13735d drm/i915/pps: Keep VDD enabled during eDP probe > >> 67090801489d drm/i915/pps: Reinit PPS delays after VBT has been fully parsed > >> 8e75e8f573e1 drm/i915/pps: Split PPS init+sanitize in two > >> 586294c3c186 drm/i915/pps: Stash away original BIOS programmed PPS delays > >> 89fcdf430599 drm/i915/pps: Don't apply quirks/etc. to the VBT PPS delays if they haven't been initialized > >> 60b02a09598f drm/i915/pps: Introduce pps_delays_valid() > >> > >> But dunno if even that is enough. > > If you need testers: David (now CCed) apparently has a affected machine > and offered to test patches in a different subthread of this thread. > > >> This bug report is probably the same thing: > >> https://gitlab.freedesktop.org/drm/intel/-/issues/7013 > > Sounds like it. > > > Also cc intel-gfx... > > Ahh, sorry, should have done that when I CCed you. After looking at some logs we do end up with potentially bogus panel power sequencing delays, which may harm the LCD panel. Greg, I recommend immediate revert of this stuff, and new stable release ASAP. Plus a recommendation that no one using laptops with Intel GPUs run 5.19.12. > > Ciao, Thorsten > > > >>> Did anyone check if a revert on top of 5.19.12 works easily and solves > >>> the problem? > >>> > >>> And does anybody known if mainline affected, too? > >>> > >>> Ciao, Thorsten > >>> > >>> > >>>> On 9/30/22 07:11, Slade Watkins wrote: > >>>>> Hey Greg, > >>>>> > >>>>>> On Sep 30, 2022, at 1:59 AM, Greg KH wrote: > >>>>>> > >>>>>> On Fri, Sep 30, 2022 at 06:37:48AM +0200, Greg KH wrote: > >>>>>>> On Thu, Sep 29, 2022 at 10:26:25PM -0400, Jerry Ling wrote: > >>>>>>>> Hi, > >>>>>>>> > >>>>>>>> It has been reported by multiple users across a handful of distros > >>>>>>>> that > >>>>>>>> there seems to be regression on Framework laptop (which presumably > >>>>>>>> is not > >>>>>>>> that special in terms of mobo and display) > >>>>>>>> > >>>>>>>> Ref: > >>>>>>>> https://community.frame.work/t/psa-dont-upgrade-to-linux-kernel-5-19-12-arch1-1-on-arch-linux-gen-11-model/23171 > >>>>>>> Can anyone do a 'git bisect' to find the offending commit? > >>>>>> Also, this works for me on a gen 12 framework laptop: > >>>>>>     $ uname -a > >>>>>>     Linux frame 5.19.12 #68 SMP PREEMPT_DYNAMIC Fri Sep 30 07:02:33 > >>>>>> CEST 2022 x86_64 GNU/Linux > >>>>>> > >>>>>> so there's something odd with the older hardware? > >>>>>> > >>>>>> greg k-h > >>>>> Could be. Running git bisect for 5.19.11 and 5.19.12 (as suggested by > >>>>> the linked forum thread) returned nothing on gen 11 for me. > >>>>> > >>>>> This is very odd, > >>>>> -srw > >>>> > >>>> > >> > >> -- > >> Ville Syrjälä > >> Intel > > -- Ville Syrjälä Intel