From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D847D8C17; Mon, 13 Mar 2023 20:43:23 +0000 (UTC) Received: by mail-pl1-f175.google.com with SMTP id p20so14331416plw.13; Mon, 13 Mar 2023 13:43:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678740203; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=mXNyoC5arQMWtEnkrxAYqtf8v6fk65HvAH7Ge8NW0Ls=; b=aivckMtAvfk9rnr+NDQFEbNkV2snhcv1sf6FN6hSWIbLc20VA2uy1pAXllcRKSl/De Ao2ri32AEGLMRDxGmkY3d9I7m9sraaLJVJw/+HbkbJN8zVkoTyusV757GrMfgv6j7Ozv kRP13MJDgdQQP3MNqyGErUw88D7hGfi6+BbLizs0b8dGP5pRehyOOGtpUYLmfSsVx1Bb Upc5mcCHYkoxzTfpxo5DhcHMDbzf70XcRFLAJ0lJrpKdej3b+Zb6+MTH+bVnznGPAbrI A3V6Pxa5iyQfsBU9tqIMu4wyCVfHeyrABgymcJWL0nWKuhYQNJw5TeZzV0pUKaL1CQUP cOKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678740203; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mXNyoC5arQMWtEnkrxAYqtf8v6fk65HvAH7Ge8NW0Ls=; b=kVNEmAXPRVPtFR2YgPt1lYVnTF7YEst/sniYf8KBueSTunPCLTl6/6cOmVG+V1DVZu hut/aFYFF/cZtkbrbL2zWMOuxYmUpX9XSkDzmQUg3y0nBN9GGhszPOT9FtZWdxiPIfib wrzzzq8q80YhYkwnNQ9SYFK5WIwm6Q2N+43EZb3rGIsZQv0kMzemQPh7Hge+QTtoaEWH oV6uZ2QCsBqRg8lst//lft8L/rUTVB5gVB24ME2p7iRP66TjNb60JflMlsf8qzZbitMM JzxubZ1WK5zhic7d6A3MmxlkxiqFXghm6vKxh85WhABXqP0WAeWKYO+nq7XGJpXq0t+u EJqg== X-Gm-Message-State: AO0yUKUfGdHgQgPFApQOZRY0TR1XHXoDtI6fxOKPpDPtKs2tnERjNjlr XllfK4puQLt6H8PLyLOnIIg= X-Google-Smtp-Source: AK7set+AwAUBkbBSMXgInsDpsiW/Q6+WMMeD9QVpKujfjrdOhX2yAtowqcnvLRwifK2mPGfG4j4LNw== X-Received: by 2002:a17:902:ea0c:b0:19f:3aff:dcfd with SMTP id s12-20020a170902ea0c00b0019f3affdcfdmr6174185plg.6.1678740203271; Mon, 13 Mar 2023 13:43:23 -0700 (PDT) Received: from CloudiRingWorld ([115.227.138.102]) by smtp.gmail.com with ESMTPSA id l15-20020a17090a4d4f00b00232cf6186fdsm275421pjh.30.2023.03.13.13.43.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 13:43:23 -0700 (PDT) Date: Tue, 14 Mar 2023 04:43:20 +0800 From: Kloudifold To: teddy.wang@siliconmotion.com, sudipm.mukherjee@gmail.com, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, outreachy@lists.linux.dev Cc: linux-kernel@vger.kernel.org Subject: [PATCH v2] staging: sm750: Rename function to avoid CamelCase Message-ID: Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline The sm750 driver had some functions named in CamelCase, which violates the kernel's naming convention. In this patch, I rename these functions to snake case, which is the expected style. This v2 patch was prompted by an error reported by the Linux test robot, which detected the compile error. | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202303110849.X24WnHnM-lkp@intel.com/ Signed-off-by: Kloudifold --- drivers/staging/sm750fb/sm750.c | 22 +++++++++++----------- drivers/staging/sm750fb/sm750_cursor.c | 14 +++++++------- drivers/staging/sm750fb/sm750_cursor.h | 12 ++++++------ 3 files changed, 24 insertions(+), 24 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index effc7fcc3..9ddcd7b7d 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -121,14 +121,14 @@ static int lynxfb_ops_cursor(struct fb_info *info, struct fb_cursor *fbcursor) sm750_hw_cursor_disable(cursor); if (fbcursor->set & FB_CUR_SETSIZE) - sm750_hw_cursor_setSize(cursor, - fbcursor->image.width, - fbcursor->image.height); + sm750_hw_cursor_set_size(cursor, + fbcursor->image.width, + fbcursor->image.height); if (fbcursor->set & FB_CUR_SETPOS) - sm750_hw_cursor_setPos(cursor, - fbcursor->image.dx - info->var.xoffset, - fbcursor->image.dy - info->var.yoffset); + sm750_hw_cursor_set_pos(cursor, + fbcursor->image.dx - info->var.xoffset, + fbcursor->image.dy - info->var.yoffset); if (fbcursor->set & FB_CUR_SETCMAP) { /* get the 16bit color of kernel means */ @@ -142,14 +142,14 @@ static int lynxfb_ops_cursor(struct fb_info *info, struct fb_cursor *fbcursor) ((info->cmap.green[fbcursor->image.bg_color] & 0xfc00) >> 5) | ((info->cmap.blue[fbcursor->image.bg_color] & 0xf800) >> 11); - sm750_hw_cursor_setColor(cursor, fg, bg); + sm750_hw_cursor_set_color(cursor, fg, bg); } if (fbcursor->set & (FB_CUR_SETSHAPE | FB_CUR_SETIMAGE)) { - sm750_hw_cursor_setData(cursor, - fbcursor->rop, - fbcursor->image.data, - fbcursor->mask); + sm750_hw_cursor_set_data(cursor, + fbcursor->rop, + fbcursor->image.data, + fbcursor->mask); } if (fbcursor->enable) diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750fb/sm750_cursor.c index 43e6f52c2..ff643e33f 100644 --- a/drivers/staging/sm750fb/sm750_cursor.c +++ b/drivers/staging/sm750fb/sm750_cursor.c @@ -58,13 +58,13 @@ void sm750_hw_cursor_disable(struct lynx_cursor *cursor) poke32(HWC_ADDRESS, 0); } -void sm750_hw_cursor_setSize(struct lynx_cursor *cursor, int w, int h) +void sm750_hw_cursor_set_size(struct lynx_cursor *cursor, int w, int h) { cursor->w = w; cursor->h = h; } -void sm750_hw_cursor_setPos(struct lynx_cursor *cursor, int x, int y) +void sm750_hw_cursor_set_pos(struct lynx_cursor *cursor, int x, int y) { u32 reg; @@ -73,7 +73,7 @@ void sm750_hw_cursor_setPos(struct lynx_cursor *cursor, int x, int y) poke32(HWC_LOCATION, reg); } -void sm750_hw_cursor_setColor(struct lynx_cursor *cursor, u32 fg, u32 bg) +void sm750_hw_cursor_set_color(struct lynx_cursor *cursor, u32 fg, u32 bg) { u32 reg = (fg << HWC_COLOR_12_2_RGB565_SHIFT) & HWC_COLOR_12_2_RGB565_MASK; @@ -82,8 +82,8 @@ void sm750_hw_cursor_setColor(struct lynx_cursor *cursor, u32 fg, u32 bg) poke32(HWC_COLOR_3, 0xffe0); } -void sm750_hw_cursor_setData(struct lynx_cursor *cursor, u16 rop, - const u8 *pcol, const u8 *pmsk) +void sm750_hw_cursor_set_data(struct lynx_cursor *cursor, u16 rop, + const u8 *pcol, const u8 *pmsk) { int i, j, count, pitch, offset; u8 color, mask, opr; @@ -132,8 +132,8 @@ void sm750_hw_cursor_setData(struct lynx_cursor *cursor, u16 rop, } } -void sm750_hw_cursor_setData2(struct lynx_cursor *cursor, u16 rop, - const u8 *pcol, const u8 *pmsk) +void sm750_hw_cursor_set_data2(struct lynx_cursor *cursor, u16 rop, + const u8 *pcol, const u8 *pmsk) { int i, j, count, pitch, offset; u8 color, mask; diff --git a/drivers/staging/sm750fb/sm750_cursor.h b/drivers/staging/sm750fb/sm750_cursor.h index b59643dd6..88fa02f63 100644 --- a/drivers/staging/sm750fb/sm750_cursor.h +++ b/drivers/staging/sm750fb/sm750_cursor.h @@ -5,11 +5,11 @@ /* hw_cursor_xxx works for voyager,718 and 750 */ void sm750_hw_cursor_enable(struct lynx_cursor *cursor); void sm750_hw_cursor_disable(struct lynx_cursor *cursor); -void sm750_hw_cursor_setSize(struct lynx_cursor *cursor, int w, int h); -void sm750_hw_cursor_setPos(struct lynx_cursor *cursor, int x, int y); -void sm750_hw_cursor_setColor(struct lynx_cursor *cursor, u32 fg, u32 bg); -void sm750_hw_cursor_setData(struct lynx_cursor *cursor, u16 rop, - const u8 *data, const u8 *mask); -void sm750_hw_cursor_setData2(struct lynx_cursor *cursor, u16 rop, +void sm750_hw_cursor_set_size(struct lynx_cursor *cursor, int w, int h); +void sm750_hw_cursor_set_pos(struct lynx_cursor *cursor, int x, int y); +void sm750_hw_cursor_set_color(struct lynx_cursor *cursor, u32 fg, u32 bg); +void sm750_hw_cursor_set_data(struct lynx_cursor *cursor, u16 rop, const u8 *data, const u8 *mask); +void sm750_hw_cursor_set_data2(struct lynx_cursor *cursor, u16 rop, + const u8 *data, const u8 *mask); #endif -- 2.39.2