From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35319C7EE2F for ; Fri, 3 Mar 2023 10:19:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229816AbjCCKTM (ORCPT ); Fri, 3 Mar 2023 05:19:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229487AbjCCKTI (ORCPT ); Fri, 3 Mar 2023 05:19:08 -0500 Received: from out-25.mta1.migadu.com (out-25.mta1.migadu.com [95.215.58.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98ACD168B0 for ; Fri, 3 Mar 2023 02:19:06 -0800 (PST) Date: Fri, 3 Mar 2023 11:19:00 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1677838744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0kW2dzd3rEyl+CD4yLWkK8l1i2WlSV/ZTeNH0M+2hcM=; b=DS4XUpMPlzbaKHRnAVpOzr/6GUmjnedAJsaqpX/wb6EhL3t6Fr33Sz2Uzmsh2OpDAYagMr Zy8AbU6hmF8dGJaZLw0bUc4fp5EjJl42mF4bIsxVdKJYGWQaQ8vWDhrsznYPnLeJDNmU3+ j93ojnIj4e3TMysRnxoWACvYytH0HKk= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Richard Leitner To: Krzysztof Kozlowski Cc: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Ladislav Michl , Jaroslav Kysela , Takashi Iwai , Benjamin Bara , Benjamin Bara , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Richard Leitner Subject: Re: [PATCH v2 2/3] ASoC: dt-bindings: maxim,max9867: add clocks property Message-ID: References: <20230302-max9867-v2-0-fd2036d5e825@skidata.com> <20230302-max9867-v2-2-fd2036d5e825@skidata.com> <45d306d3-8efb-12ac-0a83-f01ca2982b0a@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <45d306d3-8efb-12ac-0a83-f01ca2982b0a@linaro.org> X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, thanks for the review and quick response! On Fri, Mar 03, 2023 at 11:09:15AM +0100, Krzysztof Kozlowski wrote: > On 03/03/2023 11:04, richard.leitner@linux.dev wrote: > > From: Richard Leitner > > > > Add clocks property to require a "mclk" definition for the > > maxim,max9867 codec. > > But why? You just wrote what the patch does, which is easy to see. > Commit msgs should explain why you are doing something. Ok. Will adapt the message in v3. > > > > > Signed-off-by: Richard Leitner > > --- > > Documentation/devicetree/bindings/sound/maxim,max9867.yaml | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/sound/maxim,max9867.yaml b/Documentation/devicetree/bindings/sound/maxim,max9867.yaml > > index 74cd163546ec..6f27029b137d 100644 > > --- a/Documentation/devicetree/bindings/sound/maxim,max9867.yaml > > +++ b/Documentation/devicetree/bindings/sound/maxim,max9867.yaml > > @@ -35,9 +35,13 @@ properties: > > reg: > > maxItems: 1 > > > > + clocks: > > + maxItems: 1 > > + > > required: > > - compatible > > - reg > > + - clocks > > > > additionalProperties: false > > > > @@ -50,6 +54,13 @@ examples: > > compatible = "maxim,max9867"; > > #sound-dai-cells = <0>; > > reg = <0x18>; > > + clocks = <&codec_clk>; > > }; > > }; > > + > > + codec_clk: clock { > > + compatible = "fixed-clock"; > > + #clock-cells = <0>; > > + clock-frequency = <12288000>; > > Drop the node, it's entirely common/regular stuff. True. I thought it is nessecary for "make DT_CHECKER_FLAGS=-m dt_binding_check" to succeed. But I just learned it in fact isn't. Thanks for the pointer and that eureka moment 😉. Will fix that in v3. > > Best regards, > Krzysztof > regards;rl From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B377C61DA4 for ; Mon, 6 Mar 2023 17:46:23 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 460BF1193; Mon, 6 Mar 2023 18:45:31 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 460BF1193 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1678124781; bh=DmQoXQumo3SpDn6JRBqtsSTm6ua0zaU5LLHb41ESiYk=; h=Date:From:To:Subject:References:In-Reply-To:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=qrecp76wZfUw8H//CqVyDYhMv4yyxxBwY15p2GwAARonurfHNN5zSJ+W0Zr00Vnrc 6tQqjcu7Qzks4d8nqDbhaSl9Uv649GnElqbD1Pau9IvboR+txjZJZORuVeWdHiMCab 7laoi/uAG9SGjJklfT1JTBGsP+n3+Lg8Sdg7lpl4= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 9AB8FF805E7; Mon, 6 Mar 2023 18:40:59 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 78CE5F80266; Fri, 3 Mar 2023 11:19:08 +0100 (CET) Received: from out-10.mta1.migadu.com (out-10.mta1.migadu.com [IPv6:2001:41d0:203:375::a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2CAB0F800BA for ; Fri, 3 Mar 2023 11:19:05 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2CAB0F800BA Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=DS4XUpMP Date: Fri, 3 Mar 2023 11:19:00 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1677838744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0kW2dzd3rEyl+CD4yLWkK8l1i2WlSV/ZTeNH0M+2hcM=; b=DS4XUpMPlzbaKHRnAVpOzr/6GUmjnedAJsaqpX/wb6EhL3t6Fr33Sz2Uzmsh2OpDAYagMr Zy8AbU6hmF8dGJaZLw0bUc4fp5EjJl42mF4bIsxVdKJYGWQaQ8vWDhrsznYPnLeJDNmU3+ j93ojnIj4e3TMysRnxoWACvYytH0HKk= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Richard Leitner To: Krzysztof Kozlowski Subject: Re: [PATCH v2 2/3] ASoC: dt-bindings: maxim,max9867: add clocks property Message-ID: References: <20230302-max9867-v2-0-fd2036d5e825@skidata.com> <20230302-max9867-v2-2-fd2036d5e825@skidata.com> <45d306d3-8efb-12ac-0a83-f01ca2982b0a@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <45d306d3-8efb-12ac-0a83-f01ca2982b0a@linaro.org> X-Migadu-Flow: FLOW_OUT X-MailFrom: richard.leitner@linux.dev X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1 Message-ID-Hash: HZIWDX7MP5XG4SBJYI6B7GDLZUYTPMJ2 X-Message-ID-Hash: HZIWDX7MP5XG4SBJYI6B7GDLZUYTPMJ2 X-Mailman-Approved-At: Mon, 06 Mar 2023 17:40:47 +0000 CC: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Ladislav Michl , Takashi Iwai , Benjamin Bara , Benjamin Bara , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Richard Leitner X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi Krzysztof, thanks for the review and quick response! On Fri, Mar 03, 2023 at 11:09:15AM +0100, Krzysztof Kozlowski wrote: > On 03/03/2023 11:04, richard.leitner@linux.dev wrote: > > From: Richard Leitner > > > > Add clocks property to require a "mclk" definition for the > > maxim,max9867 codec. > > But why? You just wrote what the patch does, which is easy to see. > Commit msgs should explain why you are doing something. Ok. Will adapt the message in v3. > > > > > Signed-off-by: Richard Leitner > > --- > > Documentation/devicetree/bindings/sound/maxim,max9867.yaml | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/sound/maxim,max9867.yaml b/Documentation/devicetree/bindings/sound/maxim,max9867.yaml > > index 74cd163546ec..6f27029b137d 100644 > > --- a/Documentation/devicetree/bindings/sound/maxim,max9867.yaml > > +++ b/Documentation/devicetree/bindings/sound/maxim,max9867.yaml > > @@ -35,9 +35,13 @@ properties: > > reg: > > maxItems: 1 > > > > + clocks: > > + maxItems: 1 > > + > > required: > > - compatible > > - reg > > + - clocks > > > > additionalProperties: false > > > > @@ -50,6 +54,13 @@ examples: > > compatible = "maxim,max9867"; > > #sound-dai-cells = <0>; > > reg = <0x18>; > > + clocks = <&codec_clk>; > > }; > > }; > > + > > + codec_clk: clock { > > + compatible = "fixed-clock"; > > + #clock-cells = <0>; > > + clock-frequency = <12288000>; > > Drop the node, it's entirely common/regular stuff. True. I thought it is nessecary for "make DT_CHECKER_FLAGS=-m dt_binding_check" to succeed. But I just learned it in fact isn't. Thanks for the pointer and that eureka moment 😉. Will fix that in v3. > > Best regards, > Krzysztof > regards;rl