All of lore.kernel.org
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: meenakshi.aggarwal@nxp.com
Cc: horia.geanta@nxp.com, V.sethi@nxp.com, pankaj.gupta@nxp.com,
	gaurav.jain@nxp.com, davem@davemloft.net,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] crypto: caam - reduce page 0 regs access to minimum
Date: Fri, 10 Mar 2023 19:17:26 +0800	[thread overview]
Message-ID: <ZAsRxvI71MvsbNMp@gondor.apana.org.au> (raw)
In-Reply-To: <20230302062055.1564514-2-meenakshi.aggarwal@nxp.com>

On Thu, Mar 02, 2023 at 11:50:54AM +0530, meenakshi.aggarwal@nxp.com wrote:
> From: Horia GeantA <horia.geanta@nxp.com>
> 
> Use job ring register map, in place of controller register map
> to access page 0 registers, as access to the controller register
> map is not permitted.
> 
> Signed-off-by: Horia GeantA <horia.geanta@nxp.com>
> ---
>  drivers/crypto/caam/caamalg.c  | 21 +++++-----
>  drivers/crypto/caam/caamhash.c | 10 +++--
>  drivers/crypto/caam/caampkc.c  |  6 +--
>  drivers/crypto/caam/caamrng.c  |  6 +--
>  drivers/crypto/caam/ctrl.c     | 74 +++++++++++++++++++++-------------
>  drivers/crypto/caam/debugfs.c  |  8 ++--
>  drivers/crypto/caam/debugfs.h  |  7 +++-
>  7 files changed, 78 insertions(+), 54 deletions(-)

With these two patches I get:

  CHECK   ../drivers/crypto/caam/ctrl.c
../drivers/crypto/caam/ctrl.c:706:27: warning: cast removes address space '__iomem' of expression
../drivers/crypto/caam/ctrl.c:705:27: warning: cast removes address space '__iomem' of expression
../drivers/crypto/caam/ctrl.c:705:17: warning: incorrect type in assignment (different address spaces)
../drivers/crypto/caam/ctrl.c:705:17:    expected struct caam_perfmon [noderef] __iomem *perfmon
../drivers/crypto/caam/ctrl.c:705:17:    got struct caam_perfmon *
../drivers/crypto/caam/ctrl.c:836:37: warning: incorrect type in argument 2 (different address spaces)
../drivers/crypto/caam/ctrl.c:836:37:    expected struct caam_perfmon *perfmon
../drivers/crypto/caam/ctrl.c:836:37:    got struct caam_perfmon [noderef] __iomem *perfmon
../drivers/crypto/caam/ctrl.c:881:32: warning: cast removes address space '__iomem' of expression
../drivers/crypto/caam/ctrl.c:880:32: warning: cast removes address space '__iomem' of expression
../drivers/crypto/caam/ctrl.c:880:22: warning: incorrect type in assignment (different address spaces)
../drivers/crypto/caam/ctrl.c:880:22:    expected struct version_regs [noderef] __iomem *vreg
../drivers/crypto/caam/ctrl.c:880:22:    got struct version_regs *
../drivers/crypto/caam/ctrl.c:450: warning: Function parameter or member 'perfmon' not described in 'caam_get_era'
../drivers/crypto/caam/ctrl.c:450: warning: Excess function parameter 'ctrl' description in 'caam_get_era'

Please always make sure your code compiles cleanly with C=1 W=1.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2023-03-10 11:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-02  6:20 [PATCH 0/2] No access to CAAM page 0 registers meenakshi.aggarwal
2023-03-02  6:20 ` [PATCH 1/2] crypto: caam - reduce page 0 regs access to minimum meenakshi.aggarwal
2023-03-10 11:17   ` Herbert Xu [this message]
2023-03-20  9:12   ` Varun Sethi
2023-03-02  6:20 ` [PATCH 2/2] crypto: caam - OP-TEE firmware support meenakshi.aggarwal
2023-03-22  6:17   ` [PATCH v2 0/2] No access to CAAM page 0 registers meenakshi.aggarwal
2023-03-22  6:17     ` [PATCH v2 1/2] crypto: caam - reduce page 0 regs access to minimum meenakshi.aggarwal
2023-03-23  6:51       ` Gaurav Jain
2023-03-29 15:51       ` kernel test robot
2023-03-22  6:17     ` [PATCH v2 2/2] crypto: caam - OP-TEE firmware support meenakshi.aggarwal
2023-04-04  6:08       ` Gaurav Jain
2023-04-05  9:07       ` [PATCH v3 0/2] No access to CAAM page 0 registers meenakshi.aggarwal
2023-04-05  9:07         ` [PATCH v3 1/2] crypto: caam - reduce page 0 regs access to minimum meenakshi.aggarwal
2023-04-12  9:40           ` Gaurav Jain
2023-04-05  9:07         ` [PATCH v3 2/2] crypto: caam - OP-TEE firmware support meenakshi.aggarwal
2023-04-12  9:40           ` Gaurav Jain
2023-04-14 11:06         ` [PATCH v3 0/2] No access to CAAM page 0 registers Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZAsRxvI71MvsbNMp@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=V.sethi@nxp.com \
    --cc=davem@davemloft.net \
    --cc=gaurav.jain@nxp.com \
    --cc=horia.geanta@nxp.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=meenakshi.aggarwal@nxp.com \
    --cc=pankaj.gupta@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.