From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03EEFC6FD1C for ; Fri, 24 Mar 2023 13:42:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231824AbjCXNm1 (ORCPT ); Fri, 24 Mar 2023 09:42:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230011AbjCXNmY (ORCPT ); Fri, 24 Mar 2023 09:42:24 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8D3E19F09; Fri, 24 Mar 2023 06:42:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 846EBB821E5; Fri, 24 Mar 2023 13:42:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A0A2C433EF; Fri, 24 Mar 2023 13:42:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1679665340; bh=3auCBNwwTe4do8Z4FC2DAOeRlZUIxijJjRP3hXaDkOY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KqZWe3ytNi2kQdPlmlTYJ8i/BIZeCYPbdWPMYIrbXLhn0BzNIicQiYvjnqIK+THxP MmjRjDgViiJS1aMOZjt/cZf59XaT7Q57e5G4q8DD8ML3MUjL/shKOYcQxqhHwI9qN/ hBxOy1xgpAREPuRkh5IrJ2Dix1GlVUsX4/BsKSwI= Date: Fri, 24 Mar 2023 14:42:17 +0100 From: Greg Kroah-Hartman To: Maxime Ripard Cc: Matti Vaittinen , Matti Vaittinen , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Andy Shevchenko , Heikki Krogerus , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Stephen Boyd , Jonathan Cameron , linux-iio@vger.kernel.org Subject: Re: [PATCH v5 1/8] drivers: kunit: Generic helpers for test device creation Message-ID: References: <25f9758f-0010-0181-742a-b18a344110cf@gmail.com> <20230323101216.w56kz3rudlj23vab@houat> <20230324123632.rtb52jh6zeopjwht@houat> <20230324130206.di2jatakyjzbtbbz@houat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230324130206.di2jatakyjzbtbbz@houat> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 24, 2023 at 02:02:06PM +0100, Maxime Ripard wrote: > On Fri, Mar 24, 2023 at 01:43:07PM +0100, Greg Kroah-Hartman wrote: > > On Fri, Mar 24, 2023 at 01:36:32PM +0100, Maxime Ripard wrote: > > > On Thu, Mar 23, 2023 at 11:21:58AM +0100, Greg Kroah-Hartman wrote: > > > > On Thu, Mar 23, 2023 at 11:12:16AM +0100, Maxime Ripard wrote: > > > > > On Wed, Mar 22, 2023 at 07:57:10PM +0100, Greg Kroah-Hartman wrote: > > > > > > > > > +/** > > > > > > > > > + * test_kunit_helper_alloc_device - Allocate a mock device for a KUnit test > > > > > > > > > + * @test: The test context object > > > > > > > > > + * > > > > > > > > > + * This allocates a fake struct &device to create a mock for a KUnit > > > > > > > > > + * test. The device will also be bound to a fake driver. It will thus be > > > > > > > > > + * able to leverage the usual infrastructure and most notably the > > > > > > > > > + * device-managed resources just like a "real" device. > > > > > > > > > > > > > > > > What specific "usual infrastructure" are you wanting to access here? > > > > > > > > > > > > > > > > And again, if you want a fake device, make a virtual one, by just > > > > > > > > calling device_create(). > > > > > > > > > > > > > > > > Or are you wanting to do "more" with that device pointer than > > > > > > > > device_create() can give you? > > > > > > > > > > > > > > Personally, I was (am) only interested in devm_ unwinding. I guess the > > > > > > > device_create(), device_add(), device_remove()... (didn't study this > > > > > > > sequence in details so sorry if there is errors) could've been sufficient > > > > > > > for me. I haven't looked how much of the code that there is for 'platform > > > > > > > devices' should be duplicated to support that sequence for testability > > > > > > > purposes. > > > > > > > > > > > > Any device can access devm_ code, there's no need for it to be a > > > > > > platform device at all. > > > > > > > > > > Sure but the resources are only released if the device is part of a bus, > > > > > so it can't be a root_device (or bare device) either > > > > > > > > The resources are not cleaned up when the device is freed no matter if > > > > it's on a bus or not? If so, then that's a bug that needs to be fixed, > > > > and tested :) > > > > > > Please have a look at: > > > https://lore.kernel.org/linux-kselftest/20230324123157.bbwvfq4gsxnlnfwb@houat/ > > > > > > I couldn't get an answer on whether it was considered a bug or not last > > > time, but as you can see there's a clear difference between a root > > > device and a platform device that has probed when it comes to resource > > > cleanup. > > > > Great, testing shows there are bugs! :) > > I mean, it wasn't clear to me that it was indeed a bug or the intent > behind devm was that it would only work when probed. Both seemed > reasonable. > > > That's a great start of a test, how about submitting that in a way that > > I can test it and we can go from there? > > Ack. > > I guess I'd need to arrange them somewhat differently for it to be > useful and merge-able. > > How would you prefer them to be submitted, in two different files > testing both the root devices and platform devices? root devices are rare, but yes, one for each would be good, thanks! greg k-h