From: Jason Gunthorpe <jgg@nvidia.com>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
Joerg Roedel <joro@8bytes.org>,
Robin Murphy <robin.murphy@arm.com>,
Will Deacon <will@kernel.org>,
Lu Baolu <baolu.lu@linux.intel.com>,
Nicolin Chen <nicolinc@nvidia.com>
Subject: Re: [PATCH 6/9] iommu: Fix iommu_probe_device() to attach the right domain
Date: Fri, 24 Mar 2023 12:42:07 -0300 [thread overview]
Message-ID: <ZB3Ez8pIENCHhDZu@nvidia.com> (raw)
In-Reply-To: <BN9PR11MB5276832381FC73EA5E8C05428C849@BN9PR11MB5276.namprd11.prod.outlook.com>
On Fri, Mar 24, 2023 at 07:29:59AM +0000, Tian, Kevin wrote:
> > From: Jason Gunthorpe <jgg@nvidia.com>
> > Sent: Wednesday, March 22, 2023 3:53 AM
> >
> > - /*
> > - * If device joined an existing group which has been claimed, don't
> > - * attach the default domain.
> > - */
> > - if (group->default_domain && !group->owner) {
> > + if (group->domain) {
> > ret = iommu_group_do_dma_first_attach(group, dev);
>
> emm this duplicates with the attach in iommu_group_add_device().
Yes, it looks like that code in iommu_group_add_device() is
nonsensical.
I added a patch to remove it, and maybe a few more patches to make
this less duplicated..
Thanks,
Jason
next prev parent reply other threads:[~2023-03-24 15:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 19:53 [PATCH 0/9] Consolidate the error handling around device attachment Jason Gunthorpe
2023-03-21 19:53 ` [PATCH 1/9] iommu: Make __iommu_group_set_domain() handle error unwind Jason Gunthorpe
2023-03-24 7:17 ` Tian, Kevin
2023-03-24 15:17 ` Jason Gunthorpe
2023-03-21 19:53 ` [PATCH 2/9] iommu: Use __iommu_group_set_domain() for __iommu_attach_group() Jason Gunthorpe
2023-03-24 7:18 ` Tian, Kevin
2023-03-21 19:53 ` [PATCH 3/9] iommu: Use __iommu_group_set_domain() in iommu_change_dev_def_domain() Jason Gunthorpe
2023-03-24 7:19 ` Tian, Kevin
2023-03-24 13:17 ` Jason Gunthorpe
2023-03-21 19:53 ` [PATCH 4/9] iommu: Replace __iommu_group_dma_first_attach() with set_domain Jason Gunthorpe
2023-03-24 7:20 ` Tian, Kevin
2023-03-21 19:53 ` [PATCH 5/9] iommu: Make iommu_group_do_dma_first_attach() simpler Jason Gunthorpe
2023-03-24 7:23 ` Tian, Kevin
2023-03-24 15:23 ` Jason Gunthorpe
2023-03-21 19:53 ` [PATCH 6/9] iommu: Fix iommu_probe_device() to attach the right domain Jason Gunthorpe
2023-03-24 7:29 ` Tian, Kevin
2023-03-24 15:42 ` Jason Gunthorpe [this message]
2023-03-24 19:36 ` Jason Gunthorpe
2023-03-21 19:53 ` [PATCH 7/9] iommu: Remove the assignment of group->domain during default domain alloc Jason Gunthorpe
2023-03-24 7:30 ` Tian, Kevin
2023-03-21 19:53 ` [PATCH 8/9] iommu: Consolidate the default_domain setup to one function Jason Gunthorpe
2023-03-21 19:53 ` [PATCH 9/9] iommu: Remove __iommu_group_for_each_dev() Jason Gunthorpe
2023-03-22 13:08 ` Joerg Roedel
2023-03-22 13:41 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZB3Ez8pIENCHhDZu@nvidia.com \
--to=jgg@nvidia.com \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.