All of lore.kernel.org
 help / color / mirror / Atom feed
From: Deepak R Varma <drv@mailo.com>
To: Kloudifold <cloudifold.3125@gmail.com>
Cc: Alison Schofield <alison.schofield@intel.com>,
	teddy.wang@siliconmotion.com, sudipm.mukherjee@gmail.com,
	gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
	outreachy@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: sm750: Rename function to avoid CamelCase
Date: Wed, 15 Mar 2023 21:43:20 +0530	[thread overview]
Message-ID: <ZBHuoGrHyWBSJcoZ@ubun2204.myguest.virtualbox.org> (raw)
In-Reply-To: <ZBHlycBoZ0JRwHZm@CloudiRingWorld>

On Wed, Mar 15, 2023 at 11:35:37PM +0800, Kloudifold wrote:
> Hi Alison,
> 
> Thanks a lot for your help, so if I send my v3 patch, should it be like
> below? (Philipp said "please make the Subject more unique", but the
> Subject could be only a few permutations of very few words, I can't see
> how it could be any more unique.)
> 
> Subject: [PATCH v2] staging: sm750: Rename functions from CamelCase to snake case
> 
> sm750 driver has sm750_hw_cursor_* functions, which are named in
> camelcase. Rename them to snake case to follow the function naming
> convention.

You may want to review similar patches submitted in the past by the developers
and get hints on how it was named then. Use it to improve your understanding,
let your own thoughtfulness prevail.

https://lore.kernel.org/?q=&a=search+all+inboxes

Thanks,
Deepak.

> 
> Changes in v3:
> - Add this changelog (Philipp)
> - Move lkp tags and link to the correct location in commit log (Alison)
> - Update the commit msg (Philip)
> - Update the commit log (Bagas, Julia)
> 
> Changes in v2:
> - Use new function names in call sites (LKP)
> 
> Signed-off-by: Kloudifold <cloudifold.3125@gmail.com>
> | Reported-by: kernel test robot <lkp@intel.com>
> | Link: https://lore.kernel.org/oe-kbuild-all/202303110849.X24WnHnM-lkp@intel.com/
> ---
> git diff message
> ---
> 



  parent reply	other threads:[~2023-03-15 16:15 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-15 15:35 [PATCH v2] staging: sm750: Rename function to avoid CamelCase Kloudifold
2023-03-15 15:43 ` Julia Lawall
2023-03-15 16:13 ` Deepak R Varma [this message]
2023-03-16  2:48 ` Bagas Sanjaya
2023-03-18  5:14   ` Ira Weiny
2023-03-18  8:50     ` Bagas Sanjaya
  -- strict thread matches above, loose matches on Subject: below --
2023-03-13 20:43 Kloudifold
2023-03-13 20:54 ` Julia Lawall
2023-03-14  0:07 ` Philipp Hortmann
2023-03-14 16:04   ` Alison Schofield
2023-03-14 16:39     ` Greg KH
2023-03-14  4:55 ` Bagas Sanjaya
2023-03-14 15:29   ` Alison Schofield
2023-03-15  3:08     ` Bagas Sanjaya
2023-03-15  4:54       ` Greg KH
2023-03-15  8:27         ` Bagas Sanjaya
2023-03-14 15:44 ` Alison Schofield
2023-03-14 15:46   ` Alison Schofield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZBHuoGrHyWBSJcoZ@ubun2204.myguest.virtualbox.org \
    --to=drv@mailo.com \
    --cc=alison.schofield@intel.com \
    --cc=cloudifold.3125@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=outreachy@lists.linux.dev \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=teddy.wang@siliconmotion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.