From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAD985681 for ; Wed, 15 Mar 2023 17:57:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3002DC433EF; Wed, 15 Mar 2023 17:57:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678903056; bh=DfarB1MGAlmk4YITXdAFNDiQiS87D+qvCwPA5G95N/g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NeNe+w3zOB4J/Son99vlIikbx69ynB6h3z3fSRASSFAatctW/INh3mwxWBBCRO38x r3FzHSzFIUE9Awuy4GdziMUaZbfrkftkcXzo7r5RdREOGbMlAbyIr9riz5cKRo0X/J jXzzzO/cGB+CGFcxJVN2MrlcNfEFWajLl9FnvAUTUCf837+kFoiC94d1NMDEArAhhH fhEhtL1+CnNHsnDkSv79xbrS6rl84eIGRST2H2iMMmD1BVkxue5gpNlXWIAjVxZPVk 2WZSr9rwgWQDGr2fkLGGb6Acecmcs1MdrzVidz0LR/4Vso2mNQoCSgSlv7sy6pxoMh mSAIQMX76/FxQ== Date: Wed, 15 Mar 2023 13:57:35 -0400 From: Sasha Levin To: Christophe Leroy Cc: Greg Kroah-Hartman , "stable@vger.kernel.org" , "patches@lists.linux.dev" , Michael Ellerman Subject: Re: [PATCH 5.15 107/145] powerpc: Check !irq instead of irq == NO_IRQ and remove NO_IRQ Message-ID: References: <20230315115738.951067403@linuxfoundation.org> <20230315115742.506375747@linuxfoundation.org> <9ad39d8b-64e8-466f-b93b-494905cd1bf0@csgroup.eu> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9ad39d8b-64e8-466f-b93b-494905cd1bf0@csgroup.eu> On Wed, Mar 15, 2023 at 12:32:27PM +0000, Christophe Leroy wrote: > > >Le 15/03/2023 à 13:12, Greg Kroah-Hartman a écrit : >> From: Christophe Leroy >> >> [ Upstream commit bab537805a10bdbf55b31324ba4a9599e0651e5e ] >> >> NO_IRQ is a relic from the old days. It is not used anymore in core >> functions. By the way, function irq_of_parse_and_map() returns value 0 >> on error. >> >> In some drivers, NO_IRQ is erroneously used to check the return of >> irq_of_parse_and_map(). >> >> It is not a real bug today because the only architectures using the >> drivers being fixed by this patch define NO_IRQ as 0, but there are >> architectures which define NO_IRQ as -1. If one day those >> architectures start using the non fixed drivers, there will be a >> problem. >> >> Long time ago Linus advocated for not using NO_IRQ, see >> https://lore.kernel.org/all/Pine.LNX.4.64.0511211150040.13959@g5.osdl.org >> >> He re-iterated the same view recently in >> https://lore.kernel.org/all/CAHk-=wg2Pkb9kbfbstbB91AJA2SF6cySbsgHG-iQMq56j3VTcA@mail.gmail.com >> >> So test !irq instead of tesing irq == NO_IRQ. >> >> All other usage of NO_IRQ for powerpc were removed in previous cycles so >> the time has come to remove NO_IRQ completely for powerpc. >> >> Signed-off-by: Christophe Leroy >> Signed-off-by: Michael Ellerman >> Link: https://lore.kernel.org/r/4b8d4f96140af01dec3a3330924dda8b2451c316.1674476798.git.christophe.leroy@csgroup.eu >> Signed-off-by: Sasha Levin > >Same, you can't remove NO_IRQ macro without first all preparation >patches merged during the 6.2 cycle. Ack, I'll drop this one. -- Thanks, Sasha