All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Bernhard Kaindl <bernhard.kaindl@citrix.com>
Subject: Re: [PATCH 7/7] tools/python: Drop shebangs from library files
Date: Thu, 16 Mar 2023 19:12:40 +0100	[thread overview]
Message-ID: <ZBNcGSJvOh0h3Den@mail-itl> (raw)
In-Reply-To: <20230314141520.3652451-8-andrew.cooper3@citrix.com>

[-- Attachment #1: Type: text/plain, Size: 3423 bytes --]

On Tue, Mar 14, 2023 at 02:15:20PM +0000, Andrew Cooper wrote:
> These aren't runable scripts, so shouldn't have shebangs.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>

> ---
> CC: Wei Liu <wl@xen.org>
> CC: Anthony PERARD <anthony.perard@citrix.com>
> CC: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> CC: Bernhard Kaindl <bernhard.kaindl@citrix.com>
> ---
>  tools/python/xen/migration/legacy.py | 1 -
>  tools/python/xen/migration/libxc.py  | 1 -
>  tools/python/xen/migration/libxl.py  | 1 -
>  tools/python/xen/migration/public.py | 1 -
>  tools/python/xen/migration/tests.py  | 1 -
>  tools/python/xen/migration/verify.py | 1 -
>  tools/python/xen/migration/xl.py     | 1 -
>  tools/python/xen/util.py             | 1 -
>  8 files changed, 8 deletions(-)
> 
> diff --git a/tools/python/xen/migration/legacy.py b/tools/python/xen/migration/legacy.py
> index 6456d6157ce3..e196ca876095 100644
> --- a/tools/python/xen/migration/legacy.py
> +++ b/tools/python/xen/migration/legacy.py
> @@ -1,4 +1,3 @@
> -#!/usr/bin/env python
>  # -*- coding: utf-8 -*-
>  
>  """
> diff --git a/tools/python/xen/migration/libxc.py b/tools/python/xen/migration/libxc.py
> index 9881f5ced4ea..e52e632cb106 100644
> --- a/tools/python/xen/migration/libxc.py
> +++ b/tools/python/xen/migration/libxc.py
> @@ -1,4 +1,3 @@
> -#!/usr/bin/env python
>  # -*- coding: utf-8 -*-
>  
>  """
> diff --git a/tools/python/xen/migration/libxl.py b/tools/python/xen/migration/libxl.py
> index 5c4d4fe0631b..5dcb50fe0207 100644
> --- a/tools/python/xen/migration/libxl.py
> +++ b/tools/python/xen/migration/libxl.py
> @@ -1,4 +1,3 @@
> -#!/usr/bin/env python
>  # -*- coding: utf-8 -*-
>  
>  """
> diff --git a/tools/python/xen/migration/public.py b/tools/python/xen/migration/public.py
> index fab2f84587b7..23183ef67db8 100644
> --- a/tools/python/xen/migration/public.py
> +++ b/tools/python/xen/migration/public.py
> @@ -1,4 +1,3 @@
> -#!/usr/bin/env python
>  # -*- coding: utf-8 -*-
>  
>  """
> diff --git a/tools/python/xen/migration/tests.py b/tools/python/xen/migration/tests.py
> index f22e2c2b7cf0..fcf94b0bb264 100644
> --- a/tools/python/xen/migration/tests.py
> +++ b/tools/python/xen/migration/tests.py
> @@ -1,4 +1,3 @@
> -#!/usr/bin/env python
>  # -*- coding: utf-8 -*-
>  
>  """
> diff --git a/tools/python/xen/migration/verify.py b/tools/python/xen/migration/verify.py
> index 1e38f4a3c01e..b847c4bd220f 100644
> --- a/tools/python/xen/migration/verify.py
> +++ b/tools/python/xen/migration/verify.py
> @@ -1,4 +1,3 @@
> -#!/usr/bin/env python
>  # -*- coding: utf-8 -*-
>  
>  """
> diff --git a/tools/python/xen/migration/xl.py b/tools/python/xen/migration/xl.py
> index 978e744dfd95..139d496654df 100644
> --- a/tools/python/xen/migration/xl.py
> +++ b/tools/python/xen/migration/xl.py
> @@ -1,4 +1,3 @@
> -#!/usr/bin/env python
>  # -*- coding: utf-8 -*-
>  
>  """
> diff --git a/tools/python/xen/util.py b/tools/python/xen/util.py
> index a11358eefa13..47ceb5bd21fe 100644
> --- a/tools/python/xen/util.py
> +++ b/tools/python/xen/util.py
> @@ -1,4 +1,3 @@
> -#!/usr/bin/env python
>  # -*- coding: utf-8 -*-
>  
>  import os
> -- 
> 2.30.2
> 

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2023-03-16 18:13 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-14 14:15 [PATCH 0/7] tools: More Python 3 fixes (part 1 of N) Andrew Cooper
2023-03-14 14:15 ` [PATCH 1/7] tools/python: Drop pylintrc Andrew Cooper
2023-03-16 11:23   ` Anthony PERARD
2023-03-16 18:00   ` Marek Marczykowski-Górecki
2023-03-14 14:15 ` [PATCH 2/7] tools/misc: Drop xencons Andrew Cooper
2023-03-16 11:33   ` Anthony PERARD
2023-03-16 12:05     ` Andrew Cooper
2023-03-16 18:01   ` Marek Marczykowski-Górecki
2023-03-14 14:15 ` [PATCH 3/7] tools: Delete trailing whitespace in python scripts Andrew Cooper
2023-03-16 11:35   ` Anthony PERARD
2023-03-16 18:02   ` Marek Marczykowski-Górecki
2023-03-14 14:15 ` [PATCH 4/7] tools/pygrub: Factor out common setup.py parts Andrew Cooper
2023-03-16 11:39   ` Anthony PERARD
2023-03-14 14:15 ` [PATCH 5/7] tools: Use -s for python shebangs Andrew Cooper
2023-03-14 14:50   ` Andrew Cooper
2023-03-16 12:15     ` Anthony PERARD
2023-03-16 19:37   ` [PATCH v2 " Andrew Cooper
2023-03-16 20:09     ` Marek Marczykowski-Górecki
2023-03-14 14:15 ` [PATCH 6/7] tools/python: Improve unit test handling Andrew Cooper
2023-03-16 18:06   ` Marek Marczykowski-Górecki
2023-03-14 14:15 ` [PATCH 7/7] tools/python: Drop shebangs from library files Andrew Cooper
2023-03-16 18:12   ` Marek Marczykowski-Górecki [this message]
2023-03-15  2:37 ` [PATCH 0/7] tools: More Python 3 fixes (part 1 of N) Henry Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZBNcGSJvOh0h3Den@mail-itl \
    --to=marmarek@invisiblethingslab.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=anthony.perard@citrix.com \
    --cc=bernhard.kaindl@citrix.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.