From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15804C74A5B for ; Fri, 17 Mar 2023 17:39:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231236AbjCQRjm (ORCPT ); Fri, 17 Mar 2023 13:39:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230506AbjCQRja (ORCPT ); Fri, 17 Mar 2023 13:39:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA51AE394; Fri, 17 Mar 2023 10:39:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A5BEA60F37; Fri, 17 Mar 2023 17:39:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A8ACC433A0; Fri, 17 Mar 2023 17:39:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679074755; bh=fQhztykTbvG44/m8npYHjnnMg6cEalBp0Xpsis3PrSc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eJUvtiQpdkk1XcDg5c7Jz/A/1L1OlYogM5EUBazvpUKdz64sBO0+N0ZTl8fGbP8vC EqvU3Nd/pBUHvbPMhMGxdjlgSNzl7lvMZykOkgZkcD7rRR+0g4NeLorPCo6EiwzMzK J+YXqoWssr6Bqg8YW+Tyz4hrGwxUrBIPDzFTESmk4OiXwwyPixsySeCVWzJaLF3Ghe I6ebDiCXuy5Eyp+0fdSdqN0KwXgdwBXmVlB8oOM7Wqz7kLWrgZrUH8h73TbEhiLUrF LuMYajWEOf1YSOKOH/u5t4aSkX3bbx25hsFom530Kqasotay84oRyTWDuacvdBwmbQ ManNJuzCADYiA== Date: Fri, 17 Mar 2023 23:09:10 +0530 From: Vinod Koul To: Jisheng Zhang Cc: Lars-Peter Clausen , Eugeniy Paltsev , Logan Gunthorpe , Sinan Kaya , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 1/5] dmaengine: dw-axi-dmac: Don't set chancnt Message-ID: References: <20230313170250.815-1-jszhang@kernel.org> <20230313170250.815-2-jszhang@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230313170250.815-2-jszhang@kernel.org> Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 14-03-23, 01:02, Jisheng Zhang wrote: > The dma framework will calculate the dma channels chancnt, setting it The dmaengine framework... > outself is wrong. s/outself/ourself Looks this this is needed for all the patches > > Signed-off-by: Jisheng Zhang > --- > drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c > index 4169e1d7d5ca..7f3a60e28e38 100644 > --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c > +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c > @@ -1445,7 +1445,6 @@ static int dw_probe(struct platform_device *pdev) > dma_cap_set(DMA_CYCLIC, dw->dma.cap_mask); > > /* DMA capabilities */ > - dw->dma.chancnt = hdata->nr_channels; > dw->dma.max_burst = hdata->axi_rw_burst_len; > dw->dma.src_addr_widths = AXI_DMA_BUSWIDTHS; > dw->dma.dst_addr_widths = AXI_DMA_BUSWIDTHS; > -- > 2.39.2 -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9650FC74A5B for ; Fri, 17 Mar 2023 17:40:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4hwgVf4QJQEZzEf6rKs5IVf7s1SRzw1r85yixER5Pw0=; b=f1KxeFVG1ueXVo b7i3uQm9CmlOihLKSPq43HxGxQCheDnCIr6IyvNuDM5wEmp0hcwX7CDB21xPFPyAPXjGc7Y6WYIhv 2iLBGvY7YVo2kJEKtoV8x4wAjeulf7SmT5uBR2w2J7szfPDj0KzcGxvwIZLul+A8NBMViEJrb71v0 zZfGpolQa/hNlAjK8q9LwpOMOZMSGqMcYloojo6tL22JD3IYtj6kMkAtRXWs95ygmInoGZ+nrHJR+ ddN0iKBTfxvP3WAENnvVAIMih0WOGv2slPz41W+kLn2gOMdr/MrWdAIvCdg4qn1I5GNaH0efROrWL yb3i6Qi7UrCZARvJzNLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pdE2w-002ucv-0o; Fri, 17 Mar 2023 17:39:18 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pdE2t-002ubt-2D for linux-arm-kernel@lists.infradead.org; Fri, 17 Mar 2023 17:39:17 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 43F7860AAD; Fri, 17 Mar 2023 17:39:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A8ACC433A0; Fri, 17 Mar 2023 17:39:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679074755; bh=fQhztykTbvG44/m8npYHjnnMg6cEalBp0Xpsis3PrSc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eJUvtiQpdkk1XcDg5c7Jz/A/1L1OlYogM5EUBazvpUKdz64sBO0+N0ZTl8fGbP8vC EqvU3Nd/pBUHvbPMhMGxdjlgSNzl7lvMZykOkgZkcD7rRR+0g4NeLorPCo6EiwzMzK J+YXqoWssr6Bqg8YW+Tyz4hrGwxUrBIPDzFTESmk4OiXwwyPixsySeCVWzJaLF3Ghe I6ebDiCXuy5Eyp+0fdSdqN0KwXgdwBXmVlB8oOM7Wqz7kLWrgZrUH8h73TbEhiLUrF LuMYajWEOf1YSOKOH/u5t4aSkX3bbx25hsFom530Kqasotay84oRyTWDuacvdBwmbQ ManNJuzCADYiA== Date: Fri, 17 Mar 2023 23:09:10 +0530 From: Vinod Koul To: Jisheng Zhang Cc: Lars-Peter Clausen , Eugeniy Paltsev , Logan Gunthorpe , Sinan Kaya , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 1/5] dmaengine: dw-axi-dmac: Don't set chancnt Message-ID: References: <20230313170250.815-1-jszhang@kernel.org> <20230313170250.815-2-jszhang@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230313170250.815-2-jszhang@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230317_103915_761041_3E6BCB09 X-CRM114-Status: GOOD ( 16.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14-03-23, 01:02, Jisheng Zhang wrote: > The dma framework will calculate the dma channels chancnt, setting it The dmaengine framework... > outself is wrong. s/outself/ourself Looks this this is needed for all the patches > > Signed-off-by: Jisheng Zhang > --- > drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c > index 4169e1d7d5ca..7f3a60e28e38 100644 > --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c > +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c > @@ -1445,7 +1445,6 @@ static int dw_probe(struct platform_device *pdev) > dma_cap_set(DMA_CYCLIC, dw->dma.cap_mask); > > /* DMA capabilities */ > - dw->dma.chancnt = hdata->nr_channels; > dw->dma.max_burst = hdata->axi_rw_burst_len; > dw->dma.src_addr_widths = AXI_DMA_BUSWIDTHS; > dw->dma.dst_addr_widths = AXI_DMA_BUSWIDTHS; > -- > 2.39.2 -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel