From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68907EA1 for ; Mon, 20 Mar 2023 01:43:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679276623; x=1710812623; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=YxjmBq6ikxvqoFB0iL+NlLNlseMTypJf5oOjYf5MAyM=; b=hAjOiGw97clEFJe7JLt46/CtXfYzBuTV6MPANYxiu1ABifPE6n3jXS7/ KVutQpXs+r7gMtna4rkzSiBDrKE0Clw2hdDyZvvtshQZYqS7I4P+CsNFY v+2lNDuWRLkEhVVrikfuEIhdgpCrgVWWi6FQI98b174TW3fOuG8eHNV51 x8LQbVjUhpb/qryJpeIikxBSzyytx1dIGlyt8HsUZ5BjcGA2t3Yk+jAg2 RqGkuiFqsYJ7y23m9b0omhalrtkWe7hASyvL2AfcaNcdt+u2U7rXaHJCT j4f3m49Fufm59VWfM7ejXiObHV8X7DyY9LkuVd6l53sNVj9Xx4Sy0gsty Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10654"; a="337269057" X-IronPort-AV: E=Sophos;i="5.98,274,1673942400"; d="scan'208";a="337269057" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2023 18:43:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10654"; a="804741234" X-IronPort-AV: E=Sophos;i="5.98,274,1673942400"; d="scan'208";a="804741234" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.165]) by orsmga004.jf.intel.com with ESMTP; 19 Mar 2023 18:43:39 -0700 Date: Mon, 20 Mar 2023 09:32:16 +0800 From: Xu Yilun To: Tom Rix Cc: mdf@kernel.org, hao.wu@intel.com, michal.simek@xilinx.com, nathan@kernel.org, ndesaulniers@google.com, linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] fpga: xilinx-pr-decoupler: remove unused xlnx_pr_decouple_read function Message-ID: References: <20230317230617.1673923-1-trix@redhat.com> <7cab9365-6493-2de0-bcef-cd46809056a8@redhat.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7cab9365-6493-2de0-bcef-cd46809056a8@redhat.com> On 2023-03-18 at 05:59:28 -0700, Tom Rix wrote: > > On 3/18/23 2:59 AM, Xu Yilun wrote: > > On 2023-03-17 at 19:06:17 -0400, Tom Rix wrote: > > > clang with W=1 reports > > > drivers/fpga/xilinx-pr-decoupler.c:37:19: error: unused function 'xlnx_pr_decouple_read' [-Werror,-Wunused-function] > > > static inline u32 xlnx_pr_decouple_read(const struct xlnx_pr_decoupler_data *d, > > > ^ > > > This static function is not used, so remove it. > > I prefer to move the description as the first section. If you agree, I > > could do it before apply. > > I have no preference, that is fine. Applied, thanks. > > Tom > > > > > Acked-by: Xu Yilun > > > > > Signed-off-by: Tom Rix > > > --- > > > drivers/fpga/xilinx-pr-decoupler.c | 6 ------ > > > 1 file changed, 6 deletions(-) > > > > > > diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c > > > index 2d9c491f7be9..b6f18c07c752 100644 > > > --- a/drivers/fpga/xilinx-pr-decoupler.c > > > +++ b/drivers/fpga/xilinx-pr-decoupler.c > > > @@ -34,12 +34,6 @@ static inline void xlnx_pr_decoupler_write(struct xlnx_pr_decoupler_data *d, > > > writel(val, d->io_base + offset); > > > } > > > -static inline u32 xlnx_pr_decouple_read(const struct xlnx_pr_decoupler_data *d, > > > - u32 offset) > > > -{ > > > - return readl(d->io_base + offset); > > > -} > > > - > > > static int xlnx_pr_decoupler_enable_set(struct fpga_bridge *bridge, bool enable) > > > { > > > int err; > > > -- > > > 2.27.0 > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2098DC7618A for ; Mon, 20 Mar 2023 01:45:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1MTP+LF5+Q2T/67JcvjPGBAxms78z+67DlrtjjssM6Q=; b=rt9BK0lu5rDiER dWGCYrrR1VljNTqoRyEEADrlH6UFW+zIksdbkoW73Oo/zvHCvzybpz2dKuE7VuLvx+IEOjBmeK2FT iYl5Mtl/NMmr7qy3gdRU76Sys9r8VxxTQLNcQidzMdw8gkdArsy1gTVTWcCAgwwU8SCLDNVtCwdjH 4m9wvzIwCOJIgJ6T1YAXd+ejLUrhnX9fQjYBTOUEfNlv/iPesKdWCFgxQLo0SJiOmMI6t2Rb228Xw lKTiz8ZsF9iR0ArqpzJn4/3PwGIX6xnRvW+8eMBw1zwuOH4Q+Zr95B+gbzl/+vZC78vtg6i77iLKi Vtjh0xf9B5jNN+RtM7UA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pe4Yy-007sPq-11; Mon, 20 Mar 2023 01:43:52 +0000 Received: from mga04.intel.com ([192.55.52.120]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pe4Yv-007sP0-0m for linux-arm-kernel@lists.infradead.org; Mon, 20 Mar 2023 01:43:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679276629; x=1710812629; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=YxjmBq6ikxvqoFB0iL+NlLNlseMTypJf5oOjYf5MAyM=; b=BwNIlsxj6CKYV98vsp1rx/bYuTBd4E+rjRZFiofAg3U+qVBOAHblQoNl 4wRw7LhAnnNKC8oEbQKkbNlrzHvP3nB75naiDXx6WvSUbFmelyGfLRXb1 KoQQBFS9P+gUw4+Vcg3uRaWybl4nQelLG77bW+dcufoPOruiGYPKaES7k EtnHp+93NAc95qVRSj7RymfEbOEl8O+6ennoshvoRMP+rqCwuisW9p++Q JGX1wKfeBpTNCTZVyM+P1LGI9R8BC8emEqDHDhEPdTdvUE6xskIsGpdo6 R8X71u8fgnIRGO+HDNwkxrxatgS/z6WLD+ptB4Am/0W+juTMa6p8t8hoh w==; X-IronPort-AV: E=McAfee;i="6600,9927,10654"; a="337269059" X-IronPort-AV: E=Sophos;i="5.98,274,1673942400"; d="scan'208";a="337269059" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2023 18:43:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10654"; a="804741234" X-IronPort-AV: E=Sophos;i="5.98,274,1673942400"; d="scan'208";a="804741234" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.165]) by orsmga004.jf.intel.com with ESMTP; 19 Mar 2023 18:43:39 -0700 Date: Mon, 20 Mar 2023 09:32:16 +0800 From: Xu Yilun To: Tom Rix Cc: mdf@kernel.org, hao.wu@intel.com, michal.simek@xilinx.com, nathan@kernel.org, ndesaulniers@google.com, linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] fpga: xilinx-pr-decoupler: remove unused xlnx_pr_decouple_read function Message-ID: References: <20230317230617.1673923-1-trix@redhat.com> <7cab9365-6493-2de0-bcef-cd46809056a8@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7cab9365-6493-2de0-bcef-cd46809056a8@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230319_184349_295733_0ECE8BCD X-CRM114-Status: GOOD ( 18.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2023-03-18 at 05:59:28 -0700, Tom Rix wrote: > > On 3/18/23 2:59 AM, Xu Yilun wrote: > > On 2023-03-17 at 19:06:17 -0400, Tom Rix wrote: > > > clang with W=1 reports > > > drivers/fpga/xilinx-pr-decoupler.c:37:19: error: unused function 'xlnx_pr_decouple_read' [-Werror,-Wunused-function] > > > static inline u32 xlnx_pr_decouple_read(const struct xlnx_pr_decoupler_data *d, > > > ^ > > > This static function is not used, so remove it. > > I prefer to move the description as the first section. If you agree, I > > could do it before apply. > > I have no preference, that is fine. Applied, thanks. > > Tom > > > > > Acked-by: Xu Yilun > > > > > Signed-off-by: Tom Rix > > > --- > > > drivers/fpga/xilinx-pr-decoupler.c | 6 ------ > > > 1 file changed, 6 deletions(-) > > > > > > diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c > > > index 2d9c491f7be9..b6f18c07c752 100644 > > > --- a/drivers/fpga/xilinx-pr-decoupler.c > > > +++ b/drivers/fpga/xilinx-pr-decoupler.c > > > @@ -34,12 +34,6 @@ static inline void xlnx_pr_decoupler_write(struct xlnx_pr_decoupler_data *d, > > > writel(val, d->io_base + offset); > > > } > > > -static inline u32 xlnx_pr_decouple_read(const struct xlnx_pr_decoupler_data *d, > > > - u32 offset) > > > -{ > > > - return readl(d->io_base + offset); > > > -} > > > - > > > static int xlnx_pr_decoupler_enable_set(struct fpga_bridge *bridge, bool enable) > > > { > > > int err; > > > -- > > > 2.27.0 > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel