From: Christoph Hellwig <hch@infradead.org>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v3 02/12] btrfs: introduce a new helper to submit bio for scrub
Date: Tue, 21 Mar 2023 05:02:37 -0700 [thread overview]
Message-ID: <ZBmc3ZqDVzb/hVDD@infradead.org> (raw)
In-Reply-To: <b61263cba690fd894e21d75442556ae2f150f095.1679278088.git.wqu@suse.com>
> @@ -39,6 +39,8 @@ void btrfs_bio_init(struct btrfs_bio *bbio, struct btrfs_inode *inode,
> bbio->end_io = end_io;
> bbio->private = private;
> atomic_set(&bbio->pending_ios, 1);
> + if (inode)
> + bbio->fs_info = inode->root->fs_info;
> }
Please split modifications to the btrfs_bio infrastructure into
separate patches. And we'll need a proper helper to allocate these
non-bio inodes that ensures fs_info is always set.
> struct btrfs_bio *bbio = btrfs_bio(bio);
> struct btrfs_device *dev = bio->bi_private;
> - struct btrfs_fs_info *fs_info = bbio->inode->root->fs_info;
> + struct btrfs_fs_info *fs_info = bbio->inode ?
> + bbio->inode->root->fs_info : bbio->fs_info;
.. and all places that just need the fs_info need to just use
bbio->fs_info instead of these complicated constructs.
next prev parent reply other threads:[~2023-03-21 12:02 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 2:12 [PATCH v3 00/12] btrfs: scrub: use a more reader friendly code to implement scrub_simple_mirror() Qu Wenruo
2023-03-20 2:12 ` [PATCH v3 01/12] btrfs: scrub: use dedicated super block verification function to scrub one super block Qu Wenruo
2023-03-21 5:22 ` Anand Jain
2023-03-21 7:25 ` Qu Wenruo
2023-03-21 22:12 ` David Sterba
2023-03-20 2:12 ` [PATCH v3 02/12] btrfs: introduce a new helper to submit bio for scrub Qu Wenruo
2023-03-21 12:02 ` Christoph Hellwig [this message]
2023-03-24 9:58 ` Qu Wenruo
2023-03-25 8:09 ` Christoph Hellwig
2023-03-25 8:21 ` Qu Wenruo
2023-03-25 8:31 ` Christoph Hellwig
2023-03-25 8:48 ` Qu Wenruo
2023-03-27 3:36 ` Christoph Hellwig
2023-03-20 2:12 ` [PATCH v3 03/12] btrfs: introduce a new helper to submit write " Qu Wenruo
2023-03-21 0:14 ` David Sterba
2023-03-21 0:54 ` Qu Wenruo
2023-03-21 1:27 ` David Sterba
2023-03-23 8:48 ` Qu Wenruo
2023-03-20 2:12 ` [PATCH v3 04/12] btrfs: scrub: introduce the structure for new BTRFS_STRIPE_LEN based interface Qu Wenruo
2023-03-21 0:22 ` David Sterba
2023-03-20 2:12 ` [PATCH v3 05/12] btrfs: scrub: introduce a helper to find and fill the sector info for a scrub_stripe Qu Wenruo
2023-03-20 2:12 ` [PATCH v3 06/12] btrfs: scrub: introduce a helper to verify one metadata Qu Wenruo
2023-03-21 0:31 ` David Sterba
2023-03-20 2:12 ` [PATCH v3 07/12] btrfs: scrub: introduce a helper to verify one scrub_stripe Qu Wenruo
2023-03-20 2:12 ` [PATCH v3 08/12] btrfs: scrub: introduce the main read repair worker for scrub_stripe Qu Wenruo
2023-03-20 2:12 ` [PATCH v3 09/12] btrfs: scrub: introduce a writeback helper " Qu Wenruo
2023-03-21 0:43 ` David Sterba
2023-03-20 2:12 ` [PATCH v3 10/12] btrfs: scrub: introduce error reporting functionality " Qu Wenruo
2023-03-20 2:12 ` [PATCH v3 11/12] btrfs: scrub: introduce the helper to queue a stripe for scrub Qu Wenruo
2023-03-20 2:12 ` [PATCH v3 12/12] btrfs: scrub: switch scrub_simple_mirror() to scrub_stripe infrastructure Qu Wenruo
2023-03-21 1:12 ` David Sterba
2023-03-21 0:09 ` [PATCH v3 00/12] btrfs: scrub: use a more reader friendly code to implement scrub_simple_mirror() David Sterba
2023-03-23 6:28 ` Qu Wenruo
2023-03-23 17:51 ` David Sterba
2023-03-24 0:42 ` Qu Wenruo
2023-03-27 23:28 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBmc3ZqDVzb/hVDD@infradead.org \
--to=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.