All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <simon.horman@corigine.com>
To: Tom Rix <trix@redhat.com>
Cc: isdn@linux-pingi.de, nathan@kernel.org, ndesaulniers@google.com,
	kuba@kernel.org, alexanderduyck@fb.com, yangyingliang@huawei.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	llvm@lists.linux.dev
Subject: Re: [PATCH] mISDN: remove unused vpm_read_address function
Date: Wed, 22 Mar 2023 14:20:46 +0100	[thread overview]
Message-ID: <ZBsArtzFkgz+05LK@corigine.com> (raw)
In-Reply-To: <20230321120127.1782548-1-trix@redhat.com>

On Tue, Mar 21, 2023 at 08:01:27AM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/isdn/hardware/mISDN/hfcmulti.c:667:1: error: unused function
>   'vpm_read_address' [-Werror,-Wunused-function]
> vpm_read_address(struct hfc_multi *c)
> ^
> This function is not used, so remove it.

Yes, agreed.

But with this patch applied, make CC=clang W=1 tells me:

  CALL    scripts/checksyscalls.sh
  CC [M]  drivers/isdn/hardware/mISDN/hfcmulti.o
drivers/isdn/hardware/mISDN/hfcmulti.c:643:1: error: unused function 'cpld_read_reg' [-Werror,-Wunused-function]

So perhaps cpld_read_reg should be removed too?

  reply	other threads:[~2023-03-22 13:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-21 12:01 [PATCH] mISDN: remove unused vpm_read_address function Tom Rix
2023-03-22 13:20 ` Simon Horman [this message]
2023-03-23 15:18   ` Tom Rix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZBsArtzFkgz+05LK@corigine.com \
    --to=simon.horman@corigine.com \
    --cc=alexanderduyck@fb.com \
    --cc=isdn@linux-pingi.de \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=trix@redhat.com \
    --cc=yangyingliang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.