From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF89BC74A5B for ; Wed, 22 Mar 2023 13:51:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230333AbjCVNvA (ORCPT ); Wed, 22 Mar 2023 09:51:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230496AbjCVNur (ORCPT ); Wed, 22 Mar 2023 09:50:47 -0400 Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3C035B5C5 for ; Wed, 22 Mar 2023 06:50:24 -0700 (PDT) Received: by mail-qt1-x832.google.com with SMTP id a5so970455qto.6 for ; Wed, 22 Mar 2023 06:50:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1679493023; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6bcMdqrDTpV7GQZYoqohGEjM2vNgmi5vHWqlOFfnZpI=; b=dfhl2VGKLqCwhC0ttLb8Wuc1TfP3XEfsEx4DS4tWjMKzEdsef0/40Iw20bzsxUTGoB Uc377nAaWbzkSFLwcS75f56Xgay32nTjcFyNoN86htj7htsF9hh22OWb8pqnBbaN3416 Y5vrMmVM+mlmzrFnbocrqzxmixjmIJZHdMAk+Fbji1YrkYBoy35TWvLW+I1Vn3yz2b7L dP2lS1YHH7q1KvOdKYQPst09wXNV9sshjO3o04g/MY7+KJYQ3OrsW6A++P7luorGWvOc 6atugU3tCj3swuVpwOo6hIec1r2DFWLuxmsr/lKgP0NYpc4RzxqdVogq9C+1Ik2/wtu2 iWZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679493023; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6bcMdqrDTpV7GQZYoqohGEjM2vNgmi5vHWqlOFfnZpI=; b=2E9XAgz7kneHz9dCYPQztuIIk4Frmr98adLd3GmKSgHL196S6vTPRkWgoF2dcuG0cM JPM0f9iMZPqXK1P5Ll/FOHf/MMruXuWTro8aC/YxcbKTVSs7jzFC3c8Vpi2eq5LtHp9o dcipsCiK98Z7aCTw7DYLE4CKSu2MS+58ICdGL1i7pJfLkFERdTZ6BcIXVHubh5RfpPhx 8UHcL5klrUM3yh0+JLPWPuaEoqVwTGSRg8xUlSOk5gUR7qLgvv8GKgcmENPDEyPV0Z7/ VjI9mhtb+zxztHglv978BX7/sGn8IgyaQmBa/cFtKupEDmDJHpKVKeKzEwIMRKld+YHi 9GOw== X-Gm-Message-State: AO0yUKVf+X8fN0uwuAsKAAO1ZuV2lz7gCdxO1XXfI1x+4QB4iQFH9DeL tdwIsVon+AYW0LCxfOPmWNkwwQ== X-Google-Smtp-Source: AK7set9HaqgA+mB5FLvP7fffXukwDbftHJGzBXepOVRzCPehSGRFi7DTK75viPzlJj+TGqowV41iBg== X-Received: by 2002:a05:622a:1744:b0:3b8:6788:bf25 with SMTP id l4-20020a05622a174400b003b86788bf25mr6466186qtk.23.1679493023634; Wed, 22 Mar 2023 06:50:23 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-25-194.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.25.194]) by smtp.gmail.com with ESMTPSA id d140-20020a376892000000b007467a4d8691sm7488138qkc.47.2023.03.22.06.50.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Mar 2023 06:50:23 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1peyr8-000nYT-Gw; Wed, 22 Mar 2023 10:50:22 -0300 Date: Wed, 22 Mar 2023 10:50:22 -0300 From: Jason Gunthorpe To: Sagi Grimberg Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, Christoph Hellwig , Keith Busch , Chaitanya Kulkarni , linux-rdma@vger.kernel.org Subject: Re: [PATCH] blk-mq-rdma: remove queue mapping helper for rdma devices Message-ID: References: <20230322123703.485544-1-sagi@grimberg.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Mar 22, 2023 at 03:00:08PM +0200, Sagi Grimberg wrote: > > > > No rdma device exposes its irq vectors affinity today. So the only > > > mapping that we have left, is the default blk_mq_map_queues, which > > > we fallback to anyways. Also fixup the only consumer of this helper > > > (nvme-rdma). > > > > This was the only caller of ib_get_vector_affinity() so please delete > > op get_vector_affinity and ib_get_vector_affinity() from verbs as well > > Yep, no problem. > > Given that nvme-rdma was the only consumer, do you prefer this goes from > the nvme tree? Sure, it is probably fine Jason