From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0704C6FD1F for ; Wed, 22 Mar 2023 16:34:55 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 818083CD2AD for ; Wed, 22 Mar 2023 17:34:53 +0100 (CET) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [IPv6:2001:4b78:1:20::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 03C913C5624 for ; Wed, 22 Mar 2023 17:34:37 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 4C1C41A00651 for ; Wed, 22 Mar 2023 17:34:35 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 571A520FE6; Wed, 22 Mar 2023 16:34:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1679502875; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=abLU0OUS1R8qklp78Wgev8Z6EAhwwPRS721eXmgdr9I=; b=eJ/NpDQRkntH+eL2Faezuo/RxtSMJ47DtZDZZBKv5tHk6Qr13p8VOKaLHbjc8+Q8/sa0Iu Q0AMxVheZDUK0JJmvJP/b3vxyI4Q/9QFlct+y4CAnzGLzApeWLomYRVkSbszux6jGULAPf Rkd18kRTliefV6hkUbV/K5oFDe40Lo0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1679502875; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=abLU0OUS1R8qklp78Wgev8Z6EAhwwPRS721eXmgdr9I=; b=JfG0SDzceNw2XOAfy2W/rn+12Tz3ouMQxdwPsgmeGixaw+LFFxCAWyg5CMcOLVeUbQAqWs PjzYM6uAkuHcErDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4353B13416; Wed, 22 Mar 2023 16:34:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id vGraDhsuG2R9cwAAMHmgww (envelope-from ); Wed, 22 Mar 2023 16:34:35 +0000 Date: Wed, 22 Mar 2023 17:35:46 +0100 From: Cyril Hrubis To: Petr Vorel Message-ID: References: <20230217151036.10295-1-pvorel@suse.cz> <20230217151036.10295-2-pvorel@suse.cz> <20230322162046.GA369840@pevik> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230322162046.GA369840@pevik> X-Virus-Scanned: clamav-milter 0.102.4 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v2 1/2] tst_net.sh: Detect IPv6 disabled via sysct X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > No, but we already use sysctl in tst_init_iface(): > sysctl -qw net.ipv6.conf.$iface.accept_dad=0 || return $? > tst_rhost_run -c "sysctl -qw net.ipv6.conf.$iface.accept_dad=0" || return $? > > and we don't check for sysctl (expecting is everywhere). I'd also allow using > sysctl (and then add a check via tst_require_cmds) or change also these with > cat for reading and echo ... > for writing. WDYT? I would say that sysctl is useful when you have a config file with a bunch of values to be changed, but I would avoid using it in scripts, because all it does in that cases to perepend the proc part of the path and converts dots into slashes. And sometimes, when a path component contains a dot, it fails to replace the right dots into slashes too: http://lists.busybox.net/pipermail/busybox-cvs/2008-October/028382.html -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp