From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1E98C761AF for ; Wed, 22 Mar 2023 18:49:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231218AbjCVSto (ORCPT ); Wed, 22 Mar 2023 14:49:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230367AbjCVStl (ORCPT ); Wed, 22 Mar 2023 14:49:41 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0EA17D8F; Wed, 22 Mar 2023 11:49:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5ch/QuOr2IZ30W763hH9kORlChf/b8rQ2pXYI9kCiyM=; b=Jg+7Mh/3ttDZ569MnI38xXsm2M KgOQL4twwfiN/0R2VTr8Q+E6Q7BG5RVG5PQ51jZaxo2UwDyWAtBoOngLa0nDD9UdOuk905yFNRJcx bP8twzpPWKr6Hz/hYDZNWZyxeB+4n12owINGX84Uej0E6eobHvVFkRCdDM6zNxNWwzI1017gEIfSr fA1Zs/7xWDwt/bH1Vg83A2Zc8GjiNrb3+5SHWd8MYFMRFknWwKUr6s9iG34Zfws4qzN5NovEv3O76 d0tHhIxq4NdfGSstfThJxzufIS6d3bgdvBLfeTeSgLfw4SydRopROv43UIDvNQSd3BIwH2xecBwFW N5VO2O9Q==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pf3WX-003Fix-V1; Wed, 22 Mar 2023 18:49:26 +0000 Date: Wed, 22 Mar 2023 18:49:25 +0000 From: Matthew Wilcox To: David Howells Cc: Trond Myklebust , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexander Viro , Christoph Hellwig , Jens Axboe , Jeffrey Layton , Christian Brauner , Linus Torvalds , "netdev@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , Anna Schumaker , Charles Edward Lever , "linux-nfs@vger.kernel.org" Subject: Re: [RFC PATCH] iov_iter: Add an iterator-of-iterators Message-ID: References: <9C741BDB-31B0-460C-8FE7-F1C9B49002D5@hammerspace.com> <8F8B62FD-0F16-4383-BB34-97E850DAA7AF@hammerspace.com> <3DFBF27C-A62B-4AFE-87FD-3DF53FC39E8E@hammerspace.com> <20230316152618.711970-1-dhowells@redhat.com> <20230316152618.711970-28-dhowells@redhat.com> <754534.1678983891@warthog.procyon.org.uk> <809995.1678990010@warthog.procyon.org.uk> <3416400.1679508945@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3416400.1679508945@warthog.procyon.org.uk> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 22, 2023 at 06:15:45PM +0000, David Howells wrote: > @@ -43,17 +44,17 @@ struct iov_iter { > bool nofault; > bool data_source; > bool user_backed; > - union { > - size_t iov_offset; > - int last_offset; > - }; > + bool spliceable; We've now up to five u8s in a row here (iter_type, nofault, data_source, user_backed). Is it time to turn some/all of them into: bool nofault:1; bool data_source:1; bool user_backed:1; bool spliceable:1; You can't take the address of them then, but I don't believe we do that anywhere.