From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from aposti.net (aposti.net [89.234.176.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C06C470 for ; Fri, 21 May 2021 12:32:15 +0000 (UTC) Date: Fri, 21 May 2021 13:22:11 +0100 From: Paul Cercueil Subject: Re: [PATCH 06/11] drm/: drm_gem_plane_helper_prepare_fb is now the default To: Daniel Vetter Cc: DRI Development , Intel Graphics Development , Daniel Vetter , Laurentiu Palcu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Philipp Zabel , Chun-Kuang Hu , Matthias Brugger , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Marek Vasut , Stefan Agner , Sandy Huang , Heiko =?iso-8859-1?q?St=FCbner?= , Yannick Fertre , Philippe Cornu , Benjamin Gaignard , Maxime Coquelin , Alexandre Torgue , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Jyri Sarha , Tomi Valkeinen , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev Message-Id: In-Reply-To: <20210521090959.1663703-6-daniel.vetter@ffwll.ch> References: <20210521090959.1663703-1-daniel.vetter@ffwll.ch> <20210521090959.1663703-6-daniel.vetter@ffwll.ch> X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Hi Daniel, Le ven., mai 21 2021 at 11:09:54 +0200, Daniel Vetter=20 a =E9crit : > No need to set it explicitly. >=20 > Signed-off-by: Daniel Vetter > Cc: Laurentiu Palcu > Cc: Lucas Stach > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Pengutronix Kernel Team > Cc: Fabio Estevam > Cc: NXP Linux Team > Cc: Philipp Zabel > Cc: Paul Cercueil > Cc: Chun-Kuang Hu > Cc: Matthias Brugger > Cc: Neil Armstrong > Cc: Kevin Hilman > Cc: Jerome Brunet > Cc: Martin Blumenstingl > Cc: Marek Vasut > Cc: Stefan Agner > Cc: Sandy Huang > Cc: "Heiko St=FCbner" > Cc: Yannick Fertre > Cc: Philippe Cornu > Cc: Benjamin Gaignard > Cc: Maxime Coquelin > Cc: Alexandre Torgue > Cc: Maxime Ripard > Cc: Chen-Yu Tsai > Cc: Jernej Skrabec > Cc: Jyri Sarha > Cc: Tomi Valkeinen > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-mips@vger.kernel.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-amlogic@lists.infradead.org > Cc: linux-rockchip@lists.infradead.org > Cc: linux-stm32@st-md-mailman.stormreply.com > Cc: linux-sunxi@lists.linux.dev > --- > drivers/gpu/drm/imx/dcss/dcss-plane.c | 1 - > drivers/gpu/drm/imx/ipuv3-plane.c | 1 - > drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 1 - > drivers/gpu/drm/ingenic/ingenic-ipu.c | 1 - For drivers/gpu/drm/ingenic/*: Acked-by: Paul Cercueil Cheers, -Paul > drivers/gpu/drm/mediatek/mtk_drm_plane.c | 1 - > drivers/gpu/drm/meson/meson_overlay.c | 1 - > drivers/gpu/drm/meson/meson_plane.c | 1 - > drivers/gpu/drm/mxsfb/mxsfb_kms.c | 2 -- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 - > drivers/gpu/drm/stm/ltdc.c | 1 - > drivers/gpu/drm/sun4i/sun4i_layer.c | 1 - > drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 1 - > drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 1 - > drivers/gpu/drm/tidss/tidss_plane.c | 1 - > 14 files changed, 15 deletions(-) >=20 > diff --git a/drivers/gpu/drm/imx/dcss/dcss-plane.c=20 > b/drivers/gpu/drm/imx/dcss/dcss-plane.c > index 044d3bdf313c..ac45d54acd4e 100644 > --- a/drivers/gpu/drm/imx/dcss/dcss-plane.c > +++ b/drivers/gpu/drm/imx/dcss/dcss-plane.c > @@ -361,7 +361,6 @@ static void dcss_plane_atomic_disable(struct=20 > drm_plane *plane, > } >=20 > static const struct drm_plane_helper_funcs dcss_plane_helper_funcs =3D=20 > { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D dcss_plane_atomic_check, > .atomic_update =3D dcss_plane_atomic_update, > .atomic_disable =3D dcss_plane_atomic_disable, > diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c=20 > b/drivers/gpu/drm/imx/ipuv3-plane.c > index 8710f55d2579..ef114b6aa691 100644 > --- a/drivers/gpu/drm/imx/ipuv3-plane.c > +++ b/drivers/gpu/drm/imx/ipuv3-plane.c > @@ -772,7 +772,6 @@ static void ipu_plane_atomic_update(struct=20 > drm_plane *plane, > } >=20 > static const struct drm_plane_helper_funcs ipu_plane_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D ipu_plane_atomic_check, > .atomic_disable =3D ipu_plane_atomic_disable, > .atomic_update =3D ipu_plane_atomic_update, > diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c=20 > b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > index 389cad59e090..62db7349bf6a 100644 > --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > @@ -786,7 +786,6 @@ static const struct drm_plane_helper_funcs=20 > ingenic_drm_plane_helper_funcs =3D { > .atomic_update =3D ingenic_drm_plane_atomic_update, > .atomic_check =3D ingenic_drm_plane_atomic_check, > .atomic_disable =3D ingenic_drm_plane_atomic_disable, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; >=20 > static const struct drm_crtc_helper_funcs=20 > ingenic_drm_crtc_helper_funcs =3D { > diff --git a/drivers/gpu/drm/ingenic/ingenic-ipu.c=20 > b/drivers/gpu/drm/ingenic/ingenic-ipu.c > index 3b1091e7c0cd..caf038f3e231 100644 > --- a/drivers/gpu/drm/ingenic/ingenic-ipu.c > +++ b/drivers/gpu/drm/ingenic/ingenic-ipu.c > @@ -615,7 +615,6 @@ static const struct drm_plane_helper_funcs=20 > ingenic_ipu_plane_helper_funcs =3D { > .atomic_update =3D ingenic_ipu_plane_atomic_update, > .atomic_check =3D ingenic_ipu_plane_atomic_check, > .atomic_disable =3D ingenic_ipu_plane_atomic_disable, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; >=20 > static int > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c=20 > b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > index b5582dcf564c..1667a7e7de38 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > @@ -227,7 +227,6 @@ static void mtk_plane_atomic_update(struct=20 > drm_plane *plane, > } >=20 > static const struct drm_plane_helper_funcs mtk_plane_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D mtk_plane_atomic_check, > .atomic_update =3D mtk_plane_atomic_update, > .atomic_disable =3D mtk_plane_atomic_disable, > diff --git a/drivers/gpu/drm/meson/meson_overlay.c=20 > b/drivers/gpu/drm/meson/meson_overlay.c > index ed063152aecd..dfef8afcc245 100644 > --- a/drivers/gpu/drm/meson/meson_overlay.c > +++ b/drivers/gpu/drm/meson/meson_overlay.c > @@ -747,7 +747,6 @@ static const struct drm_plane_helper_funcs=20 > meson_overlay_helper_funcs =3D { > .atomic_check =3D meson_overlay_atomic_check, > .atomic_disable =3D meson_overlay_atomic_disable, > .atomic_update =3D meson_overlay_atomic_update, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; >=20 > static bool meson_overlay_format_mod_supported(struct drm_plane=20 > *plane, > diff --git a/drivers/gpu/drm/meson/meson_plane.c=20 > b/drivers/gpu/drm/meson/meson_plane.c > index a18510dae4c8..8640a8a8a469 100644 > --- a/drivers/gpu/drm/meson/meson_plane.c > +++ b/drivers/gpu/drm/meson/meson_plane.c > @@ -422,7 +422,6 @@ static const struct drm_plane_helper_funcs=20 > meson_plane_helper_funcs =3D { > .atomic_check =3D meson_plane_atomic_check, > .atomic_disable =3D meson_plane_atomic_disable, > .atomic_update =3D meson_plane_atomic_update, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; >=20 > static bool meson_plane_format_mod_supported(struct drm_plane *plane, > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c=20 > b/drivers/gpu/drm/mxsfb/mxsfb_kms.c > index 300e7bab0f43..8797c671d0d5 100644 > --- a/drivers/gpu/drm/mxsfb/mxsfb_kms.c > +++ b/drivers/gpu/drm/mxsfb/mxsfb_kms.c > @@ -500,13 +500,11 @@ static bool mxsfb_format_mod_supported(struct=20 > drm_plane *plane, > } >=20 > static const struct drm_plane_helper_funcs=20 > mxsfb_plane_primary_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D mxsfb_plane_atomic_check, > .atomic_update =3D mxsfb_plane_primary_atomic_update, > }; >=20 > static const struct drm_plane_helper_funcs=20 > mxsfb_plane_overlay_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D mxsfb_plane_atomic_check, > .atomic_update =3D mxsfb_plane_overlay_atomic_update, > }; > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c=20 > b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > index 64469439ddf2..6406bc0a71c7 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -1109,7 +1109,6 @@ static const struct drm_plane_helper_funcs=20 > plane_helper_funcs =3D { > .atomic_disable =3D vop_plane_atomic_disable, > .atomic_async_check =3D vop_plane_atomic_async_check, > .atomic_async_update =3D vop_plane_atomic_async_update, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; >=20 > static const struct drm_plane_funcs vop_plane_funcs =3D { > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c > index e99771b947b6..a5a2956f23f2 100644 > --- a/drivers/gpu/drm/stm/ltdc.c > +++ b/drivers/gpu/drm/stm/ltdc.c > @@ -946,7 +946,6 @@ static const struct drm_plane_funcs=20 > ltdc_plane_funcs =3D { > }; >=20 > static const struct drm_plane_helper_funcs ltdc_plane_helper_funcs =3D=20 > { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D ltdc_plane_atomic_check, > .atomic_update =3D ltdc_plane_atomic_update, > .atomic_disable =3D ltdc_plane_atomic_disable, > diff --git a/drivers/gpu/drm/sun4i/sun4i_layer.c=20 > b/drivers/gpu/drm/sun4i/sun4i_layer.c > index 11771bdd6e7c..929e95f86b5b 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_layer.c > +++ b/drivers/gpu/drm/sun4i/sun4i_layer.c > @@ -127,7 +127,6 @@ static bool=20 > sun4i_layer_format_mod_supported(struct drm_plane *plane, > } >=20 > static const struct drm_plane_helper_funcs=20 > sun4i_backend_layer_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_disable =3D sun4i_backend_layer_atomic_disable, > .atomic_update =3D sun4i_backend_layer_atomic_update, > }; > diff --git a/drivers/gpu/drm/sun4i/sun8i_ui_layer.c=20 > b/drivers/gpu/drm/sun4i/sun8i_ui_layer.c > index 0db164a774a1..ac3d43394589 100644 > --- a/drivers/gpu/drm/sun4i/sun8i_ui_layer.c > +++ b/drivers/gpu/drm/sun4i/sun8i_ui_layer.c > @@ -332,7 +332,6 @@ static void sun8i_ui_layer_atomic_update(struct=20 > drm_plane *plane, > } >=20 > static const struct drm_plane_helper_funcs=20 > sun8i_ui_layer_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D sun8i_ui_layer_atomic_check, > .atomic_disable =3D sun8i_ui_layer_atomic_disable, > .atomic_update =3D sun8i_ui_layer_atomic_update, > diff --git a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c=20 > b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c > index 46420780db59..45b1e37f9cda 100644 > --- a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c > +++ b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c > @@ -436,7 +436,6 @@ static void sun8i_vi_layer_atomic_update(struct=20 > drm_plane *plane, > } >=20 > static const struct drm_plane_helper_funcs=20 > sun8i_vi_layer_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D sun8i_vi_layer_atomic_check, > .atomic_disable =3D sun8i_vi_layer_atomic_disable, > .atomic_update =3D sun8i_vi_layer_atomic_update, > diff --git a/drivers/gpu/drm/tidss/tidss_plane.c=20 > b/drivers/gpu/drm/tidss/tidss_plane.c > index 1acd15aa4193..217415ec8eea 100644 > --- a/drivers/gpu/drm/tidss/tidss_plane.c > +++ b/drivers/gpu/drm/tidss/tidss_plane.c > @@ -158,7 +158,6 @@ static void drm_plane_destroy(struct drm_plane=20 > *plane) > } >=20 > static const struct drm_plane_helper_funcs tidss_plane_helper_funcs=20 > =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D tidss_plane_atomic_check, > .atomic_update =3D tidss_plane_atomic_update, > .atomic_disable =3D tidss_plane_atomic_disable, > -- > 2.31.0 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 578EEC433B4 for ; Fri, 21 May 2021 12:23:09 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CDB68613BF for ; Fri, 21 May 2021 12:23:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDB68613BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=crapouillou.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Cc:To :Subject:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tmJCf30sjk3O9yqCXOoO8Z99IRkp0V7bAwWwbBHI2OY=; b=ed3DrnGunkfTD6fd3vKsPusU9w pV/9o9LwiCmDjY95QnPTu2W2EACD319q+eMPXL8tIYw5oAOHzPCGRoEKmgJquelwS9BESSNwn0giI JEU1tA+HNpdQ+9G6LONhQJlimQTewyjcpUGPFBZe1bOkW4AecIxSPRq2QUyFfItfYxT7SimTrCHS8 GjYWihtlEOAfbD5KJ823kbTjyiAL6xgtFrn+AxHpitiXZd2pELZMUDUL+hawu3Ss/3DDNvNd+hSuJ g+Vflmrno/HpTYAhXUVyYosXtFMU/QEsB0XZJYujDBvipzA+V3P36cpN2JQG0IgrYc4AC/RVALSQ6 jniWA01A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk4BB-005IWZ-E0; Fri, 21 May 2021 12:23:01 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk4At-005IPR-DR; Fri, 21 May 2021 12:22:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Cc:To:Subject: From:Date:Sender:Reply-To:Content-ID:Content-Description; bh=Wc4ZpGr+2zSfLJvlFOAyiKDWa51Os7NyvXHLQP7pVj0=; b=Jl2e9WzXrTtTkuYpCX82UgABDR Oox8hoYCkF8BrMEsJJ28+uD5fseYog/xT3olMYIEGRzA/C2tRvunLTdOTU5eO3VUgEZn5Uk0dByri aXm0Qe+kPdFjzlnpjAx6wyT4Yj8T7QL2lpUf0UrRziYeh5zJx0mZIl5k8IvW2AuL0OOyBSkgzrt1p HblE01xexv5Ey9GuZSeQ5YtRtIcsjiiOYIpnxp0TqOZtwdpeiE16oVOpFodFCFZzbMn7ywdsR5Fad IQt2jN97qMiWD4InMiKdttiqyvEsc9fX1U7Jayz7KxBr541IOIVFB1DhMTvjvD6MjHcORu/QO1ZN4 DHX7wAQQ==; Received: from aposti.net ([89.234.176.197]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lk4Ap-00H5tf-VN; Fri, 21 May 2021 12:22:42 +0000 Date: Fri, 21 May 2021 13:22:11 +0100 From: Paul Cercueil Subject: Re: [PATCH 06/11] drm/: drm_gem_plane_helper_prepare_fb is now the default To: Daniel Vetter Cc: DRI Development , Intel Graphics Development , Daniel Vetter , Laurentiu Palcu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Philipp Zabel , Chun-Kuang Hu , Matthias Brugger , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Marek Vasut , Stefan Agner , Sandy Huang , Heiko =?iso-8859-1?q?St=FCbner?= , Yannick Fertre , Philippe Cornu , Benjamin Gaignard , Maxime Coquelin , Alexandre Torgue , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Jyri Sarha , Tomi Valkeinen , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev Message-Id: In-Reply-To: <20210521090959.1663703-6-daniel.vetter@ffwll.ch> References: <20210521090959.1663703-1-daniel.vetter@ffwll.ch> <20210521090959.1663703-6-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210521_052240_183473_2B768230 X-CRM114-Status: GOOD ( 14.19 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi Daniel, Le ven., mai 21 2021 at 11:09:54 +0200, Daniel Vetter = a =E9crit : > No need to set it explicitly. > = > Signed-off-by: Daniel Vetter > Cc: Laurentiu Palcu > Cc: Lucas Stach > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Pengutronix Kernel Team > Cc: Fabio Estevam > Cc: NXP Linux Team > Cc: Philipp Zabel > Cc: Paul Cercueil > Cc: Chun-Kuang Hu > Cc: Matthias Brugger > Cc: Neil Armstrong > Cc: Kevin Hilman > Cc: Jerome Brunet > Cc: Martin Blumenstingl > Cc: Marek Vasut > Cc: Stefan Agner > Cc: Sandy Huang > Cc: "Heiko St=FCbner" > Cc: Yannick Fertre > Cc: Philippe Cornu > Cc: Benjamin Gaignard > Cc: Maxime Coquelin > Cc: Alexandre Torgue > Cc: Maxime Ripard > Cc: Chen-Yu Tsai > Cc: Jernej Skrabec > Cc: Jyri Sarha > Cc: Tomi Valkeinen > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-mips@vger.kernel.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-amlogic@lists.infradead.org > Cc: linux-rockchip@lists.infradead.org > Cc: linux-stm32@st-md-mailman.stormreply.com > Cc: linux-sunxi@lists.linux.dev > --- > drivers/gpu/drm/imx/dcss/dcss-plane.c | 1 - > drivers/gpu/drm/imx/ipuv3-plane.c | 1 - > drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 1 - > drivers/gpu/drm/ingenic/ingenic-ipu.c | 1 - For drivers/gpu/drm/ingenic/*: Acked-by: Paul Cercueil Cheers, -Paul > drivers/gpu/drm/mediatek/mtk_drm_plane.c | 1 - > drivers/gpu/drm/meson/meson_overlay.c | 1 - > drivers/gpu/drm/meson/meson_plane.c | 1 - > drivers/gpu/drm/mxsfb/mxsfb_kms.c | 2 -- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 - > drivers/gpu/drm/stm/ltdc.c | 1 - > drivers/gpu/drm/sun4i/sun4i_layer.c | 1 - > drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 1 - > drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 1 - > drivers/gpu/drm/tidss/tidss_plane.c | 1 - > 14 files changed, 15 deletions(-) > = > diff --git a/drivers/gpu/drm/imx/dcss/dcss-plane.c = > b/drivers/gpu/drm/imx/dcss/dcss-plane.c > index 044d3bdf313c..ac45d54acd4e 100644 > --- a/drivers/gpu/drm/imx/dcss/dcss-plane.c > +++ b/drivers/gpu/drm/imx/dcss/dcss-plane.c > @@ -361,7 +361,6 @@ static void dcss_plane_atomic_disable(struct = > drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs dcss_plane_helper_funcs =3D = > { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D dcss_plane_atomic_check, > .atomic_update =3D dcss_plane_atomic_update, > .atomic_disable =3D dcss_plane_atomic_disable, > diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c = > b/drivers/gpu/drm/imx/ipuv3-plane.c > index 8710f55d2579..ef114b6aa691 100644 > --- a/drivers/gpu/drm/imx/ipuv3-plane.c > +++ b/drivers/gpu/drm/imx/ipuv3-plane.c > @@ -772,7 +772,6 @@ static void ipu_plane_atomic_update(struct = > drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs ipu_plane_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D ipu_plane_atomic_check, > .atomic_disable =3D ipu_plane_atomic_disable, > .atomic_update =3D ipu_plane_atomic_update, > diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c = > b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > index 389cad59e090..62db7349bf6a 100644 > --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > @@ -786,7 +786,6 @@ static const struct drm_plane_helper_funcs = > ingenic_drm_plane_helper_funcs =3D { > .atomic_update =3D ingenic_drm_plane_atomic_update, > .atomic_check =3D ingenic_drm_plane_atomic_check, > .atomic_disable =3D ingenic_drm_plane_atomic_disable, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; > = > static const struct drm_crtc_helper_funcs = > ingenic_drm_crtc_helper_funcs =3D { > diff --git a/drivers/gpu/drm/ingenic/ingenic-ipu.c = > b/drivers/gpu/drm/ingenic/ingenic-ipu.c > index 3b1091e7c0cd..caf038f3e231 100644 > --- a/drivers/gpu/drm/ingenic/ingenic-ipu.c > +++ b/drivers/gpu/drm/ingenic/ingenic-ipu.c > @@ -615,7 +615,6 @@ static const struct drm_plane_helper_funcs = > ingenic_ipu_plane_helper_funcs =3D { > .atomic_update =3D ingenic_ipu_plane_atomic_update, > .atomic_check =3D ingenic_ipu_plane_atomic_check, > .atomic_disable =3D ingenic_ipu_plane_atomic_disable, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; > = > static int > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c = > b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > index b5582dcf564c..1667a7e7de38 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > @@ -227,7 +227,6 @@ static void mtk_plane_atomic_update(struct = > drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs mtk_plane_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D mtk_plane_atomic_check, > .atomic_update =3D mtk_plane_atomic_update, > .atomic_disable =3D mtk_plane_atomic_disable, > diff --git a/drivers/gpu/drm/meson/meson_overlay.c = > b/drivers/gpu/drm/meson/meson_overlay.c > index ed063152aecd..dfef8afcc245 100644 > --- a/drivers/gpu/drm/meson/meson_overlay.c > +++ b/drivers/gpu/drm/meson/meson_overlay.c > @@ -747,7 +747,6 @@ static const struct drm_plane_helper_funcs = > meson_overlay_helper_funcs =3D { > .atomic_check =3D meson_overlay_atomic_check, > .atomic_disable =3D meson_overlay_atomic_disable, > .atomic_update =3D meson_overlay_atomic_update, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; > = > static bool meson_overlay_format_mod_supported(struct drm_plane = > *plane, > diff --git a/drivers/gpu/drm/meson/meson_plane.c = > b/drivers/gpu/drm/meson/meson_plane.c > index a18510dae4c8..8640a8a8a469 100644 > --- a/drivers/gpu/drm/meson/meson_plane.c > +++ b/drivers/gpu/drm/meson/meson_plane.c > @@ -422,7 +422,6 @@ static const struct drm_plane_helper_funcs = > meson_plane_helper_funcs =3D { > .atomic_check =3D meson_plane_atomic_check, > .atomic_disable =3D meson_plane_atomic_disable, > .atomic_update =3D meson_plane_atomic_update, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; > = > static bool meson_plane_format_mod_supported(struct drm_plane *plane, > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c = > b/drivers/gpu/drm/mxsfb/mxsfb_kms.c > index 300e7bab0f43..8797c671d0d5 100644 > --- a/drivers/gpu/drm/mxsfb/mxsfb_kms.c > +++ b/drivers/gpu/drm/mxsfb/mxsfb_kms.c > @@ -500,13 +500,11 @@ static bool mxsfb_format_mod_supported(struct = > drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs = > mxsfb_plane_primary_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D mxsfb_plane_atomic_check, > .atomic_update =3D mxsfb_plane_primary_atomic_update, > }; > = > static const struct drm_plane_helper_funcs = > mxsfb_plane_overlay_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D mxsfb_plane_atomic_check, > .atomic_update =3D mxsfb_plane_overlay_atomic_update, > }; > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c = > b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > index 64469439ddf2..6406bc0a71c7 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -1109,7 +1109,6 @@ static const struct drm_plane_helper_funcs = > plane_helper_funcs =3D { > .atomic_disable =3D vop_plane_atomic_disable, > .atomic_async_check =3D vop_plane_atomic_async_check, > .atomic_async_update =3D vop_plane_atomic_async_update, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; > = > static const struct drm_plane_funcs vop_plane_funcs =3D { > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c > index e99771b947b6..a5a2956f23f2 100644 > --- a/drivers/gpu/drm/stm/ltdc.c > +++ b/drivers/gpu/drm/stm/ltdc.c > @@ -946,7 +946,6 @@ static const struct drm_plane_funcs = > ltdc_plane_funcs =3D { > }; > = > static const struct drm_plane_helper_funcs ltdc_plane_helper_funcs =3D = > { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D ltdc_plane_atomic_check, > .atomic_update =3D ltdc_plane_atomic_update, > .atomic_disable =3D ltdc_plane_atomic_disable, > diff --git a/drivers/gpu/drm/sun4i/sun4i_layer.c = > b/drivers/gpu/drm/sun4i/sun4i_layer.c > index 11771bdd6e7c..929e95f86b5b 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_layer.c > +++ b/drivers/gpu/drm/sun4i/sun4i_layer.c > @@ -127,7 +127,6 @@ static bool = > sun4i_layer_format_mod_supported(struct drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs = > sun4i_backend_layer_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_disable =3D sun4i_backend_layer_atomic_disable, > .atomic_update =3D sun4i_backend_layer_atomic_update, > }; > diff --git a/drivers/gpu/drm/sun4i/sun8i_ui_layer.c = > b/drivers/gpu/drm/sun4i/sun8i_ui_layer.c > index 0db164a774a1..ac3d43394589 100644 > --- a/drivers/gpu/drm/sun4i/sun8i_ui_layer.c > +++ b/drivers/gpu/drm/sun4i/sun8i_ui_layer.c > @@ -332,7 +332,6 @@ static void sun8i_ui_layer_atomic_update(struct = > drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs = > sun8i_ui_layer_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D sun8i_ui_layer_atomic_check, > .atomic_disable =3D sun8i_ui_layer_atomic_disable, > .atomic_update =3D sun8i_ui_layer_atomic_update, > diff --git a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c = > b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c > index 46420780db59..45b1e37f9cda 100644 > --- a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c > +++ b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c > @@ -436,7 +436,6 @@ static void sun8i_vi_layer_atomic_update(struct = > drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs = > sun8i_vi_layer_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D sun8i_vi_layer_atomic_check, > .atomic_disable =3D sun8i_vi_layer_atomic_disable, > .atomic_update =3D sun8i_vi_layer_atomic_update, > diff --git a/drivers/gpu/drm/tidss/tidss_plane.c = > b/drivers/gpu/drm/tidss/tidss_plane.c > index 1acd15aa4193..217415ec8eea 100644 > --- a/drivers/gpu/drm/tidss/tidss_plane.c > +++ b/drivers/gpu/drm/tidss/tidss_plane.c > @@ -158,7 +158,6 @@ static void drm_plane_destroy(struct drm_plane = > *plane) > } > = > static const struct drm_plane_helper_funcs tidss_plane_helper_funcs = > =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D tidss_plane_atomic_check, > .atomic_update =3D tidss_plane_atomic_update, > .atomic_disable =3D tidss_plane_atomic_disable, > -- > 2.31.0 > = _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98A19C433ED for ; Fri, 21 May 2021 12:23:15 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D88E613BF for ; Fri, 21 May 2021 12:23:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D88E613BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=crapouillou.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Cc:To :Subject:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=A4DOF1SECmU7zrauAslVn+A4Iuwk1aH44SoTEh1Gt8s=; b=bacPC9W3MYhJtj5KxK2Yytxqab //LiZTOp1aQPWzhwxADHN5TT0jqD8Ipb/ZPjCK0+GV5b2YZOtmdAlCv4rBc+u8wjHFHZt5nvKXhAk dllmH/5hLg0Mu2XWwfAJ8K70AdD1+EZ5Zrjg+agGcuETGX+sC9TdQgyiboREZlmzIgv+jSouXuNqV azfukXBM9Fid52lkjL9uAQ9Wu72r18Mt+sApemZBjKvNByjGQLRTe2R7paSzMeA4JPkjQWIXfoJ1x WTmxv6X1N/jCWkxyW0uwNV8sOzLitXy4/6JIhTP/qz9AvBguHJ2mfhtAqC7so8GfufEhSDfX3NfNJ 0Kv5+19g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk4B9-005IVf-S9; Fri, 21 May 2021 12:23:00 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk4At-005IPR-DR; Fri, 21 May 2021 12:22:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Cc:To:Subject: From:Date:Sender:Reply-To:Content-ID:Content-Description; bh=Wc4ZpGr+2zSfLJvlFOAyiKDWa51Os7NyvXHLQP7pVj0=; b=Jl2e9WzXrTtTkuYpCX82UgABDR Oox8hoYCkF8BrMEsJJ28+uD5fseYog/xT3olMYIEGRzA/C2tRvunLTdOTU5eO3VUgEZn5Uk0dByri aXm0Qe+kPdFjzlnpjAx6wyT4Yj8T7QL2lpUf0UrRziYeh5zJx0mZIl5k8IvW2AuL0OOyBSkgzrt1p HblE01xexv5Ey9GuZSeQ5YtRtIcsjiiOYIpnxp0TqOZtwdpeiE16oVOpFodFCFZzbMn7ywdsR5Fad IQt2jN97qMiWD4InMiKdttiqyvEsc9fX1U7Jayz7KxBr541IOIVFB1DhMTvjvD6MjHcORu/QO1ZN4 DHX7wAQQ==; Received: from aposti.net ([89.234.176.197]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lk4Ap-00H5tf-VN; Fri, 21 May 2021 12:22:42 +0000 Date: Fri, 21 May 2021 13:22:11 +0100 From: Paul Cercueil Subject: Re: [PATCH 06/11] drm/: drm_gem_plane_helper_prepare_fb is now the default To: Daniel Vetter Cc: DRI Development , Intel Graphics Development , Daniel Vetter , Laurentiu Palcu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Philipp Zabel , Chun-Kuang Hu , Matthias Brugger , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Marek Vasut , Stefan Agner , Sandy Huang , Heiko =?iso-8859-1?q?St=FCbner?= , Yannick Fertre , Philippe Cornu , Benjamin Gaignard , Maxime Coquelin , Alexandre Torgue , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Jyri Sarha , Tomi Valkeinen , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev Message-Id: In-Reply-To: <20210521090959.1663703-6-daniel.vetter@ffwll.ch> References: <20210521090959.1663703-1-daniel.vetter@ffwll.ch> <20210521090959.1663703-6-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210521_052240_183473_2B768230 X-CRM114-Status: GOOD ( 14.19 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Daniel, Le ven., mai 21 2021 at 11:09:54 +0200, Daniel Vetter = a =E9crit : > No need to set it explicitly. > = > Signed-off-by: Daniel Vetter > Cc: Laurentiu Palcu > Cc: Lucas Stach > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Pengutronix Kernel Team > Cc: Fabio Estevam > Cc: NXP Linux Team > Cc: Philipp Zabel > Cc: Paul Cercueil > Cc: Chun-Kuang Hu > Cc: Matthias Brugger > Cc: Neil Armstrong > Cc: Kevin Hilman > Cc: Jerome Brunet > Cc: Martin Blumenstingl > Cc: Marek Vasut > Cc: Stefan Agner > Cc: Sandy Huang > Cc: "Heiko St=FCbner" > Cc: Yannick Fertre > Cc: Philippe Cornu > Cc: Benjamin Gaignard > Cc: Maxime Coquelin > Cc: Alexandre Torgue > Cc: Maxime Ripard > Cc: Chen-Yu Tsai > Cc: Jernej Skrabec > Cc: Jyri Sarha > Cc: Tomi Valkeinen > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-mips@vger.kernel.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-amlogic@lists.infradead.org > Cc: linux-rockchip@lists.infradead.org > Cc: linux-stm32@st-md-mailman.stormreply.com > Cc: linux-sunxi@lists.linux.dev > --- > drivers/gpu/drm/imx/dcss/dcss-plane.c | 1 - > drivers/gpu/drm/imx/ipuv3-plane.c | 1 - > drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 1 - > drivers/gpu/drm/ingenic/ingenic-ipu.c | 1 - For drivers/gpu/drm/ingenic/*: Acked-by: Paul Cercueil Cheers, -Paul > drivers/gpu/drm/mediatek/mtk_drm_plane.c | 1 - > drivers/gpu/drm/meson/meson_overlay.c | 1 - > drivers/gpu/drm/meson/meson_plane.c | 1 - > drivers/gpu/drm/mxsfb/mxsfb_kms.c | 2 -- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 - > drivers/gpu/drm/stm/ltdc.c | 1 - > drivers/gpu/drm/sun4i/sun4i_layer.c | 1 - > drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 1 - > drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 1 - > drivers/gpu/drm/tidss/tidss_plane.c | 1 - > 14 files changed, 15 deletions(-) > = > diff --git a/drivers/gpu/drm/imx/dcss/dcss-plane.c = > b/drivers/gpu/drm/imx/dcss/dcss-plane.c > index 044d3bdf313c..ac45d54acd4e 100644 > --- a/drivers/gpu/drm/imx/dcss/dcss-plane.c > +++ b/drivers/gpu/drm/imx/dcss/dcss-plane.c > @@ -361,7 +361,6 @@ static void dcss_plane_atomic_disable(struct = > drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs dcss_plane_helper_funcs =3D = > { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D dcss_plane_atomic_check, > .atomic_update =3D dcss_plane_atomic_update, > .atomic_disable =3D dcss_plane_atomic_disable, > diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c = > b/drivers/gpu/drm/imx/ipuv3-plane.c > index 8710f55d2579..ef114b6aa691 100644 > --- a/drivers/gpu/drm/imx/ipuv3-plane.c > +++ b/drivers/gpu/drm/imx/ipuv3-plane.c > @@ -772,7 +772,6 @@ static void ipu_plane_atomic_update(struct = > drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs ipu_plane_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D ipu_plane_atomic_check, > .atomic_disable =3D ipu_plane_atomic_disable, > .atomic_update =3D ipu_plane_atomic_update, > diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c = > b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > index 389cad59e090..62db7349bf6a 100644 > --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > @@ -786,7 +786,6 @@ static const struct drm_plane_helper_funcs = > ingenic_drm_plane_helper_funcs =3D { > .atomic_update =3D ingenic_drm_plane_atomic_update, > .atomic_check =3D ingenic_drm_plane_atomic_check, > .atomic_disable =3D ingenic_drm_plane_atomic_disable, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; > = > static const struct drm_crtc_helper_funcs = > ingenic_drm_crtc_helper_funcs =3D { > diff --git a/drivers/gpu/drm/ingenic/ingenic-ipu.c = > b/drivers/gpu/drm/ingenic/ingenic-ipu.c > index 3b1091e7c0cd..caf038f3e231 100644 > --- a/drivers/gpu/drm/ingenic/ingenic-ipu.c > +++ b/drivers/gpu/drm/ingenic/ingenic-ipu.c > @@ -615,7 +615,6 @@ static const struct drm_plane_helper_funcs = > ingenic_ipu_plane_helper_funcs =3D { > .atomic_update =3D ingenic_ipu_plane_atomic_update, > .atomic_check =3D ingenic_ipu_plane_atomic_check, > .atomic_disable =3D ingenic_ipu_plane_atomic_disable, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; > = > static int > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c = > b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > index b5582dcf564c..1667a7e7de38 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > @@ -227,7 +227,6 @@ static void mtk_plane_atomic_update(struct = > drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs mtk_plane_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D mtk_plane_atomic_check, > .atomic_update =3D mtk_plane_atomic_update, > .atomic_disable =3D mtk_plane_atomic_disable, > diff --git a/drivers/gpu/drm/meson/meson_overlay.c = > b/drivers/gpu/drm/meson/meson_overlay.c > index ed063152aecd..dfef8afcc245 100644 > --- a/drivers/gpu/drm/meson/meson_overlay.c > +++ b/drivers/gpu/drm/meson/meson_overlay.c > @@ -747,7 +747,6 @@ static const struct drm_plane_helper_funcs = > meson_overlay_helper_funcs =3D { > .atomic_check =3D meson_overlay_atomic_check, > .atomic_disable =3D meson_overlay_atomic_disable, > .atomic_update =3D meson_overlay_atomic_update, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; > = > static bool meson_overlay_format_mod_supported(struct drm_plane = > *plane, > diff --git a/drivers/gpu/drm/meson/meson_plane.c = > b/drivers/gpu/drm/meson/meson_plane.c > index a18510dae4c8..8640a8a8a469 100644 > --- a/drivers/gpu/drm/meson/meson_plane.c > +++ b/drivers/gpu/drm/meson/meson_plane.c > @@ -422,7 +422,6 @@ static const struct drm_plane_helper_funcs = > meson_plane_helper_funcs =3D { > .atomic_check =3D meson_plane_atomic_check, > .atomic_disable =3D meson_plane_atomic_disable, > .atomic_update =3D meson_plane_atomic_update, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; > = > static bool meson_plane_format_mod_supported(struct drm_plane *plane, > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c = > b/drivers/gpu/drm/mxsfb/mxsfb_kms.c > index 300e7bab0f43..8797c671d0d5 100644 > --- a/drivers/gpu/drm/mxsfb/mxsfb_kms.c > +++ b/drivers/gpu/drm/mxsfb/mxsfb_kms.c > @@ -500,13 +500,11 @@ static bool mxsfb_format_mod_supported(struct = > drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs = > mxsfb_plane_primary_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D mxsfb_plane_atomic_check, > .atomic_update =3D mxsfb_plane_primary_atomic_update, > }; > = > static const struct drm_plane_helper_funcs = > mxsfb_plane_overlay_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D mxsfb_plane_atomic_check, > .atomic_update =3D mxsfb_plane_overlay_atomic_update, > }; > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c = > b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > index 64469439ddf2..6406bc0a71c7 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -1109,7 +1109,6 @@ static const struct drm_plane_helper_funcs = > plane_helper_funcs =3D { > .atomic_disable =3D vop_plane_atomic_disable, > .atomic_async_check =3D vop_plane_atomic_async_check, > .atomic_async_update =3D vop_plane_atomic_async_update, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; > = > static const struct drm_plane_funcs vop_plane_funcs =3D { > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c > index e99771b947b6..a5a2956f23f2 100644 > --- a/drivers/gpu/drm/stm/ltdc.c > +++ b/drivers/gpu/drm/stm/ltdc.c > @@ -946,7 +946,6 @@ static const struct drm_plane_funcs = > ltdc_plane_funcs =3D { > }; > = > static const struct drm_plane_helper_funcs ltdc_plane_helper_funcs =3D = > { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D ltdc_plane_atomic_check, > .atomic_update =3D ltdc_plane_atomic_update, > .atomic_disable =3D ltdc_plane_atomic_disable, > diff --git a/drivers/gpu/drm/sun4i/sun4i_layer.c = > b/drivers/gpu/drm/sun4i/sun4i_layer.c > index 11771bdd6e7c..929e95f86b5b 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_layer.c > +++ b/drivers/gpu/drm/sun4i/sun4i_layer.c > @@ -127,7 +127,6 @@ static bool = > sun4i_layer_format_mod_supported(struct drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs = > sun4i_backend_layer_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_disable =3D sun4i_backend_layer_atomic_disable, > .atomic_update =3D sun4i_backend_layer_atomic_update, > }; > diff --git a/drivers/gpu/drm/sun4i/sun8i_ui_layer.c = > b/drivers/gpu/drm/sun4i/sun8i_ui_layer.c > index 0db164a774a1..ac3d43394589 100644 > --- a/drivers/gpu/drm/sun4i/sun8i_ui_layer.c > +++ b/drivers/gpu/drm/sun4i/sun8i_ui_layer.c > @@ -332,7 +332,6 @@ static void sun8i_ui_layer_atomic_update(struct = > drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs = > sun8i_ui_layer_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D sun8i_ui_layer_atomic_check, > .atomic_disable =3D sun8i_ui_layer_atomic_disable, > .atomic_update =3D sun8i_ui_layer_atomic_update, > diff --git a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c = > b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c > index 46420780db59..45b1e37f9cda 100644 > --- a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c > +++ b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c > @@ -436,7 +436,6 @@ static void sun8i_vi_layer_atomic_update(struct = > drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs = > sun8i_vi_layer_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D sun8i_vi_layer_atomic_check, > .atomic_disable =3D sun8i_vi_layer_atomic_disable, > .atomic_update =3D sun8i_vi_layer_atomic_update, > diff --git a/drivers/gpu/drm/tidss/tidss_plane.c = > b/drivers/gpu/drm/tidss/tidss_plane.c > index 1acd15aa4193..217415ec8eea 100644 > --- a/drivers/gpu/drm/tidss/tidss_plane.c > +++ b/drivers/gpu/drm/tidss/tidss_plane.c > @@ -158,7 +158,6 @@ static void drm_plane_destroy(struct drm_plane = > *plane) > } > = > static const struct drm_plane_helper_funcs tidss_plane_helper_funcs = > =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D tidss_plane_atomic_check, > .atomic_update =3D tidss_plane_atomic_update, > .atomic_disable =3D tidss_plane_atomic_disable, > -- > 2.31.0 > = _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E337C433B4 for ; Fri, 21 May 2021 12:25:04 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C658A6108B for ; Fri, 21 May 2021 12:25:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C658A6108B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=crapouillou.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Cc:To :Subject:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=I1poFjQvWbsrkgF1pzIXogMuCbqbxBI+i5np6ZQjmfY=; b=C0Xrf86gCA8mYGegwVeIcol+1H cLFbSlG3zY4SiXLRHFcWU8OH/MUquvivp/wTS42XHg3vIYpf8DnyU3vs922sn/I64kgpVarhvay+M K9lMKbJOtB612n/meYFnoKGGltqia3ej+ZDUhkIc5pjXFrce5xfxbqX01rOhNIvA7RckqckCAxkzZ nxrGrdTofLA9KUwKnf00LuG2a/PPO0LyMRc/jBAwxanqAU31oMjUHOze+fx2+7IjGUT949XqiXu2K SpiZxiOD4DDv/PClmEwT7oOS9k6tK19HrQ4sC5zxqGK1SNlL7pJ07lZbuTSkGr5D1zieVxlu/V38K faUNhjEQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk4Az-005IRj-PE; Fri, 21 May 2021 12:22:49 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk4At-005IPR-DR; Fri, 21 May 2021 12:22:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Cc:To:Subject: From:Date:Sender:Reply-To:Content-ID:Content-Description; bh=Wc4ZpGr+2zSfLJvlFOAyiKDWa51Os7NyvXHLQP7pVj0=; b=Jl2e9WzXrTtTkuYpCX82UgABDR Oox8hoYCkF8BrMEsJJ28+uD5fseYog/xT3olMYIEGRzA/C2tRvunLTdOTU5eO3VUgEZn5Uk0dByri aXm0Qe+kPdFjzlnpjAx6wyT4Yj8T7QL2lpUf0UrRziYeh5zJx0mZIl5k8IvW2AuL0OOyBSkgzrt1p HblE01xexv5Ey9GuZSeQ5YtRtIcsjiiOYIpnxp0TqOZtwdpeiE16oVOpFodFCFZzbMn7ywdsR5Fad IQt2jN97qMiWD4InMiKdttiqyvEsc9fX1U7Jayz7KxBr541IOIVFB1DhMTvjvD6MjHcORu/QO1ZN4 DHX7wAQQ==; Received: from aposti.net ([89.234.176.197]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lk4Ap-00H5tf-VN; Fri, 21 May 2021 12:22:42 +0000 Date: Fri, 21 May 2021 13:22:11 +0100 From: Paul Cercueil Subject: Re: [PATCH 06/11] drm/: drm_gem_plane_helper_prepare_fb is now the default To: Daniel Vetter Cc: DRI Development , Intel Graphics Development , Daniel Vetter , Laurentiu Palcu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Philipp Zabel , Chun-Kuang Hu , Matthias Brugger , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Marek Vasut , Stefan Agner , Sandy Huang , Heiko =?iso-8859-1?q?St=FCbner?= , Yannick Fertre , Philippe Cornu , Benjamin Gaignard , Maxime Coquelin , Alexandre Torgue , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Jyri Sarha , Tomi Valkeinen , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev Message-Id: In-Reply-To: <20210521090959.1663703-6-daniel.vetter@ffwll.ch> References: <20210521090959.1663703-1-daniel.vetter@ffwll.ch> <20210521090959.1663703-6-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210521_052240_183473_2B768230 X-CRM114-Status: GOOD ( 14.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Daniel, Le ven., mai 21 2021 at 11:09:54 +0200, Daniel Vetter = a =E9crit : > No need to set it explicitly. > = > Signed-off-by: Daniel Vetter > Cc: Laurentiu Palcu > Cc: Lucas Stach > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Pengutronix Kernel Team > Cc: Fabio Estevam > Cc: NXP Linux Team > Cc: Philipp Zabel > Cc: Paul Cercueil > Cc: Chun-Kuang Hu > Cc: Matthias Brugger > Cc: Neil Armstrong > Cc: Kevin Hilman > Cc: Jerome Brunet > Cc: Martin Blumenstingl > Cc: Marek Vasut > Cc: Stefan Agner > Cc: Sandy Huang > Cc: "Heiko St=FCbner" > Cc: Yannick Fertre > Cc: Philippe Cornu > Cc: Benjamin Gaignard > Cc: Maxime Coquelin > Cc: Alexandre Torgue > Cc: Maxime Ripard > Cc: Chen-Yu Tsai > Cc: Jernej Skrabec > Cc: Jyri Sarha > Cc: Tomi Valkeinen > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-mips@vger.kernel.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-amlogic@lists.infradead.org > Cc: linux-rockchip@lists.infradead.org > Cc: linux-stm32@st-md-mailman.stormreply.com > Cc: linux-sunxi@lists.linux.dev > --- > drivers/gpu/drm/imx/dcss/dcss-plane.c | 1 - > drivers/gpu/drm/imx/ipuv3-plane.c | 1 - > drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 1 - > drivers/gpu/drm/ingenic/ingenic-ipu.c | 1 - For drivers/gpu/drm/ingenic/*: Acked-by: Paul Cercueil Cheers, -Paul > drivers/gpu/drm/mediatek/mtk_drm_plane.c | 1 - > drivers/gpu/drm/meson/meson_overlay.c | 1 - > drivers/gpu/drm/meson/meson_plane.c | 1 - > drivers/gpu/drm/mxsfb/mxsfb_kms.c | 2 -- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 - > drivers/gpu/drm/stm/ltdc.c | 1 - > drivers/gpu/drm/sun4i/sun4i_layer.c | 1 - > drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 1 - > drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 1 - > drivers/gpu/drm/tidss/tidss_plane.c | 1 - > 14 files changed, 15 deletions(-) > = > diff --git a/drivers/gpu/drm/imx/dcss/dcss-plane.c = > b/drivers/gpu/drm/imx/dcss/dcss-plane.c > index 044d3bdf313c..ac45d54acd4e 100644 > --- a/drivers/gpu/drm/imx/dcss/dcss-plane.c > +++ b/drivers/gpu/drm/imx/dcss/dcss-plane.c > @@ -361,7 +361,6 @@ static void dcss_plane_atomic_disable(struct = > drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs dcss_plane_helper_funcs =3D = > { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D dcss_plane_atomic_check, > .atomic_update =3D dcss_plane_atomic_update, > .atomic_disable =3D dcss_plane_atomic_disable, > diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c = > b/drivers/gpu/drm/imx/ipuv3-plane.c > index 8710f55d2579..ef114b6aa691 100644 > --- a/drivers/gpu/drm/imx/ipuv3-plane.c > +++ b/drivers/gpu/drm/imx/ipuv3-plane.c > @@ -772,7 +772,6 @@ static void ipu_plane_atomic_update(struct = > drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs ipu_plane_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D ipu_plane_atomic_check, > .atomic_disable =3D ipu_plane_atomic_disable, > .atomic_update =3D ipu_plane_atomic_update, > diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c = > b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > index 389cad59e090..62db7349bf6a 100644 > --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > @@ -786,7 +786,6 @@ static const struct drm_plane_helper_funcs = > ingenic_drm_plane_helper_funcs =3D { > .atomic_update =3D ingenic_drm_plane_atomic_update, > .atomic_check =3D ingenic_drm_plane_atomic_check, > .atomic_disable =3D ingenic_drm_plane_atomic_disable, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; > = > static const struct drm_crtc_helper_funcs = > ingenic_drm_crtc_helper_funcs =3D { > diff --git a/drivers/gpu/drm/ingenic/ingenic-ipu.c = > b/drivers/gpu/drm/ingenic/ingenic-ipu.c > index 3b1091e7c0cd..caf038f3e231 100644 > --- a/drivers/gpu/drm/ingenic/ingenic-ipu.c > +++ b/drivers/gpu/drm/ingenic/ingenic-ipu.c > @@ -615,7 +615,6 @@ static const struct drm_plane_helper_funcs = > ingenic_ipu_plane_helper_funcs =3D { > .atomic_update =3D ingenic_ipu_plane_atomic_update, > .atomic_check =3D ingenic_ipu_plane_atomic_check, > .atomic_disable =3D ingenic_ipu_plane_atomic_disable, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; > = > static int > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c = > b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > index b5582dcf564c..1667a7e7de38 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > @@ -227,7 +227,6 @@ static void mtk_plane_atomic_update(struct = > drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs mtk_plane_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D mtk_plane_atomic_check, > .atomic_update =3D mtk_plane_atomic_update, > .atomic_disable =3D mtk_plane_atomic_disable, > diff --git a/drivers/gpu/drm/meson/meson_overlay.c = > b/drivers/gpu/drm/meson/meson_overlay.c > index ed063152aecd..dfef8afcc245 100644 > --- a/drivers/gpu/drm/meson/meson_overlay.c > +++ b/drivers/gpu/drm/meson/meson_overlay.c > @@ -747,7 +747,6 @@ static const struct drm_plane_helper_funcs = > meson_overlay_helper_funcs =3D { > .atomic_check =3D meson_overlay_atomic_check, > .atomic_disable =3D meson_overlay_atomic_disable, > .atomic_update =3D meson_overlay_atomic_update, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; > = > static bool meson_overlay_format_mod_supported(struct drm_plane = > *plane, > diff --git a/drivers/gpu/drm/meson/meson_plane.c = > b/drivers/gpu/drm/meson/meson_plane.c > index a18510dae4c8..8640a8a8a469 100644 > --- a/drivers/gpu/drm/meson/meson_plane.c > +++ b/drivers/gpu/drm/meson/meson_plane.c > @@ -422,7 +422,6 @@ static const struct drm_plane_helper_funcs = > meson_plane_helper_funcs =3D { > .atomic_check =3D meson_plane_atomic_check, > .atomic_disable =3D meson_plane_atomic_disable, > .atomic_update =3D meson_plane_atomic_update, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; > = > static bool meson_plane_format_mod_supported(struct drm_plane *plane, > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c = > b/drivers/gpu/drm/mxsfb/mxsfb_kms.c > index 300e7bab0f43..8797c671d0d5 100644 > --- a/drivers/gpu/drm/mxsfb/mxsfb_kms.c > +++ b/drivers/gpu/drm/mxsfb/mxsfb_kms.c > @@ -500,13 +500,11 @@ static bool mxsfb_format_mod_supported(struct = > drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs = > mxsfb_plane_primary_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D mxsfb_plane_atomic_check, > .atomic_update =3D mxsfb_plane_primary_atomic_update, > }; > = > static const struct drm_plane_helper_funcs = > mxsfb_plane_overlay_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D mxsfb_plane_atomic_check, > .atomic_update =3D mxsfb_plane_overlay_atomic_update, > }; > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c = > b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > index 64469439ddf2..6406bc0a71c7 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -1109,7 +1109,6 @@ static const struct drm_plane_helper_funcs = > plane_helper_funcs =3D { > .atomic_disable =3D vop_plane_atomic_disable, > .atomic_async_check =3D vop_plane_atomic_async_check, > .atomic_async_update =3D vop_plane_atomic_async_update, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; > = > static const struct drm_plane_funcs vop_plane_funcs =3D { > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c > index e99771b947b6..a5a2956f23f2 100644 > --- a/drivers/gpu/drm/stm/ltdc.c > +++ b/drivers/gpu/drm/stm/ltdc.c > @@ -946,7 +946,6 @@ static const struct drm_plane_funcs = > ltdc_plane_funcs =3D { > }; > = > static const struct drm_plane_helper_funcs ltdc_plane_helper_funcs =3D = > { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D ltdc_plane_atomic_check, > .atomic_update =3D ltdc_plane_atomic_update, > .atomic_disable =3D ltdc_plane_atomic_disable, > diff --git a/drivers/gpu/drm/sun4i/sun4i_layer.c = > b/drivers/gpu/drm/sun4i/sun4i_layer.c > index 11771bdd6e7c..929e95f86b5b 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_layer.c > +++ b/drivers/gpu/drm/sun4i/sun4i_layer.c > @@ -127,7 +127,6 @@ static bool = > sun4i_layer_format_mod_supported(struct drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs = > sun4i_backend_layer_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_disable =3D sun4i_backend_layer_atomic_disable, > .atomic_update =3D sun4i_backend_layer_atomic_update, > }; > diff --git a/drivers/gpu/drm/sun4i/sun8i_ui_layer.c = > b/drivers/gpu/drm/sun4i/sun8i_ui_layer.c > index 0db164a774a1..ac3d43394589 100644 > --- a/drivers/gpu/drm/sun4i/sun8i_ui_layer.c > +++ b/drivers/gpu/drm/sun4i/sun8i_ui_layer.c > @@ -332,7 +332,6 @@ static void sun8i_ui_layer_atomic_update(struct = > drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs = > sun8i_ui_layer_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D sun8i_ui_layer_atomic_check, > .atomic_disable =3D sun8i_ui_layer_atomic_disable, > .atomic_update =3D sun8i_ui_layer_atomic_update, > diff --git a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c = > b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c > index 46420780db59..45b1e37f9cda 100644 > --- a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c > +++ b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c > @@ -436,7 +436,6 @@ static void sun8i_vi_layer_atomic_update(struct = > drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs = > sun8i_vi_layer_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D sun8i_vi_layer_atomic_check, > .atomic_disable =3D sun8i_vi_layer_atomic_disable, > .atomic_update =3D sun8i_vi_layer_atomic_update, > diff --git a/drivers/gpu/drm/tidss/tidss_plane.c = > b/drivers/gpu/drm/tidss/tidss_plane.c > index 1acd15aa4193..217415ec8eea 100644 > --- a/drivers/gpu/drm/tidss/tidss_plane.c > +++ b/drivers/gpu/drm/tidss/tidss_plane.c > @@ -158,7 +158,6 @@ static void drm_plane_destroy(struct drm_plane = > *plane) > } > = > static const struct drm_plane_helper_funcs tidss_plane_helper_funcs = > =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D tidss_plane_atomic_check, > .atomic_update =3D tidss_plane_atomic_update, > .atomic_disable =3D tidss_plane_atomic_disable, > -- > 2.31.0 > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2227C433B4 for ; Fri, 21 May 2021 12:22:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83CA66108B for ; Fri, 21 May 2021 12:22:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83CA66108B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=crapouillou.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EA22F6E12E; Fri, 21 May 2021 12:22:34 +0000 (UTC) Received: from aposti.net (aposti.net [89.234.176.197]) by gabe.freedesktop.org (Postfix) with ESMTPS id 186846E12E for ; Fri, 21 May 2021 12:22:33 +0000 (UTC) Date: Fri, 21 May 2021 13:22:11 +0100 From: Paul Cercueil Subject: Re: [PATCH 06/11] drm/: drm_gem_plane_helper_prepare_fb is now the default To: Daniel Vetter Message-Id: In-Reply-To: <20210521090959.1663703-6-daniel.vetter@ffwll.ch> References: <20210521090959.1663703-1-daniel.vetter@ffwll.ch> <20210521090959.1663703-6-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Alexandre Torgue , linux-mips@vger.kernel.org, Benjamin Gaignard , Daniel Vetter , linux-stm32@st-md-mailman.stormreply.com, Jerome Brunet , Marek Vasut , Kevin Hilman , Jernej Skrabec , linux-rockchip@lists.infradead.org, Chen-Yu Tsai , NXP Linux Team , Sascha Hauer , Chun-Kuang Hu , Pengutronix Kernel Team , Martin Blumenstingl , Intel Graphics Development , linux-mediatek@lists.infradead.org, DRI Development , Laurentiu Palcu , Matthias Brugger , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Maxime Coquelin , Tomi Valkeinen , Jyri Sarha , Yannick Fertre , Sandy Huang , linux-sunxi@lists.linux.dev, Philippe Cornu , Shawn Guo Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Daniel, Le ven., mai 21 2021 at 11:09:54 +0200, Daniel Vetter=20 a =E9crit : > No need to set it explicitly. >=20 > Signed-off-by: Daniel Vetter > Cc: Laurentiu Palcu > Cc: Lucas Stach > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Pengutronix Kernel Team > Cc: Fabio Estevam > Cc: NXP Linux Team > Cc: Philipp Zabel > Cc: Paul Cercueil > Cc: Chun-Kuang Hu > Cc: Matthias Brugger > Cc: Neil Armstrong > Cc: Kevin Hilman > Cc: Jerome Brunet > Cc: Martin Blumenstingl > Cc: Marek Vasut > Cc: Stefan Agner > Cc: Sandy Huang > Cc: "Heiko St=FCbner" > Cc: Yannick Fertre > Cc: Philippe Cornu > Cc: Benjamin Gaignard > Cc: Maxime Coquelin > Cc: Alexandre Torgue > Cc: Maxime Ripard > Cc: Chen-Yu Tsai > Cc: Jernej Skrabec > Cc: Jyri Sarha > Cc: Tomi Valkeinen > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-mips@vger.kernel.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-amlogic@lists.infradead.org > Cc: linux-rockchip@lists.infradead.org > Cc: linux-stm32@st-md-mailman.stormreply.com > Cc: linux-sunxi@lists.linux.dev > --- > drivers/gpu/drm/imx/dcss/dcss-plane.c | 1 - > drivers/gpu/drm/imx/ipuv3-plane.c | 1 - > drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 1 - > drivers/gpu/drm/ingenic/ingenic-ipu.c | 1 - For drivers/gpu/drm/ingenic/*: Acked-by: Paul Cercueil Cheers, -Paul > drivers/gpu/drm/mediatek/mtk_drm_plane.c | 1 - > drivers/gpu/drm/meson/meson_overlay.c | 1 - > drivers/gpu/drm/meson/meson_plane.c | 1 - > drivers/gpu/drm/mxsfb/mxsfb_kms.c | 2 -- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 - > drivers/gpu/drm/stm/ltdc.c | 1 - > drivers/gpu/drm/sun4i/sun4i_layer.c | 1 - > drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 1 - > drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 1 - > drivers/gpu/drm/tidss/tidss_plane.c | 1 - > 14 files changed, 15 deletions(-) >=20 > diff --git a/drivers/gpu/drm/imx/dcss/dcss-plane.c=20 > b/drivers/gpu/drm/imx/dcss/dcss-plane.c > index 044d3bdf313c..ac45d54acd4e 100644 > --- a/drivers/gpu/drm/imx/dcss/dcss-plane.c > +++ b/drivers/gpu/drm/imx/dcss/dcss-plane.c > @@ -361,7 +361,6 @@ static void dcss_plane_atomic_disable(struct=20 > drm_plane *plane, > } >=20 > static const struct drm_plane_helper_funcs dcss_plane_helper_funcs =3D=20 > { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D dcss_plane_atomic_check, > .atomic_update =3D dcss_plane_atomic_update, > .atomic_disable =3D dcss_plane_atomic_disable, > diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c=20 > b/drivers/gpu/drm/imx/ipuv3-plane.c > index 8710f55d2579..ef114b6aa691 100644 > --- a/drivers/gpu/drm/imx/ipuv3-plane.c > +++ b/drivers/gpu/drm/imx/ipuv3-plane.c > @@ -772,7 +772,6 @@ static void ipu_plane_atomic_update(struct=20 > drm_plane *plane, > } >=20 > static const struct drm_plane_helper_funcs ipu_plane_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D ipu_plane_atomic_check, > .atomic_disable =3D ipu_plane_atomic_disable, > .atomic_update =3D ipu_plane_atomic_update, > diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c=20 > b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > index 389cad59e090..62db7349bf6a 100644 > --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > @@ -786,7 +786,6 @@ static const struct drm_plane_helper_funcs=20 > ingenic_drm_plane_helper_funcs =3D { > .atomic_update =3D ingenic_drm_plane_atomic_update, > .atomic_check =3D ingenic_drm_plane_atomic_check, > .atomic_disable =3D ingenic_drm_plane_atomic_disable, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; >=20 > static const struct drm_crtc_helper_funcs=20 > ingenic_drm_crtc_helper_funcs =3D { > diff --git a/drivers/gpu/drm/ingenic/ingenic-ipu.c=20 > b/drivers/gpu/drm/ingenic/ingenic-ipu.c > index 3b1091e7c0cd..caf038f3e231 100644 > --- a/drivers/gpu/drm/ingenic/ingenic-ipu.c > +++ b/drivers/gpu/drm/ingenic/ingenic-ipu.c > @@ -615,7 +615,6 @@ static const struct drm_plane_helper_funcs=20 > ingenic_ipu_plane_helper_funcs =3D { > .atomic_update =3D ingenic_ipu_plane_atomic_update, > .atomic_check =3D ingenic_ipu_plane_atomic_check, > .atomic_disable =3D ingenic_ipu_plane_atomic_disable, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; >=20 > static int > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c=20 > b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > index b5582dcf564c..1667a7e7de38 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > @@ -227,7 +227,6 @@ static void mtk_plane_atomic_update(struct=20 > drm_plane *plane, > } >=20 > static const struct drm_plane_helper_funcs mtk_plane_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D mtk_plane_atomic_check, > .atomic_update =3D mtk_plane_atomic_update, > .atomic_disable =3D mtk_plane_atomic_disable, > diff --git a/drivers/gpu/drm/meson/meson_overlay.c=20 > b/drivers/gpu/drm/meson/meson_overlay.c > index ed063152aecd..dfef8afcc245 100644 > --- a/drivers/gpu/drm/meson/meson_overlay.c > +++ b/drivers/gpu/drm/meson/meson_overlay.c > @@ -747,7 +747,6 @@ static const struct drm_plane_helper_funcs=20 > meson_overlay_helper_funcs =3D { > .atomic_check =3D meson_overlay_atomic_check, > .atomic_disable =3D meson_overlay_atomic_disable, > .atomic_update =3D meson_overlay_atomic_update, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; >=20 > static bool meson_overlay_format_mod_supported(struct drm_plane=20 > *plane, > diff --git a/drivers/gpu/drm/meson/meson_plane.c=20 > b/drivers/gpu/drm/meson/meson_plane.c > index a18510dae4c8..8640a8a8a469 100644 > --- a/drivers/gpu/drm/meson/meson_plane.c > +++ b/drivers/gpu/drm/meson/meson_plane.c > @@ -422,7 +422,6 @@ static const struct drm_plane_helper_funcs=20 > meson_plane_helper_funcs =3D { > .atomic_check =3D meson_plane_atomic_check, > .atomic_disable =3D meson_plane_atomic_disable, > .atomic_update =3D meson_plane_atomic_update, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; >=20 > static bool meson_plane_format_mod_supported(struct drm_plane *plane, > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c=20 > b/drivers/gpu/drm/mxsfb/mxsfb_kms.c > index 300e7bab0f43..8797c671d0d5 100644 > --- a/drivers/gpu/drm/mxsfb/mxsfb_kms.c > +++ b/drivers/gpu/drm/mxsfb/mxsfb_kms.c > @@ -500,13 +500,11 @@ static bool mxsfb_format_mod_supported(struct=20 > drm_plane *plane, > } >=20 > static const struct drm_plane_helper_funcs=20 > mxsfb_plane_primary_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D mxsfb_plane_atomic_check, > .atomic_update =3D mxsfb_plane_primary_atomic_update, > }; >=20 > static const struct drm_plane_helper_funcs=20 > mxsfb_plane_overlay_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D mxsfb_plane_atomic_check, > .atomic_update =3D mxsfb_plane_overlay_atomic_update, > }; > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c=20 > b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > index 64469439ddf2..6406bc0a71c7 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -1109,7 +1109,6 @@ static const struct drm_plane_helper_funcs=20 > plane_helper_funcs =3D { > .atomic_disable =3D vop_plane_atomic_disable, > .atomic_async_check =3D vop_plane_atomic_async_check, > .atomic_async_update =3D vop_plane_atomic_async_update, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; >=20 > static const struct drm_plane_funcs vop_plane_funcs =3D { > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c > index e99771b947b6..a5a2956f23f2 100644 > --- a/drivers/gpu/drm/stm/ltdc.c > +++ b/drivers/gpu/drm/stm/ltdc.c > @@ -946,7 +946,6 @@ static const struct drm_plane_funcs=20 > ltdc_plane_funcs =3D { > }; >=20 > static const struct drm_plane_helper_funcs ltdc_plane_helper_funcs =3D=20 > { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D ltdc_plane_atomic_check, > .atomic_update =3D ltdc_plane_atomic_update, > .atomic_disable =3D ltdc_plane_atomic_disable, > diff --git a/drivers/gpu/drm/sun4i/sun4i_layer.c=20 > b/drivers/gpu/drm/sun4i/sun4i_layer.c > index 11771bdd6e7c..929e95f86b5b 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_layer.c > +++ b/drivers/gpu/drm/sun4i/sun4i_layer.c > @@ -127,7 +127,6 @@ static bool=20 > sun4i_layer_format_mod_supported(struct drm_plane *plane, > } >=20 > static const struct drm_plane_helper_funcs=20 > sun4i_backend_layer_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_disable =3D sun4i_backend_layer_atomic_disable, > .atomic_update =3D sun4i_backend_layer_atomic_update, > }; > diff --git a/drivers/gpu/drm/sun4i/sun8i_ui_layer.c=20 > b/drivers/gpu/drm/sun4i/sun8i_ui_layer.c > index 0db164a774a1..ac3d43394589 100644 > --- a/drivers/gpu/drm/sun4i/sun8i_ui_layer.c > +++ b/drivers/gpu/drm/sun4i/sun8i_ui_layer.c > @@ -332,7 +332,6 @@ static void sun8i_ui_layer_atomic_update(struct=20 > drm_plane *plane, > } >=20 > static const struct drm_plane_helper_funcs=20 > sun8i_ui_layer_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D sun8i_ui_layer_atomic_check, > .atomic_disable =3D sun8i_ui_layer_atomic_disable, > .atomic_update =3D sun8i_ui_layer_atomic_update, > diff --git a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c=20 > b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c > index 46420780db59..45b1e37f9cda 100644 > --- a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c > +++ b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c > @@ -436,7 +436,6 @@ static void sun8i_vi_layer_atomic_update(struct=20 > drm_plane *plane, > } >=20 > static const struct drm_plane_helper_funcs=20 > sun8i_vi_layer_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D sun8i_vi_layer_atomic_check, > .atomic_disable =3D sun8i_vi_layer_atomic_disable, > .atomic_update =3D sun8i_vi_layer_atomic_update, > diff --git a/drivers/gpu/drm/tidss/tidss_plane.c=20 > b/drivers/gpu/drm/tidss/tidss_plane.c > index 1acd15aa4193..217415ec8eea 100644 > --- a/drivers/gpu/drm/tidss/tidss_plane.c > +++ b/drivers/gpu/drm/tidss/tidss_plane.c > @@ -158,7 +158,6 @@ static void drm_plane_destroy(struct drm_plane=20 > *plane) > } >=20 > static const struct drm_plane_helper_funcs tidss_plane_helper_funcs=20 > =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D tidss_plane_atomic_check, > .atomic_update =3D tidss_plane_atomic_update, > .atomic_disable =3D tidss_plane_atomic_disable, > -- > 2.31.0 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96744C433B4 for ; Fri, 21 May 2021 12:33:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E2CC61175 for ; Fri, 21 May 2021 12:33:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E2CC61175 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=crapouillou.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6B7FA6E4BB; Fri, 21 May 2021 12:33:01 +0000 (UTC) X-Greylist: delayed 580 seconds by postgrey-1.36 at gabe; Fri, 21 May 2021 12:32:15 UTC Received: from aposti.net (aposti.net [89.234.176.197]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5DB226E4B5 for ; Fri, 21 May 2021 12:32:14 +0000 (UTC) Date: Fri, 21 May 2021 13:22:11 +0100 From: Paul Cercueil To: Daniel Vetter Message-Id: In-Reply-To: <20210521090959.1663703-6-daniel.vetter@ffwll.ch> References: <20210521090959.1663703-1-daniel.vetter@ffwll.ch> <20210521090959.1663703-6-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-Mailman-Approved-At: Fri, 21 May 2021 12:33:00 +0000 Subject: Re: [Intel-gfx] [PATCH 06/11] drm/: drm_gem_plane_helper_prepare_fb is now the default X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko =?iso-8859-1?q?St=FCbner?= , Neil Armstrong , Alexandre Torgue , Stefan Agner , linux-mips@vger.kernel.org, Benjamin Gaignard , Daniel Vetter , Fabio Estevam , linux-stm32@st-md-mailman.stormreply.com, Jerome Brunet , Marek Vasut , Kevin Hilman , Jernej Skrabec , linux-rockchip@lists.infradead.org, Chen-Yu Tsai , NXP Linux Team , Sascha Hauer , Chun-Kuang Hu , Pengutronix Kernel Team , Martin Blumenstingl , Intel Graphics Development , Maxime Ripard , linux-mediatek@lists.infradead.org, DRI Development , Laurentiu Palcu , Matthias Brugger , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Maxime Coquelin , Tomi Valkeinen , Jyri Sarha , Yannick Fertre , Sandy Huang , linux-sunxi@lists.linux.dev, Philippe Cornu , Philipp Zabel , Shawn Guo , Lucas Stach Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Daniel, Le ven., mai 21 2021 at 11:09:54 +0200, Daniel Vetter = a =E9crit : > No need to set it explicitly. > = > Signed-off-by: Daniel Vetter > Cc: Laurentiu Palcu > Cc: Lucas Stach > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Pengutronix Kernel Team > Cc: Fabio Estevam > Cc: NXP Linux Team > Cc: Philipp Zabel > Cc: Paul Cercueil > Cc: Chun-Kuang Hu > Cc: Matthias Brugger > Cc: Neil Armstrong > Cc: Kevin Hilman > Cc: Jerome Brunet > Cc: Martin Blumenstingl > Cc: Marek Vasut > Cc: Stefan Agner > Cc: Sandy Huang > Cc: "Heiko St=FCbner" > Cc: Yannick Fertre > Cc: Philippe Cornu > Cc: Benjamin Gaignard > Cc: Maxime Coquelin > Cc: Alexandre Torgue > Cc: Maxime Ripard > Cc: Chen-Yu Tsai > Cc: Jernej Skrabec > Cc: Jyri Sarha > Cc: Tomi Valkeinen > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-mips@vger.kernel.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-amlogic@lists.infradead.org > Cc: linux-rockchip@lists.infradead.org > Cc: linux-stm32@st-md-mailman.stormreply.com > Cc: linux-sunxi@lists.linux.dev > --- > drivers/gpu/drm/imx/dcss/dcss-plane.c | 1 - > drivers/gpu/drm/imx/ipuv3-plane.c | 1 - > drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 1 - > drivers/gpu/drm/ingenic/ingenic-ipu.c | 1 - For drivers/gpu/drm/ingenic/*: Acked-by: Paul Cercueil Cheers, -Paul > drivers/gpu/drm/mediatek/mtk_drm_plane.c | 1 - > drivers/gpu/drm/meson/meson_overlay.c | 1 - > drivers/gpu/drm/meson/meson_plane.c | 1 - > drivers/gpu/drm/mxsfb/mxsfb_kms.c | 2 -- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 - > drivers/gpu/drm/stm/ltdc.c | 1 - > drivers/gpu/drm/sun4i/sun4i_layer.c | 1 - > drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 1 - > drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 1 - > drivers/gpu/drm/tidss/tidss_plane.c | 1 - > 14 files changed, 15 deletions(-) > = > diff --git a/drivers/gpu/drm/imx/dcss/dcss-plane.c = > b/drivers/gpu/drm/imx/dcss/dcss-plane.c > index 044d3bdf313c..ac45d54acd4e 100644 > --- a/drivers/gpu/drm/imx/dcss/dcss-plane.c > +++ b/drivers/gpu/drm/imx/dcss/dcss-plane.c > @@ -361,7 +361,6 @@ static void dcss_plane_atomic_disable(struct = > drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs dcss_plane_helper_funcs =3D = > { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D dcss_plane_atomic_check, > .atomic_update =3D dcss_plane_atomic_update, > .atomic_disable =3D dcss_plane_atomic_disable, > diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c = > b/drivers/gpu/drm/imx/ipuv3-plane.c > index 8710f55d2579..ef114b6aa691 100644 > --- a/drivers/gpu/drm/imx/ipuv3-plane.c > +++ b/drivers/gpu/drm/imx/ipuv3-plane.c > @@ -772,7 +772,6 @@ static void ipu_plane_atomic_update(struct = > drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs ipu_plane_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D ipu_plane_atomic_check, > .atomic_disable =3D ipu_plane_atomic_disable, > .atomic_update =3D ipu_plane_atomic_update, > diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c = > b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > index 389cad59e090..62db7349bf6a 100644 > --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > @@ -786,7 +786,6 @@ static const struct drm_plane_helper_funcs = > ingenic_drm_plane_helper_funcs =3D { > .atomic_update =3D ingenic_drm_plane_atomic_update, > .atomic_check =3D ingenic_drm_plane_atomic_check, > .atomic_disable =3D ingenic_drm_plane_atomic_disable, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; > = > static const struct drm_crtc_helper_funcs = > ingenic_drm_crtc_helper_funcs =3D { > diff --git a/drivers/gpu/drm/ingenic/ingenic-ipu.c = > b/drivers/gpu/drm/ingenic/ingenic-ipu.c > index 3b1091e7c0cd..caf038f3e231 100644 > --- a/drivers/gpu/drm/ingenic/ingenic-ipu.c > +++ b/drivers/gpu/drm/ingenic/ingenic-ipu.c > @@ -615,7 +615,6 @@ static const struct drm_plane_helper_funcs = > ingenic_ipu_plane_helper_funcs =3D { > .atomic_update =3D ingenic_ipu_plane_atomic_update, > .atomic_check =3D ingenic_ipu_plane_atomic_check, > .atomic_disable =3D ingenic_ipu_plane_atomic_disable, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; > = > static int > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c = > b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > index b5582dcf564c..1667a7e7de38 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > @@ -227,7 +227,6 @@ static void mtk_plane_atomic_update(struct = > drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs mtk_plane_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D mtk_plane_atomic_check, > .atomic_update =3D mtk_plane_atomic_update, > .atomic_disable =3D mtk_plane_atomic_disable, > diff --git a/drivers/gpu/drm/meson/meson_overlay.c = > b/drivers/gpu/drm/meson/meson_overlay.c > index ed063152aecd..dfef8afcc245 100644 > --- a/drivers/gpu/drm/meson/meson_overlay.c > +++ b/drivers/gpu/drm/meson/meson_overlay.c > @@ -747,7 +747,6 @@ static const struct drm_plane_helper_funcs = > meson_overlay_helper_funcs =3D { > .atomic_check =3D meson_overlay_atomic_check, > .atomic_disable =3D meson_overlay_atomic_disable, > .atomic_update =3D meson_overlay_atomic_update, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; > = > static bool meson_overlay_format_mod_supported(struct drm_plane = > *plane, > diff --git a/drivers/gpu/drm/meson/meson_plane.c = > b/drivers/gpu/drm/meson/meson_plane.c > index a18510dae4c8..8640a8a8a469 100644 > --- a/drivers/gpu/drm/meson/meson_plane.c > +++ b/drivers/gpu/drm/meson/meson_plane.c > @@ -422,7 +422,6 @@ static const struct drm_plane_helper_funcs = > meson_plane_helper_funcs =3D { > .atomic_check =3D meson_plane_atomic_check, > .atomic_disable =3D meson_plane_atomic_disable, > .atomic_update =3D meson_plane_atomic_update, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; > = > static bool meson_plane_format_mod_supported(struct drm_plane *plane, > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c = > b/drivers/gpu/drm/mxsfb/mxsfb_kms.c > index 300e7bab0f43..8797c671d0d5 100644 > --- a/drivers/gpu/drm/mxsfb/mxsfb_kms.c > +++ b/drivers/gpu/drm/mxsfb/mxsfb_kms.c > @@ -500,13 +500,11 @@ static bool mxsfb_format_mod_supported(struct = > drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs = > mxsfb_plane_primary_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D mxsfb_plane_atomic_check, > .atomic_update =3D mxsfb_plane_primary_atomic_update, > }; > = > static const struct drm_plane_helper_funcs = > mxsfb_plane_overlay_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D mxsfb_plane_atomic_check, > .atomic_update =3D mxsfb_plane_overlay_atomic_update, > }; > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c = > b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > index 64469439ddf2..6406bc0a71c7 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -1109,7 +1109,6 @@ static const struct drm_plane_helper_funcs = > plane_helper_funcs =3D { > .atomic_disable =3D vop_plane_atomic_disable, > .atomic_async_check =3D vop_plane_atomic_async_check, > .atomic_async_update =3D vop_plane_atomic_async_update, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; > = > static const struct drm_plane_funcs vop_plane_funcs =3D { > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c > index e99771b947b6..a5a2956f23f2 100644 > --- a/drivers/gpu/drm/stm/ltdc.c > +++ b/drivers/gpu/drm/stm/ltdc.c > @@ -946,7 +946,6 @@ static const struct drm_plane_funcs = > ltdc_plane_funcs =3D { > }; > = > static const struct drm_plane_helper_funcs ltdc_plane_helper_funcs =3D = > { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D ltdc_plane_atomic_check, > .atomic_update =3D ltdc_plane_atomic_update, > .atomic_disable =3D ltdc_plane_atomic_disable, > diff --git a/drivers/gpu/drm/sun4i/sun4i_layer.c = > b/drivers/gpu/drm/sun4i/sun4i_layer.c > index 11771bdd6e7c..929e95f86b5b 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_layer.c > +++ b/drivers/gpu/drm/sun4i/sun4i_layer.c > @@ -127,7 +127,6 @@ static bool = > sun4i_layer_format_mod_supported(struct drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs = > sun4i_backend_layer_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_disable =3D sun4i_backend_layer_atomic_disable, > .atomic_update =3D sun4i_backend_layer_atomic_update, > }; > diff --git a/drivers/gpu/drm/sun4i/sun8i_ui_layer.c = > b/drivers/gpu/drm/sun4i/sun8i_ui_layer.c > index 0db164a774a1..ac3d43394589 100644 > --- a/drivers/gpu/drm/sun4i/sun8i_ui_layer.c > +++ b/drivers/gpu/drm/sun4i/sun8i_ui_layer.c > @@ -332,7 +332,6 @@ static void sun8i_ui_layer_atomic_update(struct = > drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs = > sun8i_ui_layer_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D sun8i_ui_layer_atomic_check, > .atomic_disable =3D sun8i_ui_layer_atomic_disable, > .atomic_update =3D sun8i_ui_layer_atomic_update, > diff --git a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c = > b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c > index 46420780db59..45b1e37f9cda 100644 > --- a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c > +++ b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c > @@ -436,7 +436,6 @@ static void sun8i_vi_layer_atomic_update(struct = > drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs = > sun8i_vi_layer_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D sun8i_vi_layer_atomic_check, > .atomic_disable =3D sun8i_vi_layer_atomic_disable, > .atomic_update =3D sun8i_vi_layer_atomic_update, > diff --git a/drivers/gpu/drm/tidss/tidss_plane.c = > b/drivers/gpu/drm/tidss/tidss_plane.c > index 1acd15aa4193..217415ec8eea 100644 > --- a/drivers/gpu/drm/tidss/tidss_plane.c > +++ b/drivers/gpu/drm/tidss/tidss_plane.c > @@ -158,7 +158,6 @@ static void drm_plane_destroy(struct drm_plane = > *plane) > } > = > static const struct drm_plane_helper_funcs tidss_plane_helper_funcs = > =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D tidss_plane_atomic_check, > .atomic_update =3D tidss_plane_atomic_update, > .atomic_disable =3D tidss_plane_atomic_disable, > -- > 2.31.0 > = _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77089C433B4 for ; Fri, 21 May 2021 12:22:51 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E32266108B for ; Fri, 21 May 2021 12:22:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E32266108B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=crapouillou.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Cc:To :Subject:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FsUi0/XGCKpXm5mPniASdODsNfWW+6Sgq/tEvRvBk7c=; b=D+Bz3QP0RDNkxkIickawqcg+MT UYW2EA9Wp1WC8sdO/YyBRpyNzLEvcckReX19WxsE8QxKrlGd+7Rguq+vt+yjBljvfsx4+t+lD78Wk OSbzPk2boIFliTq79LGgeNLv8BG98h3G/ynZCUE+PnICYs6BYfcan4USKbZh/CL3CzO/gioKO+4B9 Vm2TtvYg5XqZOpGhRpxkV5ZQnCeY5VD63i4X3bTVssgLaTfUoVg5omMVW64nk1WOBjB5We/bNUXJ1 /lAtEWHyVhuqbMzEvJnfxlhRnkCmZ3yt3ry9d5sa80LpHDuo/hIgIShwXyvonxzXmpwFmbsppT77V cFxNV6aQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk4Aw-005IQW-6t; Fri, 21 May 2021 12:22:46 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk4At-005IPR-DR; Fri, 21 May 2021 12:22:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Cc:To:Subject: From:Date:Sender:Reply-To:Content-ID:Content-Description; bh=Wc4ZpGr+2zSfLJvlFOAyiKDWa51Os7NyvXHLQP7pVj0=; b=Jl2e9WzXrTtTkuYpCX82UgABDR Oox8hoYCkF8BrMEsJJ28+uD5fseYog/xT3olMYIEGRzA/C2tRvunLTdOTU5eO3VUgEZn5Uk0dByri aXm0Qe+kPdFjzlnpjAx6wyT4Yj8T7QL2lpUf0UrRziYeh5zJx0mZIl5k8IvW2AuL0OOyBSkgzrt1p HblE01xexv5Ey9GuZSeQ5YtRtIcsjiiOYIpnxp0TqOZtwdpeiE16oVOpFodFCFZzbMn7ywdsR5Fad IQt2jN97qMiWD4InMiKdttiqyvEsc9fX1U7Jayz7KxBr541IOIVFB1DhMTvjvD6MjHcORu/QO1ZN4 DHX7wAQQ==; Received: from aposti.net ([89.234.176.197]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lk4Ap-00H5tf-VN; Fri, 21 May 2021 12:22:42 +0000 Date: Fri, 21 May 2021 13:22:11 +0100 From: Paul Cercueil Subject: Re: [PATCH 06/11] drm/: drm_gem_plane_helper_prepare_fb is now the default To: Daniel Vetter Cc: DRI Development , Intel Graphics Development , Daniel Vetter , Laurentiu Palcu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Philipp Zabel , Chun-Kuang Hu , Matthias Brugger , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Marek Vasut , Stefan Agner , Sandy Huang , Heiko =?iso-8859-1?q?St=FCbner?= , Yannick Fertre , Philippe Cornu , Benjamin Gaignard , Maxime Coquelin , Alexandre Torgue , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Jyri Sarha , Tomi Valkeinen , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev Message-Id: In-Reply-To: <20210521090959.1663703-6-daniel.vetter@ffwll.ch> References: <20210521090959.1663703-1-daniel.vetter@ffwll.ch> <20210521090959.1663703-6-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210521_052240_183473_2B768230 X-CRM114-Status: GOOD ( 14.19 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Daniel, Le ven., mai 21 2021 at 11:09:54 +0200, Daniel Vetter = a =E9crit : > No need to set it explicitly. > = > Signed-off-by: Daniel Vetter > Cc: Laurentiu Palcu > Cc: Lucas Stach > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Pengutronix Kernel Team > Cc: Fabio Estevam > Cc: NXP Linux Team > Cc: Philipp Zabel > Cc: Paul Cercueil > Cc: Chun-Kuang Hu > Cc: Matthias Brugger > Cc: Neil Armstrong > Cc: Kevin Hilman > Cc: Jerome Brunet > Cc: Martin Blumenstingl > Cc: Marek Vasut > Cc: Stefan Agner > Cc: Sandy Huang > Cc: "Heiko St=FCbner" > Cc: Yannick Fertre > Cc: Philippe Cornu > Cc: Benjamin Gaignard > Cc: Maxime Coquelin > Cc: Alexandre Torgue > Cc: Maxime Ripard > Cc: Chen-Yu Tsai > Cc: Jernej Skrabec > Cc: Jyri Sarha > Cc: Tomi Valkeinen > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-mips@vger.kernel.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-amlogic@lists.infradead.org > Cc: linux-rockchip@lists.infradead.org > Cc: linux-stm32@st-md-mailman.stormreply.com > Cc: linux-sunxi@lists.linux.dev > --- > drivers/gpu/drm/imx/dcss/dcss-plane.c | 1 - > drivers/gpu/drm/imx/ipuv3-plane.c | 1 - > drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 1 - > drivers/gpu/drm/ingenic/ingenic-ipu.c | 1 - For drivers/gpu/drm/ingenic/*: Acked-by: Paul Cercueil Cheers, -Paul > drivers/gpu/drm/mediatek/mtk_drm_plane.c | 1 - > drivers/gpu/drm/meson/meson_overlay.c | 1 - > drivers/gpu/drm/meson/meson_plane.c | 1 - > drivers/gpu/drm/mxsfb/mxsfb_kms.c | 2 -- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 - > drivers/gpu/drm/stm/ltdc.c | 1 - > drivers/gpu/drm/sun4i/sun4i_layer.c | 1 - > drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 1 - > drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 1 - > drivers/gpu/drm/tidss/tidss_plane.c | 1 - > 14 files changed, 15 deletions(-) > = > diff --git a/drivers/gpu/drm/imx/dcss/dcss-plane.c = > b/drivers/gpu/drm/imx/dcss/dcss-plane.c > index 044d3bdf313c..ac45d54acd4e 100644 > --- a/drivers/gpu/drm/imx/dcss/dcss-plane.c > +++ b/drivers/gpu/drm/imx/dcss/dcss-plane.c > @@ -361,7 +361,6 @@ static void dcss_plane_atomic_disable(struct = > drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs dcss_plane_helper_funcs =3D = > { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D dcss_plane_atomic_check, > .atomic_update =3D dcss_plane_atomic_update, > .atomic_disable =3D dcss_plane_atomic_disable, > diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c = > b/drivers/gpu/drm/imx/ipuv3-plane.c > index 8710f55d2579..ef114b6aa691 100644 > --- a/drivers/gpu/drm/imx/ipuv3-plane.c > +++ b/drivers/gpu/drm/imx/ipuv3-plane.c > @@ -772,7 +772,6 @@ static void ipu_plane_atomic_update(struct = > drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs ipu_plane_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D ipu_plane_atomic_check, > .atomic_disable =3D ipu_plane_atomic_disable, > .atomic_update =3D ipu_plane_atomic_update, > diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c = > b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > index 389cad59e090..62db7349bf6a 100644 > --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > @@ -786,7 +786,6 @@ static const struct drm_plane_helper_funcs = > ingenic_drm_plane_helper_funcs =3D { > .atomic_update =3D ingenic_drm_plane_atomic_update, > .atomic_check =3D ingenic_drm_plane_atomic_check, > .atomic_disable =3D ingenic_drm_plane_atomic_disable, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; > = > static const struct drm_crtc_helper_funcs = > ingenic_drm_crtc_helper_funcs =3D { > diff --git a/drivers/gpu/drm/ingenic/ingenic-ipu.c = > b/drivers/gpu/drm/ingenic/ingenic-ipu.c > index 3b1091e7c0cd..caf038f3e231 100644 > --- a/drivers/gpu/drm/ingenic/ingenic-ipu.c > +++ b/drivers/gpu/drm/ingenic/ingenic-ipu.c > @@ -615,7 +615,6 @@ static const struct drm_plane_helper_funcs = > ingenic_ipu_plane_helper_funcs =3D { > .atomic_update =3D ingenic_ipu_plane_atomic_update, > .atomic_check =3D ingenic_ipu_plane_atomic_check, > .atomic_disable =3D ingenic_ipu_plane_atomic_disable, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; > = > static int > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c = > b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > index b5582dcf564c..1667a7e7de38 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > @@ -227,7 +227,6 @@ static void mtk_plane_atomic_update(struct = > drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs mtk_plane_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D mtk_plane_atomic_check, > .atomic_update =3D mtk_plane_atomic_update, > .atomic_disable =3D mtk_plane_atomic_disable, > diff --git a/drivers/gpu/drm/meson/meson_overlay.c = > b/drivers/gpu/drm/meson/meson_overlay.c > index ed063152aecd..dfef8afcc245 100644 > --- a/drivers/gpu/drm/meson/meson_overlay.c > +++ b/drivers/gpu/drm/meson/meson_overlay.c > @@ -747,7 +747,6 @@ static const struct drm_plane_helper_funcs = > meson_overlay_helper_funcs =3D { > .atomic_check =3D meson_overlay_atomic_check, > .atomic_disable =3D meson_overlay_atomic_disable, > .atomic_update =3D meson_overlay_atomic_update, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; > = > static bool meson_overlay_format_mod_supported(struct drm_plane = > *plane, > diff --git a/drivers/gpu/drm/meson/meson_plane.c = > b/drivers/gpu/drm/meson/meson_plane.c > index a18510dae4c8..8640a8a8a469 100644 > --- a/drivers/gpu/drm/meson/meson_plane.c > +++ b/drivers/gpu/drm/meson/meson_plane.c > @@ -422,7 +422,6 @@ static const struct drm_plane_helper_funcs = > meson_plane_helper_funcs =3D { > .atomic_check =3D meson_plane_atomic_check, > .atomic_disable =3D meson_plane_atomic_disable, > .atomic_update =3D meson_plane_atomic_update, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; > = > static bool meson_plane_format_mod_supported(struct drm_plane *plane, > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c = > b/drivers/gpu/drm/mxsfb/mxsfb_kms.c > index 300e7bab0f43..8797c671d0d5 100644 > --- a/drivers/gpu/drm/mxsfb/mxsfb_kms.c > +++ b/drivers/gpu/drm/mxsfb/mxsfb_kms.c > @@ -500,13 +500,11 @@ static bool mxsfb_format_mod_supported(struct = > drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs = > mxsfb_plane_primary_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D mxsfb_plane_atomic_check, > .atomic_update =3D mxsfb_plane_primary_atomic_update, > }; > = > static const struct drm_plane_helper_funcs = > mxsfb_plane_overlay_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D mxsfb_plane_atomic_check, > .atomic_update =3D mxsfb_plane_overlay_atomic_update, > }; > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c = > b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > index 64469439ddf2..6406bc0a71c7 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -1109,7 +1109,6 @@ static const struct drm_plane_helper_funcs = > plane_helper_funcs =3D { > .atomic_disable =3D vop_plane_atomic_disable, > .atomic_async_check =3D vop_plane_atomic_async_check, > .atomic_async_update =3D vop_plane_atomic_async_update, > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > }; > = > static const struct drm_plane_funcs vop_plane_funcs =3D { > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c > index e99771b947b6..a5a2956f23f2 100644 > --- a/drivers/gpu/drm/stm/ltdc.c > +++ b/drivers/gpu/drm/stm/ltdc.c > @@ -946,7 +946,6 @@ static const struct drm_plane_funcs = > ltdc_plane_funcs =3D { > }; > = > static const struct drm_plane_helper_funcs ltdc_plane_helper_funcs =3D = > { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D ltdc_plane_atomic_check, > .atomic_update =3D ltdc_plane_atomic_update, > .atomic_disable =3D ltdc_plane_atomic_disable, > diff --git a/drivers/gpu/drm/sun4i/sun4i_layer.c = > b/drivers/gpu/drm/sun4i/sun4i_layer.c > index 11771bdd6e7c..929e95f86b5b 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_layer.c > +++ b/drivers/gpu/drm/sun4i/sun4i_layer.c > @@ -127,7 +127,6 @@ static bool = > sun4i_layer_format_mod_supported(struct drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs = > sun4i_backend_layer_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_disable =3D sun4i_backend_layer_atomic_disable, > .atomic_update =3D sun4i_backend_layer_atomic_update, > }; > diff --git a/drivers/gpu/drm/sun4i/sun8i_ui_layer.c = > b/drivers/gpu/drm/sun4i/sun8i_ui_layer.c > index 0db164a774a1..ac3d43394589 100644 > --- a/drivers/gpu/drm/sun4i/sun8i_ui_layer.c > +++ b/drivers/gpu/drm/sun4i/sun8i_ui_layer.c > @@ -332,7 +332,6 @@ static void sun8i_ui_layer_atomic_update(struct = > drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs = > sun8i_ui_layer_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D sun8i_ui_layer_atomic_check, > .atomic_disable =3D sun8i_ui_layer_atomic_disable, > .atomic_update =3D sun8i_ui_layer_atomic_update, > diff --git a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c = > b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c > index 46420780db59..45b1e37f9cda 100644 > --- a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c > +++ b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c > @@ -436,7 +436,6 @@ static void sun8i_vi_layer_atomic_update(struct = > drm_plane *plane, > } > = > static const struct drm_plane_helper_funcs = > sun8i_vi_layer_helper_funcs =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D sun8i_vi_layer_atomic_check, > .atomic_disable =3D sun8i_vi_layer_atomic_disable, > .atomic_update =3D sun8i_vi_layer_atomic_update, > diff --git a/drivers/gpu/drm/tidss/tidss_plane.c = > b/drivers/gpu/drm/tidss/tidss_plane.c > index 1acd15aa4193..217415ec8eea 100644 > --- a/drivers/gpu/drm/tidss/tidss_plane.c > +++ b/drivers/gpu/drm/tidss/tidss_plane.c > @@ -158,7 +158,6 @@ static void drm_plane_destroy(struct drm_plane = > *plane) > } > = > static const struct drm_plane_helper_funcs tidss_plane_helper_funcs = > =3D { > - .prepare_fb =3D drm_gem_plane_helper_prepare_fb, > .atomic_check =3D tidss_plane_atomic_check, > .atomic_update =3D tidss_plane_atomic_update, > .atomic_disable =3D tidss_plane_atomic_disable, > -- > 2.31.0 > = _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic