From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96B10C76196 for ; Tue, 28 Mar 2023 07:49:26 +0000 (UTC) Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.96) (envelope-from ) id 1ph457-0000uy-1I for kernelnewbies@archiver.kernel.org; Tue, 28 Mar 2023 03:49:25 -0400 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1ph43M-0007L6-3A for kernelnewbies@kernelnewbies.org; Tue, 28 Mar 2023 03:47:42 -0400 Received: by mail-pj1-x1031.google.com with SMTP id o6-20020a17090a9f8600b0023f32869993so14306288pjp.1 for ; Tue, 28 Mar 2023 00:47:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679989648; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1PMLIBBCXdYrqpnd2b8r//eCQmEahNY+IF0VfB8Tfi4=; b=COqaQgmaWW5onMCA5/x9hB3x7aiZjXMIjC0LL639vtAD1Nsr8nRKYJiz2nFb8JT5tx 8AQJSpqzMC32nzOVXWWgf9dANVd8LFMs06ljBriE/vGhUWydbFrs++SCL+TNAkItHTnt FS7s4vikxP+ptgxmUSEhVUYuO+h2Eai39bRgxpG3Iku7vcif8kvYcNV1ru+YvbgQQJnv rPVtzRTThzdZAbtO+jWPFgRZQSplh1HFPzocBh1E4OK2MqsQAFRTTR27Y5+Tgm0Co2FY aXsaS8Esx4l6OA6PNqD2SYu4ozescSjt1NNYFYt+15hmJaGVEkeIor/PDdyWBh0XrgJC G1Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679989648; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1PMLIBBCXdYrqpnd2b8r//eCQmEahNY+IF0VfB8Tfi4=; b=JeSCojc86cTppMqhKW1SA0J8V6kUxhPa/SqyJ64SJrYfAXO3ZeGdJoga2WpHtIW5d1 L41OQLs5OfeFkF6SBJy785/Ul/tGxOqdDqpkSB15RBvm5j6jOytzhTRJpD9uzWGZ84GZ IOqYSP35Qj82tQ659lfDoA2LFlkhtjjKzh7lAUhyVynDrcfrfoTii/5wcudAi0ZnOMPc d89ayWkXSofId0IMcARCvnZDV8TXQwNAl/In2Ktgc/Hd1kbgHGD3sYoZ7zncytqQnI9+ KnsB71tAJMLJo/8bfcZiz0tvL4e/YNrWSreXOVNcXVXhg73HVNUNyc1QCeYmnsvQIYvX kuhw== X-Gm-Message-State: AO0yUKWWzXy/6MUc7HJU7EdSvMI0poihwEcMv9+pn4vl6kZpu2ijwDs0 rQP8mECvB5Hu7O4nVY/lOB0= X-Google-Smtp-Source: AK7set/O0GjLwQiDT9ld+R0YgeBKyJ/u3v76qC7pDNw5DVOHe4c3DkvXYU/jOx+QmvcCRjTAxGGl0g== X-Received: by 2002:a05:6a20:3a89:b0:d9:b59c:d09e with SMTP id d9-20020a056a203a8900b000d9b59cd09emr13680634pzh.11.1679989648453; Tue, 28 Mar 2023 00:47:28 -0700 (PDT) Received: from trent-reznor ([2601:641:4000:81:94c0:86ec:d844:1f3f]) by smtp.gmail.com with ESMTPSA id 17-20020aa79251000000b005897f5436c0sm9967451pfp.118.2023.03.28.00.47.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Mar 2023 00:47:28 -0700 (PDT) Date: Tue, 28 Mar 2023 00:47:26 -0700 From: Daniel Watson To: Lukas Bulwahn Subject: Re: screening patch here before sending to devs Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: kernelnewbies@kernelnewbies.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces+kernelnewbies=archiver.kernel.org@kernelnewbies.org On Tue, Mar 28, 2023 at 09:03:17AM +0200, Lukas Bulwahn wrote: > Hi Daniel, Hi! thanks for pre-reviewing! > > Sometimes patches show up multiple times in lore.kernel.org archives, > as some mailing list add further footers, so the same content sent is > recorded slightly differently in the archives, leading to multiple > copies. This is not considered double posting, though, as it is > default to send a patch to multiple mailing lists, e.g., specific > subsystem mailing list and the general linux-kernel mailing list. As > long as the message has the same Message-ID, it is clear they were > sent with one "git send-email" invocation. cool. must be something wrong with gmail then. it's showing twice in my gmail. i'm not using git send-email, i'm using mutt configured to send through gmail. > Usually "{" would be written out as "opening brackets" or as "curly > brackets", just having a special character, like "{", is not seen > often in commit message subject lines. noted, i've changed that. > > Usually, consistency beats style. So, check if this pattern appears in > any files in drivers/staging/rtl8723bs/ and its subdirectories and try > to fix all instances within that directory with one patch. earlier in the same file, the curly bracket appears on the opening line, except for functions. > Other than that, it looks like a good newcomer's first submission patch. that's great! i've sent it in with the changes. i would like to work on my laptop battery's charge threshold. it can be changed in the bios, but not while running. there's a project for doing this on some thinkpads, but not the framework laptop. any pointers for where to get more info about this would be greatly appreciated. thanks again! _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies