From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22646C6FD18 for ; Tue, 28 Mar 2023 17:53:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229706AbjC1RxH (ORCPT ); Tue, 28 Mar 2023 13:53:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229886AbjC1Rwv (ORCPT ); Tue, 28 Mar 2023 13:52:51 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5C9D10ABE; Tue, 28 Mar 2023 10:52:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Wb/aIRtlfC2C3jG+RF0MsyFF/Fo2UynqeVSoO8JS/Z0=; b=BDH7Jj9zHHGqSkhzkUwbaaJTaW zZy0Vq0AElAfWug2nRqiMnGVybq1k70DD/aaH6okrYWFkTIv58te1zfU4gbF8VBfWiWOxlQXLEQM8 tX8GW/0V0/YTCadI4GWiZ3y3NH59ZkeHPwCIEp5wYvVpI84TYiueVZZcCclEJ+Qevtd5/PZBxwNmN MKI68BLlJBNkZxDJiWdTMuy/+QSHYMnHJm8vnEe3gQFrrwkhrxAjmrrLIBvicGUDRJk3uYNor1zJT /jscjKxMdGcJzWdEOi68Vi+mwxb9uli63bpK9iF2Ygt/i08hqTWhLnn8LqDyU1MbfhdqFztuKM3yP HQBq/oSQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1phDUO-00FNLk-0Q; Tue, 28 Mar 2023 17:52:08 +0000 Date: Tue, 28 Mar 2023 10:52:08 -0700 From: Luis Chamberlain To: Matthew Wilcox Cc: Mike Rapoport , Michal Hocko , linux-mm@kvack.org, Andrew Morton , Dave Hansen , Peter Zijlstra , Rick Edgecombe , Song Liu , Thomas Gleixner , Vlastimil Babka , linux-kernel@vger.kernel.org, x86@kernel.org, linux-modules@vger.kernel.org, Pankaj Raghav , Daniel Gomez , "kbus >> Keith Busch" , Davidlohr Bueso , Adam Manzanares , Kees Cook Subject: Re: [RFC PATCH 1/5] mm: intorduce __GFP_UNMAPPED and unmapped_alloc() Message-ID: References: <20230308094106.227365-1-rppt@kernel.org> <20230308094106.227365-2-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Luis Chamberlain Precedence: bulk List-ID: On Tue, Mar 28, 2023 at 06:37:13PM +0100, Matthew Wilcox wrote: > On Tue, Mar 28, 2023 at 10:18:50AM -0700, Luis Chamberlain wrote: > > differences with eBPF programs is that modules *can* be rather large > > in size. What is the average size of modules? Well let's take a look: > > > > mcgrof@bigtwin /mirror/code/mcgrof/linux-next (git::master)$ find ./ > > -name \*.ko| wc -l > > 9173 > > ummm ... wc -c, surely? That's the number of allmodconfig modules found. mcgrof@fulton ~/linux (git::sysctl-next)$ find ./ -name \*.ko| head -2 ./arch/x86/crypto/twofish-x86_64.ko ./arch/x86/crypto/serpent-avx2.ko mcgrof@fulton ~/linux (git::sysctl-next)$ find ./ -name \*.ko| head -2 | wc -l 2 mcgrof@fulton ~/linux (git::sysctl-next)$ find ./ -name \*.ko| head -2 | wc -c 70 wc -c would give a lot more. wc -l gives me the module count. > > mcgrof@bigtwin /mirror/code/mcgrof/linux-next (git::master)$ find ./ > > -name \*.ko| xargs stat -c "%s - %n" | sort -n -k 1 -r | tail > > -$((9173-5)) | awk 'BEGIN {sum=0} {sum+=$1} END {print sum/NR/1024}' > > 160.54 > > ... which invalidates all of these. Not sure ? But regardless the *.text* lookup is what we care for though which was later. Luis