From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5B4CC74A5B for ; Wed, 29 Mar 2023 13:52:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230164AbjC2Nwv (ORCPT ); Wed, 29 Mar 2023 09:52:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229999AbjC2Nwt (ORCPT ); Wed, 29 Mar 2023 09:52:49 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8ACBC2 for ; Wed, 29 Mar 2023 06:52:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 63225B8232B for ; Wed, 29 Mar 2023 13:52:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9BFBCC433D2; Wed, 29 Mar 2023 13:52:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680097965; bh=tY3+1vFhOirM40vPbYkObuXOJ7tqvmbmhcySnP4jWro=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=O4yhJzQl5nKtyqlKnhAOGYjDqRWK23t8SVM6E5dPIsuLSBK2+nWmgnVsMY04FPK2D uanmg7wiO++ULsgWYkPo5mbCXOFcrgSpMWYlp89IOgSsJSlZFG1Ov9viJaQdOEwFLd sjB68lBIMUU1/VxFqMbCcjR29j5Xk0c9TwVOBVZ+kwPgwPBe+Pje5FU3F4JxzSjZdf J8u9tQHTNjgIFVVYjIpth+KKaQOR46QXjWQ+CtKJ0vEMYiDkmvoFMBWw+/ueBqP/45 FdWlDXDWdZBi3uPuI3d3icvZLCC6UDYbxQcmyebxbmzpdLqx1kWCqY+4iPNAkMXdOO 2t9rxz8N/BFtQ== Date: Wed, 29 Mar 2023 14:52:40 +0100 From: Mark Brown To: Marian Postevca Cc: =?utf-8?B?5rKI5LiA6LaF?= , yangxiaohua , Zhu Ning , Takashi Iwai , Liam Girdwood , Jaroslav Kysela , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 3/4] ASoC: amd: acp: Add machine driver that enables sound for systems with a ES8336 codec Message-ID: References: <20230320203519.20137-1-posteuca@mutex.one> <20230320203519.20137-4-posteuca@mutex.one> <141a3320-ff65-459f-9d00-c8bed691dcfc@sirena.org.uk> <87lejpwxzf.fsf@mutex.one> <87ttycjyw3.fsf@mutex.one> <87r0t9uc08.fsf@mutex.one> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="FsDe0pyTf46JNN5d" Content-Disposition: inline In-Reply-To: <87r0t9uc08.fsf@mutex.one> X-Cookie: Single tasking: Just Say No. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --FsDe0pyTf46JNN5d Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 28, 2023 at 12:20:55AM +0300, Marian Postevca wrote: > Mark Brown writes: > > Surely if nothing else a good first step would be to have the > > CODEC driver do whatever disabling the jack does on suspend > > without needing the machine driver to bodge things? > I would go for properly analyzing what is going on and try to correctly fix it, > but it's going to take some time for me to do it. During this time > people with these laptops will not have working sound. Wouldn't it make Did you try my suggestion of having the CODEC driver do whatever is triggered by disabling the jack on suspend? That should just be simple code motion shouldn't it, not something that requires extensive investigation? > more sense to first deliver a working solution(even though it's not > perfect) than to make them wait? Also this workaround is already present > in the kernel, so it's not that critical that another driver uses it. On the other hand if we're getting the same bodge done repeatedly in a lot of machines that suggests it's something we should stop spreading... There was also the issue with automatically muting the speaker when headphones are inserted which will affect UCM files. --FsDe0pyTf46JNN5d Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmQkQqQACgkQJNaLcl1U h9AOYwf/ZwnNSUNFjDGXksy8GfP2Xr84EbJeFIfVFR6AMp8OwyxywdjeNMR67cSx yW9tIwQaJQhyo7CUOD76RdZm80yqAuZA9cK0IOc3Sg5epntjbQkF5rEhvoYTw7rV tVM0TLzI8B/qaGLkDGyTjdfFn2M9GbkYrDPXnjta6Jrw56iC8uKiP2lGDTsjFTv2 dM4KxRY4KHhZjDqXEPFOlwoLF/cz+xkfBqFVpQea+D3UFeM+FabbHzsR4GkJYk0G pUj0jx4WF4qHsxXUl2OnF4tmx4H+3l7NohncMqS2llTQwuK3yObBFLpnJc3hHTiT 1EsIVCwvdRpJBbP3JkCVgDilWVu8jQ== =NZyJ -----END PGP SIGNATURE----- --FsDe0pyTf46JNN5d-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6EEF8C74A5B for ; Wed, 29 Mar 2023 13:54:13 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6FA621EF; Wed, 29 Mar 2023 15:53:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6FA621EF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1680098050; bh=tY3+1vFhOirM40vPbYkObuXOJ7tqvmbmhcySnP4jWro=; h=Date:From:To:Subject:References:In-Reply-To:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=hurB5RCBlYn6p1lzfjPjQeIaWHtMkGrIoxGrBtNoKF56oWpgh8FjlsMuMCoql1DrR JWzWFpbS3SxQZBu4cViuSAsLUTe8pT+YMQw0pw+qw8pStYmKq7lPRyQxC9nTrM/xD2 8kzEX4Tsxu/+qaiUKc3E3XKj7Ge2z1R86i6rWSjo= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id ED9B3F80272; Wed, 29 Mar 2023 15:52:55 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5A7BBF80272; Wed, 29 Mar 2023 15:52:52 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BCE26F80114 for ; Wed, 29 Mar 2023 15:52:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BCE26F80114 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=O4yhJzQl Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A466C61A53; Wed, 29 Mar 2023 13:52:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9BFBCC433D2; Wed, 29 Mar 2023 13:52:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680097965; bh=tY3+1vFhOirM40vPbYkObuXOJ7tqvmbmhcySnP4jWro=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=O4yhJzQl5nKtyqlKnhAOGYjDqRWK23t8SVM6E5dPIsuLSBK2+nWmgnVsMY04FPK2D uanmg7wiO++ULsgWYkPo5mbCXOFcrgSpMWYlp89IOgSsJSlZFG1Ov9viJaQdOEwFLd sjB68lBIMUU1/VxFqMbCcjR29j5Xk0c9TwVOBVZ+kwPgwPBe+Pje5FU3F4JxzSjZdf J8u9tQHTNjgIFVVYjIpth+KKaQOR46QXjWQ+CtKJ0vEMYiDkmvoFMBWw+/ueBqP/45 FdWlDXDWdZBi3uPuI3d3icvZLCC6UDYbxQcmyebxbmzpdLqx1kWCqY+4iPNAkMXdOO 2t9rxz8N/BFtQ== Date: Wed, 29 Mar 2023 14:52:40 +0100 From: Mark Brown To: Marian Postevca Subject: Re: [PATCH 3/4] ASoC: amd: acp: Add machine driver that enables sound for systems with a ES8336 codec Message-ID: References: <20230320203519.20137-1-posteuca@mutex.one> <20230320203519.20137-4-posteuca@mutex.one> <141a3320-ff65-459f-9d00-c8bed691dcfc@sirena.org.uk> <87lejpwxzf.fsf@mutex.one> <87ttycjyw3.fsf@mutex.one> <87r0t9uc08.fsf@mutex.one> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="FsDe0pyTf46JNN5d" Content-Disposition: inline In-Reply-To: <87r0t9uc08.fsf@mutex.one> X-Cookie: Single tasking: Just Say No. Message-ID-Hash: WXEB7AZDSO47WSYE6TYTNYYTD2A7DGQO X-Message-ID-Hash: WXEB7AZDSO47WSYE6TYTNYYTD2A7DGQO X-MailFrom: broonie@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: =?utf-8?B?5rKI5LiA6LaF?= , yangxiaohua , Zhu Ning , Takashi Iwai , Liam Girdwood , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --FsDe0pyTf46JNN5d Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 28, 2023 at 12:20:55AM +0300, Marian Postevca wrote: > Mark Brown writes: > > Surely if nothing else a good first step would be to have the > > CODEC driver do whatever disabling the jack does on suspend > > without needing the machine driver to bodge things? > I would go for properly analyzing what is going on and try to correctly fix it, > but it's going to take some time for me to do it. During this time > people with these laptops will not have working sound. Wouldn't it make Did you try my suggestion of having the CODEC driver do whatever is triggered by disabling the jack on suspend? That should just be simple code motion shouldn't it, not something that requires extensive investigation? > more sense to first deliver a working solution(even though it's not > perfect) than to make them wait? Also this workaround is already present > in the kernel, so it's not that critical that another driver uses it. On the other hand if we're getting the same bodge done repeatedly in a lot of machines that suggests it's something we should stop spreading... There was also the issue with automatically muting the speaker when headphones are inserted which will affect UCM files. --FsDe0pyTf46JNN5d Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmQkQqQACgkQJNaLcl1U h9AOYwf/ZwnNSUNFjDGXksy8GfP2Xr84EbJeFIfVFR6AMp8OwyxywdjeNMR67cSx yW9tIwQaJQhyo7CUOD76RdZm80yqAuZA9cK0IOc3Sg5epntjbQkF5rEhvoYTw7rV tVM0TLzI8B/qaGLkDGyTjdfFn2M9GbkYrDPXnjta6Jrw56iC8uKiP2lGDTsjFTv2 dM4KxRY4KHhZjDqXEPFOlwoLF/cz+xkfBqFVpQea+D3UFeM+FabbHzsR4GkJYk0G pUj0jx4WF4qHsxXUl2OnF4tmx4H+3l7NohncMqS2llTQwuK3yObBFLpnJc3hHTiT 1EsIVCwvdRpJBbP3JkCVgDilWVu8jQ== =NZyJ -----END PGP SIGNATURE----- --FsDe0pyTf46JNN5d--