All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: Christoph Hellwig <hch@infradead.org>,
	linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
	willy@infradead.org, axboe@kernel.dk
Subject: Re: [PATCH 0/2] bio iter improvements
Date: Tue, 4 Apr 2023 08:20:01 -0700	[thread overview]
Message-ID: <ZCxAIR8pxOfSE6OR@infradead.org> (raw)
In-Reply-To: <ZCsAhDpsiNWpiAxS@moria.home.lan>

On Mon, Apr 03, 2023 at 12:36:20PM -0400, Kent Overstreet wrote:
> But this was all right there in the original commit message. And to be
> honest Christoph, these kinds of drive by "let's focus on the easiest
> thing to measure" comments are what I expect from you at this point,

I'm really just curious what the motivation is.  The code does not
seem much cleaner to me as the user of the API, and it doesn't reduce
code size.  Maybe there is a good reason for it, but then it needs to
be very clearly stated and you need to sell people on it.

Starting to get personal instead tends to not help to convince your
reviewers that it's really useful in general.

  reply	other threads:[~2023-04-04 15:20 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-27 17:44 [PATCH 0/2] bio iter improvements Kent Overstreet
2023-03-27 17:44 ` [PATCH 1/2] block: Rework bio_for_each_segment_all() Kent Overstreet
2023-03-29 16:50   ` Phillip Lougher
2023-03-30 17:55     ` Kent Overstreet
2023-03-30 18:59       ` Phillip Lougher
2023-03-31  1:10         ` Phillip Lougher
2023-04-01  2:28           ` Kent Overstreet
2023-04-03 13:57             ` Phillip Lougher
2023-03-30 11:49   ` Ming Lei
2023-03-30 16:20     ` Kent Overstreet
2023-03-27 17:44 ` [PATCH 2/2] block: Rework bio_for_each_folio_all() Kent Overstreet
2023-04-03 15:13   ` Christoph Hellwig
2023-04-03 15:51     ` Kent Overstreet
2023-03-27 22:14 ` [PATCH 0/2] bio iter improvements Christoph Hellwig
2023-03-28 20:28   ` Kent Overstreet
2023-04-03 15:10     ` Christoph Hellwig
2023-04-03 16:36       ` Kent Overstreet
2023-04-04 15:20         ` Christoph Hellwig [this message]
2023-04-04 15:47           ` Kent Overstreet
2023-04-04 15:59             ` Christoph Hellwig
2023-04-04 16:08               ` Kent Overstreet
2023-04-04 16:01             ` Jens Axboe
2023-04-04 16:06               ` Kent Overstreet
2023-04-04 16:14                 ` Jens Axboe
2023-04-04 17:11                   ` Kent Overstreet
2023-03-28 13:42 ` Phillip Lougher
2023-03-28 16:57   ` Kent Overstreet
2023-03-29 16:41     ` Phillip Lougher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZCxAIR8pxOfSE6OR@infradead.org \
    --to=hch@infradead.org \
    --cc=axboe@kernel.dk \
    --cc=kent.overstreet@linux.dev \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.