Re: [PATCH 2/3] pack-bitmap.c: extract `fill_in_bitmap()`t

From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
	Derrick Stolee <derrickstolee@github.com>
Subject: Re: [PATCH 2/3] pack-bitmap.c: extract `fill_in_bitmap()`t
Date: Tue, 25 Apr 2023 14:51:45 -0400	[thread overview]
Message-ID: <ZEghQRZWZIlZcIed@nand.local> (raw)
In-Reply-To: <xmqqmt2vzubq.fsf@gitster.g>

On Tue, Apr 25, 2023 at 11:32:25AM -0700, Junio C Hamano wrote:
> Taylor Blau <me@ttaylorr.com> writes:
>
> > To prepare for the boundary-based bitmap walk to perform a fill-in
> > traversal using the boundary of either side as the tips, extract routine
> > used to perform fill-in traversal by `find_objects()` so that it can be
> > used in both places.
>
> What is done is not a literal "extract", though.  Worth mentioning here?

Oops. It is supposed to be a literal extraction, but this patch was
originally written before 3e0370a8d2 (list-objects: consolidate
traverse_commit_list[_filtered], 2022-03-09).

> > ---
> >  pack-bitmap.c | 66 +++++++++++++++++++++++++++++----------------------
> >  1 file changed, 37 insertions(+), 29 deletions(-)
> >
> > +	if (base == NULL)
> > +		base = bitmap_new();
>
> Style?

...It was also written before afe8a9070b (tree-wide: apply
equals-null.cocci, 2022-05-02), which is where this "if (base == NULL)"
thing comes from. I fixed both to be a clean extraction with no
functional changes.

Thanks,
Taylor