From: Christoph Hellwig <hch@infradead.org>
To: "Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>
Cc: Jens Axboe <axboe@kernel.dk>,
drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org,
Lars Ellenberg <lars.ellenberg@linbit.com>,
Philipp Reisner <philipp.reisner@linbit.com>,
linux-block@vger.kernel.org, Thomas Voegtle <tv@lio96.de>
Subject: Re: [PATCH] drbd: do not set REQ_PREFLUSH when submitting barrier
Date: Tue, 2 May 2023 21:18:01 -0700 [thread overview]
Message-ID: <ZFHgefWofVt24tRl@infradead.org> (raw)
In-Reply-To: <20230502092922.175857-1-christoph.boehmwalder@linbit.com>
On Tue, May 02, 2023 at 11:29:22AM +0200, Christoph Böhmwalder wrote:
> struct bio *bio = bio_alloc(device->ldev->backing_bdev, 0,
> - REQ_OP_FLUSH | REQ_PREFLUSH, GFP_NOIO);
> + REQ_OP_FLUSH, GFP_NOIO);
This isn't going to work. flush bios are (somewhat confusingly)
implemented as writes with no data and the preflush flag. So this
should be:
REQ_OP_WRITE | REQ_PREFLUSH.
and it looks like whatever flushing this does hasn't wroked for a long
time.
next prev parent reply other threads:[~2023-05-03 4:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 9:29 [PATCH] drbd: do not set REQ_PREFLUSH when submitting barrier Christoph Böhmwalder
2023-05-03 4:18 ` Christoph Hellwig [this message]
2023-05-03 11:05 ` Christoph Böhmwalder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFHgefWofVt24tRl@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=christoph.boehmwalder@linbit.com \
--cc=drbd-dev@lists.linbit.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
--cc=tv@lio96.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.