All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/7] ALSA: pcm: fix playback silence - use the actual new_hw_ptr for the threshold mode
Date: Fri, 5 May 2023 17:52:11 +0200	[thread overview]
Message-ID: <ZFUmK+J76OuuAUmY@ugly> (raw)
In-Reply-To: <877ctmiyzy.wl-tiwai@suse.de>

On Fri, May 05, 2023 at 05:22:57PM +0200, Takashi Iwai wrote:
>On Fri, 05 May 2023 12:31:35 +0200,
>Oswald Buddenhagen wrote:
>> Suggested-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
>> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
>> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
>
>Here misses your Signed-off-by tag.  Ditto for the patch 3.
>It's a legal requirement, and I can't apply patches without it.
>
i assumed reviewed-by would be a superset, but apparently it's not.
however, there is no need to add SOB to patches which i only reviewed or 
suggested. i'll adjust the patches to which i made substantial 
modifications, though.

regards

  reply	other threads:[~2023-05-05 15:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-05 10:31 [PATCH 1/7] ALSA: pcm: Revert "ALSA: pcm: rewrite snd_pcm_playback_silence()" Oswald Buddenhagen
2023-05-05 10:31 ` [PATCH 2/7] ALSA: pcm: fix playback silence - use the actual new_hw_ptr for the threshold mode Oswald Buddenhagen
2023-05-05 15:22   ` Takashi Iwai
2023-05-05 15:52     ` Oswald Buddenhagen [this message]
2023-05-05 16:22       ` Takashi Iwai
2023-05-05 16:32         ` Oswald Buddenhagen
2023-05-05 10:31 ` [PATCH 3/7] ALSA: pcm: fix playback silence - correct incremental silencing Oswald Buddenhagen
2023-05-05 10:31 ` [PATCH 4/7] ALSA: pcm: playback silence - remove extra code Oswald Buddenhagen
2023-05-05 10:31 ` [PATCH 5/7] ALSA: pcm: playback silence - move silence variable updates to separate function Oswald Buddenhagen
2023-05-05 10:31 ` [PATCH 6/7] ALSA: pcm: simplify top-up mode init in snd_pcm_playback_silence() Oswald Buddenhagen
2023-05-05 10:31 ` [PATCH 7/7] ALSA: pcm: use exit controlled loop " Oswald Buddenhagen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZFUmK+J76OuuAUmY@ugly \
    --to=oswald.buddenhagen@gmx.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.