From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51E05C77B7E for ; Thu, 25 May 2023 04:08:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238290AbjEYEIF (ORCPT ); Thu, 25 May 2023 00:08:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237896AbjEYEHW (ORCPT ); Thu, 25 May 2023 00:07:22 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29FCA1711; Wed, 24 May 2023 21:05:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+Rcg59tq5Dl+6L+r8l6uwmuQm/aS0R/EBEonRbKOuco=; b=Vpkjy/zPqLAbxZf6ITNl+lGwjS nZwEanDG+mDgOewsGVfDM/uPyMY/vLDHgN9HUb32EbjT9dm9j8GWHEFIEcAD3KJ2S2APD70rT1aYq PWrA4DCdUJvyxk1XlvD5OJzRNU0z8XPOni5p290SZUGrL7h5SLcUG6a612QRkvOLbPzxkHVECZJoi 0jvFoo5OToVmjcTFuYzEG+Mfxmc7DGXTQs42v3hE2g2R0FTObPuNWgBYkdIvpgnjcZhq/5BdgcKX+ nGl5XTusfjuyS7BYl5GycouUlMSaW4ctAmtjq0dYdVQpAwD/mpB+4evqKKLpwU7OeEGOlX7nCHImW amBlZbHA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1q22Ds-00BpM4-4Y; Thu, 25 May 2023 04:05:08 +0000 Date: Thu, 25 May 2023 05:05:08 +0100 From: Matthew Wilcox To: Anshuman Khandual Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Catalin Marinas , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 09/36] arm64: Implement the new page table range API Message-ID: References: <20230315051444.3229621-1-willy@infradead.org> <20230315051444.3229621-10-willy@infradead.org> <592942c0-00dc-0317-0411-f9e17870fb11@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <592942c0-00dc-0317-0411-f9e17870fb11@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 25, 2023 at 09:05:35AM +0530, Anshuman Khandual wrote: > > @@ -127,6 +127,8 @@ extern void copy_to_user_page(struct vm_area_struct *, struct page *, > > */ > > #define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE 1 > > extern void flush_dcache_page(struct page *); > > +void flush_dcache_folio(struct folio *); > > This is giving a checkpatch.pl warning > > WARNING: function definition argument 'struct folio *' should also have an identifier name > #36: FILE: arch/arm64/include/asm/cacheflush.h:130: > +void flush_dcache_folio(struct folio *); Yes, but checkpatch is *stupid*. Don't just follow tools blindly. How is naming the parameter here helping anyone? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCC73C77B7E for ; Thu, 25 May 2023 04:05:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/ETCUeLQcSsZVSHH2Qn+82dYP38OMjwC+rf0bhj1jHc=; b=ZVIdsuYwSeExZj ghAk/JzsRbCr9PXZSVZVi7lImyhjfUjMwG/zp7ASUf4dP2BEKdTjs4ZovhpR5xKwy18kJCwaJq74H UVy6wm0ZPwRuXj0KXXlzfaCMgyOL4khez+2IyTbPDEp0JirR3G9UrkIWUbknc9eNKANDdrIw36WFP RvmxIssC+GYPLzGBmrBpD+t+DYDW+6On5oeQ+w43NCeHhbA7cBN74azgAAIOkRqELKgxAOKGDa5FY o77OfyRF9gDmpQE/xaRTQGyHAmt4UjKSgNNXeylvGu+/1OjrZMJoMGImZzYNxBq/X8e8GOC0wH/yB ZP4InQaUaGFSZ1h+Q14w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q22Dw-00FQh9-0F; Thu, 25 May 2023 04:05:12 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q22Dt-00FQgD-2L for linux-arm-kernel@bombadil.infradead.org; Thu, 25 May 2023 04:05:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+Rcg59tq5Dl+6L+r8l6uwmuQm/aS0R/EBEonRbKOuco=; b=Vpkjy/zPqLAbxZf6ITNl+lGwjS nZwEanDG+mDgOewsGVfDM/uPyMY/vLDHgN9HUb32EbjT9dm9j8GWHEFIEcAD3KJ2S2APD70rT1aYq PWrA4DCdUJvyxk1XlvD5OJzRNU0z8XPOni5p290SZUGrL7h5SLcUG6a612QRkvOLbPzxkHVECZJoi 0jvFoo5OToVmjcTFuYzEG+Mfxmc7DGXTQs42v3hE2g2R0FTObPuNWgBYkdIvpgnjcZhq/5BdgcKX+ nGl5XTusfjuyS7BYl5GycouUlMSaW4ctAmtjq0dYdVQpAwD/mpB+4evqKKLpwU7OeEGOlX7nCHImW amBlZbHA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1q22Ds-00BpM4-4Y; Thu, 25 May 2023 04:05:08 +0000 Date: Thu, 25 May 2023 05:05:08 +0100 From: Matthew Wilcox To: Anshuman Khandual Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Catalin Marinas , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 09/36] arm64: Implement the new page table range API Message-ID: References: <20230315051444.3229621-1-willy@infradead.org> <20230315051444.3229621-10-willy@infradead.org> <592942c0-00dc-0317-0411-f9e17870fb11@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <592942c0-00dc-0317-0411-f9e17870fb11@arm.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 25, 2023 at 09:05:35AM +0530, Anshuman Khandual wrote: > > @@ -127,6 +127,8 @@ extern void copy_to_user_page(struct vm_area_struct *, struct page *, > > */ > > #define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE 1 > > extern void flush_dcache_page(struct page *); > > +void flush_dcache_folio(struct folio *); > > This is giving a checkpatch.pl warning > > WARNING: function definition argument 'struct folio *' should also have an identifier name > #36: FILE: arch/arm64/include/asm/cacheflush.h:130: > +void flush_dcache_folio(struct folio *); Yes, but checkpatch is *stupid*. Don't just follow tools blindly. How is naming the parameter here helping anyone? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel