From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B5CDC77B75 for ; Mon, 15 May 2023 06:43:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238221AbjEOGnk (ORCPT ); Mon, 15 May 2023 02:43:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238384AbjEOGnj (ORCPT ); Mon, 15 May 2023 02:43:39 -0400 Received: from fgw22-7.mail.saunalahti.fi (fgw22-7.mail.saunalahti.fi [62.142.5.83]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBCC9187 for ; Sun, 14 May 2023 23:43:35 -0700 (PDT) Received: from localhost (88-113-26-95.elisa-laajakaista.fi [88.113.26.95]) by fgw22.mail.saunalahti.fi (Halon) with ESMTP id cb35f6d5-f2eb-11ed-a9de-005056bdf889; Mon, 15 May 2023 09:43:27 +0300 (EEST) From: andy.shevchenko@gmail.com Date: Mon, 15 May 2023 09:43:25 +0300 To: Chris Packham Cc: Johan Hovold , "linus.walleij@linaro.org" , "brgl@bgdev.pl" , "andy.shevchenko@gmail.com" , "maz@kernel.org" , Ben Brown , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] gpiolib: Avoid side effects in gpio_is_visible() Message-ID: References: <20230512042806.3438373-1-chris.packham@alliedtelesis.co.nz> <2265adee-e003-08ae-e66d-fb41bdd79122@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2265adee-e003-08ae-e66d-fb41bdd79122@alliedtelesis.co.nz> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Sun, May 14, 2023 at 09:57:58PM +0000, Chris Packham kirjoitti: > On 12/05/23 19:24, Johan Hovold wrote: > > On Fri, May 12, 2023 at 04:28:06PM +1200, Chris Packham wrote: ... > > You need a better explanation as to why this is an issue. What does the > > warning look like for example? > > Ironically I had that in my first attempt to address the issue but was > told it was too much detail. So now I've gone too far the other way. > I'll include it in the response I'm about to send to LinusW. You have been (implicitly) told to reduce the scope of the details to have the only important ones, removing the traceback completely wasn't on the table. Citation: "Besides the very noisy traceback in the commit message (read https://kernel.org/doc/html/latest/process/submitting-patches.html#backtraces-in-commit-messages)" -- With Best Regards, Andy Shevchenko