From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEE91C7EE23 for ; Thu, 18 May 2023 16:48:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229697AbjERQs3 (ORCPT ); Thu, 18 May 2023 12:48:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229599AbjERQs1 (ORCPT ); Thu, 18 May 2023 12:48:27 -0400 Received: from out-45.mta0.migadu.com (out-45.mta0.migadu.com [91.218.175.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E616410E for ; Thu, 18 May 2023 09:48:25 -0700 (PDT) Date: Thu, 18 May 2023 12:48:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1684428504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1BJyFti2GSK6Ojcdhf1oqrHvjDqy4qKVqOaagfZXbM8=; b=B69OOOf99KKPTXqHA+bgu5GeyBKcn9r6JhoMGiKzX+giLnBWWwnzh2gd+oX0gtR1U9F5N3 JPdn5RZdQDHj93zYae1uGFPgQWS+XGqALy1GJDVdowHGLeilE//EZ5Cm/Sanj+u2fymPxM e/NCrNvkFDq3i1jNiBH71I5vS36UZ9Q= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Song Liu Cc: Mike Rapoport , linux-mm@kvack.org, Andrew Morton , Dave Hansen , Peter Zijlstra , Rick Edgecombe , Thomas Gleixner , Vlastimil Babka , linux-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [RFC PATCH 1/5] mm: intorduce __GFP_UNMAPPED and unmapped_alloc() Message-ID: References: <20230308094106.227365-1-rppt@kernel.org> <20230308094106.227365-2-rppt@kernel.org> <20230518152354.GD4967@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 18, 2023 at 09:33:20AM -0700, Song Liu wrote: > I am working on patches based on the discussion in [1]. I am planning to > send v1 for review in a week or so. Hey Song, I was reviewing that thread too, Are you taking a different approach based on Thomas's feedback? I think he had some fair points in that thread. My own feeling is that the buddy allocator is our tool for allocating larger variable sized physically contiguous allocations, so I'd like to see something based on that - I think we could do a hybrid buddy/slab allocator approach, like we have for regular memory allocations. I started on a slab allocator for executable memory allocations the other day (very minimal, but tested it for bcachefs and it works). But I'd love to hear more about your current approach as well. Cheers, Kent