From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1D47C7EE23 for ; Tue, 23 May 2023 06:37:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231730AbjEWGhJ (ORCPT ); Tue, 23 May 2023 02:37:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229606AbjEWGhJ (ORCPT ); Tue, 23 May 2023 02:37:09 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A3E9100 for ; Mon, 22 May 2023 23:37:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gDUysVOVsaPyDTtVUoUqBYPUK0ngxjXHLWGMN3f8LyM=; b=QgrDA6u1rZ2kjiqWSMp4YbdVpj MpQQDF+cfg7KqyZ9UzFSPXIy3mvdkvGifqxVUelJnF4KwqqrExYj+ZUHtCy6/W22Er5drPNyhHOzH KtX0etTH7nf9KpQT6GRhuT/Lq7AUu5cdpezTVkYhQbfvrEG59bINTLE3OVVmqG1DlPepiwKonGpLL 1Cv0Vyy42SXPaMGFLoPR8SF9GiQuhlZfbN2NbE+QfWmdYmTpFTBejV3d/OtYZdZ4tPDRkQwBRd1Hb oacVKKQ1h7FJV5Azmo0y3vCFrZNcml/9V+3ihXYoCZuMMpVWBWlYzsiFdyO8F7PeY4sOIKktC/GH+ aIYcQFlw==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q1Ldq-0095i5-05; Tue, 23 May 2023 06:37:06 +0000 Date: Mon, 22 May 2023 23:37:06 -0700 From: Christoph Hellwig To: Shiwu Zhang Cc: amd-gfx@lists.freedesktop.org, linux-pci@vger.kernel.org, bhelgaas@google.com Subject: Re: [PATCH] drm/amdgpu: add the accelerator pcie class Message-ID: References: <20230523040232.21756-1-shiwu.zhang@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230523040232.21756-1-shiwu.zhang@amd.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, May 23, 2023 at 12:02:32PM +0800, Shiwu Zhang wrote: > + { PCI_DEVICE(0x1002, PCI_ANY_ID), > + .class = PCI_CLASS_ACCELERATOR_PROCESSING << 8, > + .class_mask = 0xffffff, > + .driver_data = CHIP_IP_DISCOVERY }, Probing for every single device of a given class for a single vendor to a driver is just fundamentaly wrong. Please list the actual IDs that the driver can handle. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0AF5C7EE26 for ; Tue, 23 May 2023 09:25:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6108E10E415; Tue, 23 May 2023 09:25:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by gabe.freedesktop.org (Postfix) with ESMTPS id C6FBF10E3D4 for ; Tue, 23 May 2023 06:37:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gDUysVOVsaPyDTtVUoUqBYPUK0ngxjXHLWGMN3f8LyM=; b=QgrDA6u1rZ2kjiqWSMp4YbdVpj MpQQDF+cfg7KqyZ9UzFSPXIy3mvdkvGifqxVUelJnF4KwqqrExYj+ZUHtCy6/W22Er5drPNyhHOzH KtX0etTH7nf9KpQT6GRhuT/Lq7AUu5cdpezTVkYhQbfvrEG59bINTLE3OVVmqG1DlPepiwKonGpLL 1Cv0Vyy42SXPaMGFLoPR8SF9GiQuhlZfbN2NbE+QfWmdYmTpFTBejV3d/OtYZdZ4tPDRkQwBRd1Hb oacVKKQ1h7FJV5Azmo0y3vCFrZNcml/9V+3ihXYoCZuMMpVWBWlYzsiFdyO8F7PeY4sOIKktC/GH+ aIYcQFlw==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q1Ldq-0095i5-05; Tue, 23 May 2023 06:37:06 +0000 Date: Mon, 22 May 2023 23:37:06 -0700 From: Christoph Hellwig To: Shiwu Zhang Subject: Re: [PATCH] drm/amdgpu: add the accelerator pcie class Message-ID: References: <20230523040232.21756-1-shiwu.zhang@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230523040232.21756-1-shiwu.zhang@amd.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Mailman-Approved-At: Tue, 23 May 2023 09:25:02 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bhelgaas@google.com, linux-pci@vger.kernel.org, amd-gfx@lists.freedesktop.org Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Tue, May 23, 2023 at 12:02:32PM +0800, Shiwu Zhang wrote: > + { PCI_DEVICE(0x1002, PCI_ANY_ID), > + .class = PCI_CLASS_ACCELERATOR_PROCESSING << 8, > + .class_mask = 0xffffff, > + .driver_data = CHIP_IP_DISCOVERY }, Probing for every single device of a given class for a single vendor to a driver is just fundamentaly wrong. Please list the actual IDs that the driver can handle.