From: Francesco Dolcini <francesco@dolcini.it>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Francesco Dolcini <francesco@dolcini.it>,
Vignesh Raghavendra <vigneshr@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Lukas Wunner <lukas@wunner.de>
Subject: Re: DT checker RS485 unevaluated property, 8250 OMAP UART
Date: Tue, 30 May 2023 15:24:22 +0200 [thread overview]
Message-ID: <ZHX5Bm5pRUebY0Xu@francesco-nb.int.toradex.com> (raw)
In-Reply-To: <cd06b0f4-fb86-cc16-5a80-b4896b5c4cd9@linaro.org>
On Tue, May 30, 2023 at 01:38:42PM +0200, Krzysztof Kozlowski wrote:
> On 30/05/2023 12:13, Francesco Dolcini wrote:
> > On Sat, May 27, 2023 at 11:49:17AM +0530, Vignesh Raghavendra wrote:
> >> On 19/05/23 9:39 pm, Francesco Dolcini wrote:
> >>> I would be inclined to send the following patch, do you agree?
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/serial/8250_omap.yaml b/Documentation/devicetree/bindings/serial/8250_omap.yaml
> >>> index eb3488d8f9ee..e634e98aa994 100644
> >>> --- a/Documentation/devicetree/bindings/serial/8250_omap.yaml
> >>> +++ b/Documentation/devicetree/bindings/serial/8250_omap.yaml
> >>> @@ -70,6 +70,7 @@ properties:
> >>> dsr-gpios: true
> >>> rng-gpios: true
> >>> dcd-gpios: true
> >>> + rs485-rts-active-low: true
> >>
> >> I believe you mean rs485-rts-active-high here
> > whoops, yes of course.
>
> Yes, with a Fixes tag.
Ack
> >>> rts-gpio: true
> >>> power-domains: true
> >>> clock-frequency: true
> >>>
> >>> [1] https://lore.kernel.org/all/ZBItlBhzo+YETcJO@francesco-nb.int.toradex.com/
> >>>
> >>
> >> Also, I hope you are using 8250_ompa.c and not omap-serial.c for newer
> >> designs. omap-serial.c is mostly there to support legacy SoCs and not to
> >> be used with K3 SoCs.
> >
> > Thanks for this head-up. This confused myself, while the issue I
> > reported here is real, it does affect only omap-serial.c. In my case I
> > am using 8250_omap.c and I can just omit the property from the DTS as
> > generally expected!
>
> OK. Are you going send a fix for original issue?
I'll do it, thanks!
prev parent reply other threads:[~2023-05-30 13:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 16:09 DT checker RS485 unevaluated property, 8250 OMAP UART Francesco Dolcini
2023-05-27 6:19 ` Vignesh Raghavendra
2023-05-30 10:13 ` Francesco Dolcini
2023-05-30 11:38 ` Krzysztof Kozlowski
2023-05-30 13:24 ` Francesco Dolcini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHX5Bm5pRUebY0Xu@francesco-nb.int.toradex.com \
--to=francesco@dolcini.it \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.