From: Bjorn Helgaas <helgaas@kernel.org>
To: Igor Mammedov <imammedo@redhat.com>
Cc: linux-kernel@vger.kernel.org, mst@redhat.com, rafael@kernel.org,
lenb@kernel.org, bhelgaas@google.com, linux-acpi@vger.kernel.org,
linux-pci@vger.kernel.org, mika.westerberg@linux.intel.com
Subject: Re: [PATCH v2] PCI: acpiphp: Reassign resources on bridge if necessary
Date: Tue, 30 May 2023 12:12:44 -0500 [thread overview]
Message-ID: <ZHYujEM3o6iWIB1B@bhelgaas> (raw)
In-Reply-To: <20230424191557.2464760-1-imammedo@redhat.com>
On Mon, Apr 24, 2023 at 09:15:57PM +0200, Igor Mammedov wrote:
> When using ACPI PCI hotplug, hotplugging a device with
> large BARs may fail if bridge windows programmed by
> firmware are not large enough.
>
> Reproducer:
> $ qemu-kvm -monitor stdio -M q35 -m 4G \
> -global ICH9-LPC.acpi-pci-hotplug-with-bridge-support=on \
> -device id=rp1,pcie-root-port,bus=pcie.0,chassis=4 \
> disk_image
>
> wait till linux guest boots, then hotplug device
> (qemu) device_add qxl,bus=rp1
>
> hotplug on guest side fails with:
> pci 0000:01:00.0: [1b36:0100] type 00 class 0x038000
> pci 0000:01:00.0: reg 0x10: [mem 0x00000000-0x03ffffff]
> pci 0000:01:00.0: reg 0x14: [mem 0x00000000-0x03ffffff]
> pci 0000:01:00.0: reg 0x18: [mem 0x00000000-0x00001fff]
> pci 0000:01:00.0: reg 0x1c: [io 0x0000-0x001f]
> pci 0000:01:00.0: BAR 0: no space for [mem size 0x04000000]
> pci 0000:01:00.0: BAR 0: failed to assign [mem size 0x04000000]
> pci 0000:01:00.0: BAR 1: no space for [mem size 0x04000000]
> pci 0000:01:00.0: BAR 1: failed to assign [mem size 0x04000000]
> pci 0000:01:00.0: BAR 2: assigned [mem 0xfe800000-0xfe801fff]
> pci 0000:01:00.0: BAR 3: assigned [io 0x1000-0x101f]
> qxl 0000:01:00.0: enabling device (0000 -> 0003)
Ugh, I just noticed that we turned on PCI_COMMAND_MEMORY even though
BARs 0 and 1 haven't been assigned. How did that happen? It looks
like pci_enable_resources() checks for that, but there must be a hole
somewhere.
> Unable to create vram_mapping
> qxl: probe of 0000:01:00.0 failed with error -12
next prev parent reply other threads:[~2023-05-30 17:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 19:15 [PATCH v2] PCI: acpiphp: Reassign resources on bridge if necessary Igor Mammedov
2023-04-24 20:47 ` Michael S. Tsirkin
2023-05-09 12:44 ` Igor Mammedov
2023-05-22 11:06 ` Igor Mammedov
2023-05-22 11:52 ` Rafael J. Wysocki
2023-05-22 19:21 ` Michael S. Tsirkin
2023-05-22 21:51 ` Bjorn Helgaas
2023-05-22 21:54 ` Michael S. Tsirkin
2023-05-22 21:55 ` Rafael J. Wysocki
2023-05-23 15:42 ` Bjorn Helgaas
2023-05-30 17:12 ` Bjorn Helgaas [this message]
2023-05-30 18:16 ` Michael S. Tsirkin
2023-05-30 18:55 ` Bjorn Helgaas
2023-05-30 19:06 ` Michael S. Tsirkin
2023-05-31 15:22 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHYujEM3o6iWIB1B@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=imammedo@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mst@redhat.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.