From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CA63C7EE29 for ; Thu, 1 Jun 2023 21:42:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232834AbjFAVm4 (ORCPT ); Thu, 1 Jun 2023 17:42:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232430AbjFAVmy (ORCPT ); Thu, 1 Jun 2023 17:42:54 -0400 Received: from fgw21-7.mail.saunalahti.fi (fgw21-7.mail.saunalahti.fi [62.142.5.82]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32A5F197 for ; Thu, 1 Jun 2023 14:42:53 -0700 (PDT) Received: from localhost (88-113-26-95.elisa-laajakaista.fi [88.113.26.95]) by fgw21.mail.saunalahti.fi (Halon) with ESMTP id 41dcce44-00c5-11ee-abf4-005056bdd08f; Fri, 02 Jun 2023 00:42:51 +0300 (EEST) From: andy.shevchenko@gmail.com Date: Fri, 2 Jun 2023 00:42:50 +0300 To: Krzysztof Kozlowski Cc: Linus Walleij , Bjorn Andersson , Andy Gross , Konrad Dybcio , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 1/8] pinctrl: qcom: qdf2xxx: drop ACPI_PTR Message-ID: References: <20230601152026.1182648-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230601152026.1182648-1-krzysztof.kozlowski@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Thu, Jun 01, 2023 at 05:20:19PM +0200, Krzysztof Kozlowski kirjoitti: > Driver can bind only via ACPI matching and acpi_device_id is there > unconditionally, so drop useless ACPI_PTR() macro. With this acpi.h becomes unused and has to be replaced with (AFAICT) property.h mod_devicetable.h (maybe others, but I haven't checked deeply) With that, Reviewed-by: Andy Shevchenko > Signed-off-by: Krzysztof Kozlowski > --- > drivers/pinctrl/qcom/pinctrl-qdf2xxx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c b/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c > index b0f1b3dc6831..b5808fcfb13c 100644 > --- a/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c > +++ b/drivers/pinctrl/qcom/pinctrl-qdf2xxx.c > @@ -142,7 +142,7 @@ MODULE_DEVICE_TABLE(acpi, qdf2xxx_acpi_ids); > static struct platform_driver qdf2xxx_pinctrl_driver = { > .driver = { > .name = "qdf2xxx-pinctrl", > - .acpi_match_table = ACPI_PTR(qdf2xxx_acpi_ids), > + .acpi_match_table = qdf2xxx_acpi_ids, > }, > .probe = qdf2xxx_pinctrl_probe, > .remove = msm_pinctrl_remove, > -- > 2.34.1 > -- With Best Regards, Andy Shevchenko