From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EC69C7EE24 for ; Fri, 2 Jun 2023 21:37:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236536AbjFBVhj (ORCPT ); Fri, 2 Jun 2023 17:37:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236246AbjFBVhi (ORCPT ); Fri, 2 Jun 2023 17:37:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FEC51B5; Fri, 2 Jun 2023 14:37:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CE6BA61ED3; Fri, 2 Jun 2023 21:37:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC9ACC433D2; Fri, 2 Jun 2023 21:37:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685741856; bh=1FcV/MmMD469O1FQZ7KzmQXuisSwf/qS6Cx5HeBprRU=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=G1SmzjFN1fwdTVy/JX+tcplLxTUjUTUxEYFqWy36jkRCY8CssArfmtY6hLyIJ+eEl Bsh5696NyIdCrSPjt2TUjM0RFMQlO0wpybcSRG6UraTxRxGXt4VITakX9oYodhFdyh rfKi2TNtnhoeQ1oqNFE8gfgG28MlI7yJP3b9ig8g9v5cVOy5x4enFGWy4eo4eOhL/D t0558CmqNSsrs8MIMUgAirdzk2AkEhL549O1T9Ri7JyW34yBjFQ+ghpcI6WWPzIPLi /OsVnvTW9zVJhYn0W1r/GVQ7YvbUz4DhG+Daqqs+lJJtWaWxaXh3OmZq4hyGtUOW+P FAVYBtTinWEBw== Date: Fri, 2 Jun 2023 16:37:34 -0500 From: Bjorn Helgaas To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Bjorn Helgaas , Thomas Petazzoni , Pali =?iso-8859-1?Q?Roh=E1r?= , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Joyce Ooi , Florian Fainelli , Jim Quinlan , Nicolas Saenz Julienne , Vignesh Raghavendra , Tom Joseph , Shawn Guo , Rahul Tanwar , Manivannan Sadhasivam , Thierry Reding , Jonathan Hunter , Serge Semin , Vidya Sagar , Jisheng Zhang , Miaoqian Lin , Ray Jui , Scott Branden , Ryder Lee , Jianjun Wang , Matthias Brugger , Sergio Paracuellos , Shawn Lin , Heiko Stuebner , Toan Le , Rob Herring , linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, Broadcom internal kernel review list , linux-rpi-kernel@lists.infradead.org, kernel@pengutronix.de, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno Subject: Re: [PATCH 00/15] PCI: Convert to platform remove callback returning void Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230530140742.ebbrxmpieuphbmz3@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Tue, May 30, 2023 at 04:07:42PM +0200, Uwe Kleine-König wrote: > Hello Bjorn, > > On Tue, Mar 21, 2023 at 08:31:53PM +0100, Uwe Kleine-König wrote: > > this series adapts the platform drivers below drivers/pci to use the > > .remove_new() callback. Compared to the traditional .remove() callback > > .remove_new() returns no value. This is a good thing because the driver core > > doesn't (and cannot) cope for errors during remove. The only effect of a > > non-zero return value in .remove() is that the driver core emits a warning. The > > device is removed anyhow and an early return from .remove() usually yields a > > resource leak. > > > > By changing the remove callback to return void driver authors cannot > > reasonably assume any more that there is some kind of cleanup later. > > > > All drivers were easy to convert as they all returned zero in their > > remove callback. Only for iproc the conversion wasn't trivial, the other > > were converted using coccinelle. > > > > There are no interdependencies between these patches. So even if there > > are some concerns for individual patches, I ask you to apply the > > remaining set. Then I only have to care for the review feedback of the > > refused patches. (Having said that I don't expect any serious objection, > > just things like squashing or separating patches, or maybe I picked a > > wrong subject prefix.) > > These patches wait for application for quite some time now. They apply > just fine to v6.4-rc1 and next/master. Would be great to get them in > during the next merge window and ideally give them some time in next > before. Thanks, these seem fine to me, and Lorenzo normally takes care of drivers/pci/controller/. Lorenzo, if it's easier to have me apply them, that's fine, too, just let me know. The only tweaks I would make would be: PCI: j721e: Convert to platform remove callback returning void PCI: dwc: Convert to platform remove callback returning void to match the git history. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE653C77B7A for ; Fri, 2 Jun 2023 21:37:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=UuLzCsiOJAaX7aES7AUQ1tpcBKdt8oCN/cYaeWOoBTo=; b=17PYKwC2bCKV2d X8sNSe63OGxzBHXGSwFIxgukYf01INgVdoSKJZg2jCNBf+s57Tm3hoJ+YKv06zd3aGy7c+OrJtEJB 7p0MCXLXAS9x858wlR4bvZAgjpiUJOdj0hh6l5SjfqXykWLe5Ayc+U2aaZHsMUQixoFxISg2liPN2 jYoh2cUuVRdm6iXAEncAMQEgjVKz+HBSD2e0my1nxaRH1ZH0m+6PZxe1No6wh8VookdC2k6y32TQO IpMYTB8wYLuGAxc+WS2jz8pl4AcxZe9lzmHYHizpFDYOLGfIgqWwR183Yyj7PHmJ1W3zIODXSQi4+ CDZptlDcrDUCGXvVxQ7A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q5CSs-007xbE-06; Fri, 02 Jun 2023 21:37:42 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q5CSo-007xZy-0Q; Fri, 02 Jun 2023 21:37:39 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CDE4B61E79; Fri, 2 Jun 2023 21:37:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC9ACC433D2; Fri, 2 Jun 2023 21:37:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685741856; bh=1FcV/MmMD469O1FQZ7KzmQXuisSwf/qS6Cx5HeBprRU=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=G1SmzjFN1fwdTVy/JX+tcplLxTUjUTUxEYFqWy36jkRCY8CssArfmtY6hLyIJ+eEl Bsh5696NyIdCrSPjt2TUjM0RFMQlO0wpybcSRG6UraTxRxGXt4VITakX9oYodhFdyh rfKi2TNtnhoeQ1oqNFE8gfgG28MlI7yJP3b9ig8g9v5cVOy5x4enFGWy4eo4eOhL/D t0558CmqNSsrs8MIMUgAirdzk2AkEhL549O1T9Ri7JyW34yBjFQ+ghpcI6WWPzIPLi /OsVnvTW9zVJhYn0W1r/GVQ7YvbUz4DhG+Daqqs+lJJtWaWxaXh3OmZq4hyGtUOW+P FAVYBtTinWEBw== Date: Fri, 2 Jun 2023 16:37:34 -0500 From: Bjorn Helgaas To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Bjorn Helgaas , Thomas Petazzoni , Pali =?iso-8859-1?Q?Roh=E1r?= , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Joyce Ooi , Florian Fainelli , Jim Quinlan , Nicolas Saenz Julienne , Vignesh Raghavendra , Tom Joseph , Shawn Guo , Rahul Tanwar , Manivannan Sadhasivam , Thierry Reding , Jonathan Hunter , Serge Semin , Vidya Sagar , Jisheng Zhang , Miaoqian Lin , Ray Jui , Scott Branden , Ryder Lee , Jianjun Wang , Matthias Brugger , Sergio Paracuellos , Shawn Lin , Heiko Stuebner , Toan Le , Rob Herring , linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, Broadcom internal kernel review list , linux-rpi-kernel@lists.infradead.org, kernel@pengutronix.de, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno Subject: Re: [PATCH 00/15] PCI: Convert to platform remove callback returning void Message-ID: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230530140742.ebbrxmpieuphbmz3@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230602_143738_292462_77F1B977 X-CRM114-Status: GOOD ( 23.23 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Tue, May 30, 2023 at 04:07:42PM +0200, Uwe Kleine-K=F6nig wrote: > Hello Bjorn, > = > On Tue, Mar 21, 2023 at 08:31:53PM +0100, Uwe Kleine-K=F6nig wrote: > > this series adapts the platform drivers below drivers/pci to use the > > .remove_new() callback. Compared to the traditional .remove() callback > > .remove_new() returns no value. This is a good thing because the driver= core > > doesn't (and cannot) cope for errors during remove. The only effect of a > > non-zero return value in .remove() is that the driver core emits a warn= ing. The > > device is removed anyhow and an early return from .remove() usually yie= lds a > > resource leak. > > = > > By changing the remove callback to return void driver authors cannot > > reasonably assume any more that there is some kind of cleanup later. > > = > > All drivers were easy to convert as they all returned zero in their > > remove callback. Only for iproc the conversion wasn't trivial, the other > > were converted using coccinelle. > > = > > There are no interdependencies between these patches. So even if there > > are some concerns for individual patches, I ask you to apply the > > remaining set. Then I only have to care for the review feedback of the > > refused patches. (Having said that I don't expect any serious objection, > > just things like squashing or separating patches, or maybe I picked a > > wrong subject prefix.) > = > These patches wait for application for quite some time now. They apply > just fine to v6.4-rc1 and next/master. Would be great to get them in > during the next merge window and ideally give them some time in next > before. Thanks, these seem fine to me, and Lorenzo normally takes care of drivers/pci/controller/. Lorenzo, if it's easier to have me apply them, that's fine, too, just let me know. The only tweaks I would make would be: PCI: j721e: Convert to platform remove callback returning void PCI: dwc: Convert to platform remove callback returning void to match the git history. _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1730DC7EE2C for ; Fri, 2 Jun 2023 21:38:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=KGGyjp02M+NeEuJoPBk+6mHeULR4fNkR/3tDPyTjj9k=; b=wBf91y8ZQ23l/Z mitJf6X566eXAQT+44+IK98fDQsZabHrQcYsEO1+CCsPFFJVBegOhvPzZEWHVPnmy3UC7tdu1vg+3 O3AelDy3P5gbOLurHRf8TnL5QCyD5Jl2GQY4WIq44TSAM79FScdPhrba6VDfzkdEc+FKsaoYjgK/L bpZgw10sUOMpgysU8NwOnV5o95e3NG2ZGbZamY8xwhbegiin2dj4G2voU3qtoBhmyPevPxG4vosJW /C3RcqcsqwLY8g9bZBSh4sEUI3pAr+EYL1ERrRTLYvywLftqNQRiNslTaImdu9s/IsP/n0Kucdfij 5LxaUc9QYtz0znvsJLEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q5CSr-007xar-0A; Fri, 02 Jun 2023 21:37:41 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q5CSo-007xZy-0Q; Fri, 02 Jun 2023 21:37:39 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CDE4B61E79; Fri, 2 Jun 2023 21:37:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC9ACC433D2; Fri, 2 Jun 2023 21:37:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685741856; bh=1FcV/MmMD469O1FQZ7KzmQXuisSwf/qS6Cx5HeBprRU=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=G1SmzjFN1fwdTVy/JX+tcplLxTUjUTUxEYFqWy36jkRCY8CssArfmtY6hLyIJ+eEl Bsh5696NyIdCrSPjt2TUjM0RFMQlO0wpybcSRG6UraTxRxGXt4VITakX9oYodhFdyh rfKi2TNtnhoeQ1oqNFE8gfgG28MlI7yJP3b9ig8g9v5cVOy5x4enFGWy4eo4eOhL/D t0558CmqNSsrs8MIMUgAirdzk2AkEhL549O1T9Ri7JyW34yBjFQ+ghpcI6WWPzIPLi /OsVnvTW9zVJhYn0W1r/GVQ7YvbUz4DhG+Daqqs+lJJtWaWxaXh3OmZq4hyGtUOW+P FAVYBtTinWEBw== Date: Fri, 2 Jun 2023 16:37:34 -0500 From: Bjorn Helgaas To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Bjorn Helgaas , Thomas Petazzoni , Pali =?iso-8859-1?Q?Roh=E1r?= , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Joyce Ooi , Florian Fainelli , Jim Quinlan , Nicolas Saenz Julienne , Vignesh Raghavendra , Tom Joseph , Shawn Guo , Rahul Tanwar , Manivannan Sadhasivam , Thierry Reding , Jonathan Hunter , Serge Semin , Vidya Sagar , Jisheng Zhang , Miaoqian Lin , Ray Jui , Scott Branden , Ryder Lee , Jianjun Wang , Matthias Brugger , Sergio Paracuellos , Shawn Lin , Heiko Stuebner , Toan Le , Rob Herring , linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, Broadcom internal kernel review list , linux-rpi-kernel@lists.infradead.org, kernel@pengutronix.de, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno Subject: Re: [PATCH 00/15] PCI: Convert to platform remove callback returning void Message-ID: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230530140742.ebbrxmpieuphbmz3@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230602_143738_292462_77F1B977 X-CRM114-Status: GOOD ( 23.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 30, 2023 at 04:07:42PM +0200, Uwe Kleine-K=F6nig wrote: > Hello Bjorn, > = > On Tue, Mar 21, 2023 at 08:31:53PM +0100, Uwe Kleine-K=F6nig wrote: > > this series adapts the platform drivers below drivers/pci to use the > > .remove_new() callback. Compared to the traditional .remove() callback > > .remove_new() returns no value. This is a good thing because the driver= core > > doesn't (and cannot) cope for errors during remove. The only effect of a > > non-zero return value in .remove() is that the driver core emits a warn= ing. The > > device is removed anyhow and an early return from .remove() usually yie= lds a > > resource leak. > > = > > By changing the remove callback to return void driver authors cannot > > reasonably assume any more that there is some kind of cleanup later. > > = > > All drivers were easy to convert as they all returned zero in their > > remove callback. Only for iproc the conversion wasn't trivial, the other > > were converted using coccinelle. > > = > > There are no interdependencies between these patches. So even if there > > are some concerns for individual patches, I ask you to apply the > > remaining set. Then I only have to care for the review feedback of the > > refused patches. (Having said that I don't expect any serious objection, > > just things like squashing or separating patches, or maybe I picked a > > wrong subject prefix.) > = > These patches wait for application for quite some time now. They apply > just fine to v6.4-rc1 and next/master. Would be great to get them in > during the next merge window and ideally give them some time in next > before. Thanks, these seem fine to me, and Lorenzo normally takes care of drivers/pci/controller/. Lorenzo, if it's easier to have me apply them, that's fine, too, just let me know. The only tweaks I would make would be: PCI: j721e: Convert to platform remove callback returning void PCI: dwc: Convert to platform remove callback returning void to match the git history. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel