From: Frank Li <Frank.li@nxp.com>
To: Joy Zou <joy.zou@nxp.com>
Cc: "vkoul@kernel.org" <vkoul@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Peng Fan <peng.fan@nxp.com>, Shenwei Wang <shenwei.wang@nxp.com>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
Aisheng Dong <aisheng.dong@nxp.com>
Subject: Re: [PATCH v3 11/12] dmaengine: fsl-edma: integrate v3 support
Date: Fri, 2 Jun 2023 17:39:40 -0400 [thread overview]
Message-ID: <ZHphnNw54dkRgk9E@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <AM6PR04MB59252F1C1BE15C61911C60EEE14EA@AM6PR04MB5925.eurprd04.prod.outlook.com>
On Fri, Jun 02, 2023 at 09:41:19AM +0000, Joy Zou wrote:
> > + .chreg_off = EDMA_TCD,
> > + .chreg_space_sz = sizeof(struct fsl_edma_hw_tcd),
> > .flags = FSL_EDMA_DRV_HAS_DMACLK | FSL_EDMA_DRV_CONFIG32,
> > .setup_irq = fsl_edma2_irq_init,
> > };
> >
> > +static struct fsl_edma_drvdata imx8qm_data = {
> > + .flags = FSL_EDMA_DRV_HAS_CHMUX | FSL_EDMA_DRV_HAS_PD
> > + | FSL_EDMA_DRV_EDMA3,
> > + .chreg_space_sz = 0x10000,
> > + .chreg_off = 0x10000,
> > + .setup_irq = fsl_edma3_irq_init,
> > +};
> Hi frank,
> There are many dma controllers in imx8qm. But not all dma controllers support ch-mux.
> In addition, Imx93 edma v3 also doesn't support ch-mux.
> You can confirm with RM. Can we use the dts node property instead of drvdata flags?
> BR
> Joy Zou
> > +
I tested all i.mx8qxp have not ch-mux. did you find any one have ch-mux at imx8qm?
I will remove FSL_EDMA_DRV_HAS_CHMUX at imx8qm and imx93 at next version.
It works just because dmamuxs is 0. ch-mux register have not written at all.
we have compatible string, which are enough to distinguish the difference.
not neccesary to add property for that.
Frank Li
> > --
> > 2.34.1
>
next prev parent reply other threads:[~2023-06-02 21:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 14:40 [PATCH v3 00/12] dmaengine: edma: add freescale edma v3 support Frank Li
2023-06-01 14:40 ` [PATCH v3 01/12] dmaengine: fsl-edma: clean up EXPORT_SYMBOL_GPL in fsl-edma-common.c Frank Li
2023-06-01 14:40 ` [PATCH v3 02/12] dmaengine: fsl-edma: clean up fsl_edma_irq_exit() Frank Li
2023-06-01 14:40 ` [PATCH v3 03/12] dmaengine: fsl-edma: transition from bool fields to bitmask flags in drvdata Frank Li
2023-06-01 14:40 ` [PATCH v3 04/12] dmaengine: fsl-edma: Remove enum edma_version Frank Li
2023-06-01 14:41 ` [PATCH v3 05/12] dmaengine: fsl-edma: move common IRQ handler to common.c Frank Li
2023-06-01 14:41 ` [PATCH v3 06/12] dmaengine: fsl-edma: simply ATTR_DSIZE and ATTR_SSIZE by using ffs() Frank Li
2023-06-01 14:41 ` [PATCH v3 07/12] dmaengine: fsl-edma: refactor using devm_clk_get_enabled Frank Li
2023-06-01 14:41 ` [PATCH v3 08/12] dmaengine: fsl-edma: move clearing of register interrupt into setup_irq function Frank Li
2023-06-01 14:41 ` [PATCH v3 09/12] dmaengine: fsl-edma: refactor chan_name setup and safety Frank Li
2023-06-01 14:41 ` [PATCH v3 10/12] dmaengine: fsl-edma: move tcd into struct fsl_dma_chan Frank Li
2023-06-01 14:41 ` [PATCH v3 11/12] dmaengine: fsl-edma: integrate v3 support Frank Li
2023-06-02 9:41 ` Joy Zou
2023-06-02 21:39 ` Frank Li [this message]
2023-06-01 14:41 ` [PATCH v3 12/12] dt-bindings: fsl-dma: fsl-edma: add edma3 compatible string Frank Li
2023-06-02 8:30 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHphnNw54dkRgk9E@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=joy.zou@nxp.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=shenwei.wang@nxp.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.