From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74862EB64D7 for ; Wed, 28 Jun 2023 10:01:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oCk+078F19/sFZ/6iBaffMOVbtvyZX2ofahkkGzB1SA=; b=Mh13Vq/+bxcPKx REypu26ObFiTDWq/vRvZnwi7FJa5KEZ7GYNn17KTyd5MX0DVd/dk9Ixj+C0jc4YBl0PQxqDAonaUa IbvbWb8mSHhgHeoBakercpr+KsM7uX3cUa07jULvElTsz4NkeKJywPv5pOmpIdOY0eu4qcv/HAaEG qZHPoHTC/2AO25Lng0j+5Cwc/D7OWw2kXofBNV836ZH/KprW+95Jdm7o/TYYIPRYgqnBd/saxvL2G 2UMGuSDn0L4MceGg7s41H3X0RpYCQfK/XjS+fvNbNtzWB01tm1O5r4qO/NmZav1C8/3WG4HS7gmbi em1aQ3Sa+xI4Wb1B276A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qERzP-00FJ6p-2k; Wed, 28 Jun 2023 10:01:31 +0000 Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qERzM-00FJ5n-2B for linux-riscv@lists.infradead.org; Wed, 28 Jun 2023 10:01:30 +0000 Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-4f95bf5c493so7669041e87.3 for ; Wed, 28 Jun 2023 03:01:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1687946474; x=1690538474; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=ejpdHA8WxWWd1l59d/A+1U8uDQbHe+EInXg0gY9zi4g=; b=dZvJgVIXVWCBDL5aXGFxsJ5WPmhQgOeJAlYzfhXYBqZRMXc8ZosqV491wGpV9rwfXT ifQDH5Dakn53A1zYa+hu0PCVcBjx85Y6/pGFtusbYPL6Rx2lxZ7z40Jviu/V12KAEt5f OovlwEonF5PUNsLQ0j7raIByy/CI1zrBCRzn32YSr0JPrfVua6nV41dIHmybPwVqnmBj B+ktWhEcsO/3lBnj12kWtMd4xPB06qGyWjI6kb5tkRQKl4WmcxysASNTmy2N4ZEk+8FL bb3OkWJYNL01pKA9Pn8+CPMsW/OIkaS7zHKMejCnj+peNKHRUKoTX9LrDkXU58vze9Lb vx8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687946474; x=1690538474; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ejpdHA8WxWWd1l59d/A+1U8uDQbHe+EInXg0gY9zi4g=; b=kO0/ccLrlsVk53czwi2FTKQvtyZXBA+dSeUapM643XGF3ntgAm6cZ9CBFecYC3FsXD z8zI5UsQc0UmJ2eQPKadDEH+2iDY47PplhVi6+e6yrKrSMY7wX2LBjfBXEIpoTf70f3X MuTHFA5RKTtAUD3qHkUj/0mlS3s5PGIn7+bbB+edZwsSsB/tjpQqmYETIrNQ025sXEJd LGscdzq+MGMtMvK57PE9p8b6+tLaXzn2Ak6GBdyDeW/r3fQ1mjZCBY2yrZvNsv3AbqdH Pn1WPUFhoNrQNI83FNUKkMmE5jamu8pAGfAtNtCmEV/Me/LlVpgE1r/8uoy65vjF/EQr RnZA== X-Gm-Message-State: AC+VfDxDNx7M3l7+U5wj18AGh13cR9Z2KCRo/ZvZoj2pvFYuuDEqY0qV eDsUkhlkseFd6d0dibqAqhZ1yw== X-Google-Smtp-Source: ACHHUZ71Yv4hqMaxWIDwAYtnT7SHbWlkB9oKL4/KN0ocWZiXmvCj0cgNqI0Fj7mNTg6Mq0VXQQD+sA== X-Received: by 2002:a05:6512:3b82:b0:4fb:7be5:4870 with SMTP id g2-20020a0565123b8200b004fb7be54870mr5901035lfv.46.1687946473669; Wed, 28 Jun 2023 03:01:13 -0700 (PDT) Received: from vermeer ([2a01:cb1d:81a9:dd00:b570:b34c:ffd4:c805]) by smtp.gmail.com with ESMTPSA id 21-20020a05600c22d500b003f9cb3c8958sm16399566wmg.3.2023.06.28.03.01.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jun 2023 03:01:13 -0700 (PDT) Date: Wed, 28 Jun 2023 12:01:11 +0200 From: Samuel Ortiz To: Conor Dooley Cc: Evan Green , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-riscv@lists.infradead.org, "Hongren (Zenithal) Zheng" , linux@rivosinc.com, Conor Dooley , Andrew Jones , Heiko Stuebner , Anup Patel , linux-kernel@vger.kernel.org, Guo Ren , Atish Patra , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Jiatai He Subject: Re: [PATCH 1/3] RISC-V: add Bitmanip/Scalar Crypto parsing from DT Message-ID: References: <20230627143747.1599218-1-sameo@rivosinc.com> <20230627143747.1599218-2-sameo@rivosinc.com> <20230627-debating-twelve-da2c1ed60948@spud> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230627-debating-twelve-da2c1ed60948@spud> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230628_030128_741026_DD3BEAC0 X-CRM114-Status: GOOD ( 35.74 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gVHVlLCBKdW4gMjcsIDIwMjMgYXQgMDc6NDg6MTVQTSArMDEwMCwgQ29ub3IgRG9vbGV5IHdy b3RlOgo+IE9uIFR1ZSwgSnVuIDI3LCAyMDIzIGF0IDExOjE0OjMwQU0gLTA3MDAsIEV2YW4gR3Jl ZW4gd3JvdGU6Cj4gPiBPbiBUdWUsIEp1biAyNywgMjAyMyBhdCA3OjM44oCvQU0gU2FtdWVsIE9y dGl6IDxzYW1lb0ByaXZvc2luYy5jb20+IHdyb3RlOgo+ID4gPgo+ID4gPiBGcm9tOiAiSG9uZ3Jl biAoWmVuaXRoYWwpIFpoZW5nIiA8aUB6ZW5pdGhhbC5tZT4KPiA+ID4KPiA+ID4gVGhpcyBwYXRj aCBwYXJzZXMgWmIvWmsgcmVsYXRlZCBzdHJpbmcgZnJvbSBEVCBhbmQKPiAKPiAlcy9UaGlzIHBh dGNoLy8KPiAKPiA+ID4gb3V0cHV0IHRoZW0gaW4gY3B1aW5mbwo+ID4gPgo+ID4gPiBPbmUgdGhp bmcgd29ydGggbm90aW5nIGlzIHRoYXQgaWYgRFQgcHJvdmlkZXMgemssCj4gPiA+IGFsbCB6Ymti LCB6YmtjLCB6Ymt4IGFuZCB6a24sIHprciwgemt0IHdvdWxkIGJlIGVuYWJsZWQuCj4gCj4gUGxl YXNlIGV4cGxhaW4gd2h5IHRoaXMgaXMgb2theS4KPiAKPiA+ID4gTm90ZSB0aGF0IHprIGlzIGEg dmFsaWQgZXh0ZW5zaW9uIG5hbWUgYW5kIHRoZSBjdXJyZW50Cj4gPiA+IERUIGJpbmRpbmcgc3Bl YyBhbGxvd3MgdGhpcy4KPiA+ID4KPiA+ID4gVGhpcyBwYXRjaCBhbHNvIGNoYW5nZXMgdGhlIGxv Z2ljYWwgaWQgb2YKPiA+ID4gZXhpc3RpbmcgbXVsdGktbGV0dGVyIGV4dGVuc2lvbnMgYW5kIGFk ZHMgYSBzdGF0ZW1lbnQKPiA+ID4gdGhhdCBpbnN0ZWFkIG9mIGxvZ2ljYWwgaWQgY29tcGF0aWJp bGl0eSwgdGhlIG9yZGVyCj4gPiA+IGlzIG5lZWRlZC4KPiAKPiBEb2VzIGl0Pwo+IAo+ID4gPiBU aGVyZSBjdXJyZW50bHkgbGFja3MgYSBtZWNoYW5pc20gdG8gbWVyZ2UgdGhlbSB3aGVuCj4gPiA+ IHByb2R1Y2luZyBjcHVpbmZvLiBOYW1lbHkgaWYgeW91IHByb3ZpZGUgYSByaXNjdixpc2EKPiA+ ID4gInJ2NjRpbWFmZGNfemtfemtzIiwgdGhlIGNwdWluZm8gb3V0cHV0IHdvdWxkIGJlCj4gPiA+ ICJydjY0aW1hZmRjX3pia2JfemJrY196Ymt4X3prbmRfemtuZV96a25oX3prcl96a3NlZAo+ID4g PiBfemtzaF96a3QiCj4gCj4gSSB0aGluayB0aGlzIGlzIGZpbmUuCj4gCj4gUGxlYXNlIHJlLXdy YXAgdGhpcyBhbGwgdG8gNzIgY2hhcmFjdGVycy4KPiAKPiA+ID4KPiA+ID4gVGVzdGVkLWJ5OiBK aWF0YWkgSGUgPGppYXRhaTIwMjFAaXNjYXMuYWMuY24+Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IEhv bmdyZW4gKFplbml0aGFsKSBaaGVuZyA8aUB6ZW5pdGhhbC5tZT4KPiAKPiBUaGlzIGlzIG1pc3Np bmcgeW91ciBTb0IgU2FtdWVsLgo+IAo+ID4gPiAtLS0KPiA+ID4gIGFyY2gvcmlzY3YvaW5jbHVk ZS9hc20vaHdjYXAuaCB8IDExICsrKysrKysrKysrCj4gPiA+ICBhcmNoL3Jpc2N2L2tlcm5lbC9j cHUuYyAgICAgICAgfCAxMSArKysrKysrKysrKwo+ID4gPiAgYXJjaC9yaXNjdi9rZXJuZWwvY3B1 ZmVhdHVyZS5jIHwgMzAgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gPiA+ICAzIGZp bGVzIGNoYW5nZWQsIDUyIGluc2VydGlvbnMoKykKPiA+ID4KPiA+ID4gZGlmZiAtLWdpdCBhL2Fy Y2gvcmlzY3YvaW5jbHVkZS9hc20vaHdjYXAuaCBiL2FyY2gvcmlzY3YvaW5jbHVkZS9hc20vaHdj YXAuaAo+ID4gPiBpbmRleCBmMDQxYmZhN2Y2YTAuLmI4MGNhNmU3NzA4OCAxMDA2NDQKPiA+ID4g LS0tIGEvYXJjaC9yaXNjdi9pbmNsdWRlL2FzbS9od2NhcC5oCj4gPiA+ICsrKyBiL2FyY2gvcmlz Y3YvaW5jbHVkZS9hc20vaHdjYXAuaAo+ID4gPiBAQCAtNTMsNiArNTMsMTcgQEAKPiA+ID4gICNk ZWZpbmUgUklTQ1ZfSVNBX0VYVF9aSUNTUiAgICAgICAgICAgIDQwCj4gPiA+ICAjZGVmaW5lIFJJ U0NWX0lTQV9FWFRfWklGRU5DRUkgICAgICAgICA0MQo+ID4gPiAgI2RlZmluZSBSSVNDVl9JU0Ff RVhUX1pJSFBNICAgICAgICAgICAgNDIKPiA+ID4gKyNkZWZpbmUgUklTQ1ZfSVNBX0VYVF9aQkMg ICAgICAgICAgICAgIDQzCj4gPiA+ICsjZGVmaW5lIFJJU0NWX0lTQV9FWFRfWkJLQiAgICAgICAg ICAgICA0NAo+ID4gPiArI2RlZmluZSBSSVNDVl9JU0FfRVhUX1pCS0MgICAgICAgICAgICAgNDUK PiA+ID4gKyNkZWZpbmUgUklTQ1ZfSVNBX0VYVF9aQktYICAgICAgICAgICAgIDQ2Cj4gPiA+ICsj ZGVmaW5lIFJJU0NWX0lTQV9FWFRfWktORCAgICAgICAgICAgICA0Nwo+ID4gPiArI2RlZmluZSBS SVNDVl9JU0FfRVhUX1pLTkUgICAgICAgICAgICAgNDgKPiA+ID4gKyNkZWZpbmUgUklTQ1ZfSVNB X0VYVF9aS05IICAgICAgICAgICAgIDQ5Cj4gPiA+ICsjZGVmaW5lIFJJU0NWX0lTQV9FWFRfWktS ICAgICAgICAgICAgICA1MAo+ID4gPiArI2RlZmluZSBSSVNDVl9JU0FfRVhUX1pLU0VEICAgICAg ICAgICAgNTEKPiA+ID4gKyNkZWZpbmUgUklTQ1ZfSVNBX0VYVF9aS1NIICAgICAgICAgICAgIDUy Cj4gPiA+ICsjZGVmaW5lIFJJU0NWX0lTQV9FWFRfWktUICAgICAgICAgICAgICA1Mwo+ID4gPgo+ ID4gPiAgI2RlZmluZSBSSVNDVl9JU0FfRVhUX01BWCAgICAgICAgICAgICAgNjQKPiA+ID4gICNk ZWZpbmUgUklTQ1ZfSVNBX0VYVF9OQU1FX0xFTl9NQVggICAgIDMyCj4gPiA+IGRpZmYgLS1naXQg YS9hcmNoL3Jpc2N2L2tlcm5lbC9jcHUuYyBiL2FyY2gvcmlzY3Yva2VybmVsL2NwdS5jCj4gPiA+ IGluZGV4IGEyZmM5NTIzMThlOS4uMTA1MjQzMjJhNGMwIDEwMDY0NAo+ID4gPiAtLS0gYS9hcmNo L3Jpc2N2L2tlcm5lbC9jcHUuYwo+ID4gPiArKysgYi9hcmNoL3Jpc2N2L2tlcm5lbC9jcHUuYwo+ ID4gPiBAQCAtMjE1LDcgKzIxNSwxOCBAQCBzdGF0aWMgc3RydWN0IHJpc2N2X2lzYV9leHRfZGF0 YSBpc2FfZXh0X2FycltdID0gewo+ID4gPiAgICAgICAgIF9fUklTQ1ZfSVNBX0VYVF9EQVRBKHpp aHBtLCBSSVNDVl9JU0FfRVhUX1pJSFBNKSwKPiA+ID4gICAgICAgICBfX1JJU0NWX0lTQV9FWFRf REFUQSh6YmEsIFJJU0NWX0lTQV9FWFRfWkJBKSwKPiA+ID4gICAgICAgICBfX1JJU0NWX0lTQV9F WFRfREFUQSh6YmIsIFJJU0NWX0lTQV9FWFRfWkJCKSwKPiA+ID4gKyAgICAgICBfX1JJU0NWX0lT QV9FWFRfREFUQSh6YmMsIFJJU0NWX0lTQV9FWFRfWkJDKSwKPiA+ID4gKyAgICAgICBfX1JJU0NW X0lTQV9FWFRfREFUQSh6YmtiLCBSSVNDVl9JU0FfRVhUX1pCS0IpLAo+ID4gPiArICAgICAgIF9f UklTQ1ZfSVNBX0VYVF9EQVRBKHpia2MsIFJJU0NWX0lTQV9FWFRfWkJLQyksCj4gPiA+ICsgICAg ICAgX19SSVNDVl9JU0FfRVhUX0RBVEEoemJreCwgUklTQ1ZfSVNBX0VYVF9aQktYKSwKPiA+ID4g ICAgICAgICBfX1JJU0NWX0lTQV9FWFRfREFUQSh6YnMsIFJJU0NWX0lTQV9FWFRfWkJTKSwKPiA+ ID4gKyAgICAgICBfX1JJU0NWX0lTQV9FWFRfREFUQSh6a25kLCBSSVNDVl9JU0FfRVhUX1pLTkQp LAo+ID4gPiArICAgICAgIF9fUklTQ1ZfSVNBX0VYVF9EQVRBKHprbmUsIFJJU0NWX0lTQV9FWFRf WktORSksCj4gPiA+ICsgICAgICAgX19SSVNDVl9JU0FfRVhUX0RBVEEoemtuaCwgUklTQ1ZfSVNB X0VYVF9aS05IKSwKPiA+ID4gKyAgICAgICBfX1JJU0NWX0lTQV9FWFRfREFUQSh6a3IsIFJJU0NW X0lTQV9FWFRfWktSKSwKPiA+ID4gKyAgICAgICBfX1JJU0NWX0lTQV9FWFRfREFUQSh6a3NlZCwg UklTQ1ZfSVNBX0VYVF9aS1NFRCksCj4gPiA+ICsgICAgICAgX19SSVNDVl9JU0FfRVhUX0RBVEEo emtzaCwgUklTQ1ZfSVNBX0VYVF9aS1NIKSwKPiA+ID4gKyAgICAgICBfX1JJU0NWX0lTQV9FWFRf REFUQSh6a3QsIFJJU0NWX0lTQV9FWFRfWktUKSwKPiA+ID4gICAgICAgICBfX1JJU0NWX0lTQV9F WFRfREFUQShzbWFpYSwgUklTQ1ZfSVNBX0VYVF9TTUFJQSksCj4gPiA+ICAgICAgICAgX19SSVND Vl9JU0FfRVhUX0RBVEEoc3NhaWEsIFJJU0NWX0lTQV9FWFRfU1NBSUEpLAo+ID4gPiAgICAgICAg IF9fUklTQ1ZfSVNBX0VYVF9EQVRBKHNzY29mcG1mLCBSSVNDVl9JU0FfRVhUX1NTQ09GUE1GKSwK PiA+ID4gZGlmZiAtLWdpdCBhL2FyY2gvcmlzY3Yva2VybmVsL2NwdWZlYXR1cmUuYyBiL2FyY2gv cmlzY3Yva2VybmVsL2NwdWZlYXR1cmUuYwo+ID4gPiBpbmRleCBiZGNmNDYwZWE1M2QuLjQ0N2Y4 NTNhNWE0YyAxMDA2NDQKPiA+ID4gLS0tIGEvYXJjaC9yaXNjdi9rZXJuZWwvY3B1ZmVhdHVyZS5j Cj4gPiA+ICsrKyBiL2FyY2gvcmlzY3Yva2VybmVsL2NwdWZlYXR1cmUuYwo+ID4gPiBAQCAtMzA5 LDEwICszMDksNDAgQEAgdm9pZCBfX2luaXQgcmlzY3ZfZmlsbF9od2NhcCh2b2lkKQo+ID4gPiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFNFVF9JU0FfRVhUX01BUCgic3ZwYm10Iiwg UklTQ1ZfSVNBX0VYVF9TVlBCTVQpOwo+ID4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIFNFVF9JU0FfRVhUX01BUCgiemJhIiwgUklTQ1ZfSVNBX0VYVF9aQkEpOwo+ID4gPiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIFNFVF9JU0FfRVhUX01BUCgiemJiIiwgUklTQ1Zf SVNBX0VYVF9aQkIpOwo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFNFVF9J U0FfRVhUX01BUCgiemJjIiwgUklTQ1ZfSVNBX0VYVF9aQkMpOwo+ID4gPiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIFNFVF9JU0FfRVhUX01BUCgiemJzIiwgUklTQ1ZfSVNBX0VYVF9a QlMpOwo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFNFVF9JU0FfRVhUX01B UCgiemJrYiIsIFJJU0NWX0lTQV9FWFRfWkJLQik7Cj4gCj4gVGhpcyBvcmRlciBkb2VzIG5vdCBs b29rIGNvcnJlY3QsIHBsZWFzZSBhZGQgdGhlbSBpbiBhbHBoYW51bWVyaWNhbAo+IG9yZGVyIGFz IHRoZSBjb21tZW50IHRoZXNlIFNFVF9JU0FfRVhUX01BUCgpcyByZXF1ZXN0cy4gRGl0dG8gYmVs b3cuCj4gCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgU0VUX0lTQV9FWFRf TUFQKCJ6YmtjIiwgUklTQ1ZfSVNBX0VYVF9aQktDKTsKPiA+ID4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBTRVRfSVNBX0VYVF9NQVAoInpia3MiLCBSSVNDVl9JU0FfRVhUX1pCS1gp Owo+ID4gCj4gPiBTaG91bGQgInpia3MiIGJlICJ6Ymt4Ij8KPiA+IAo+ID4gPiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIFNFVF9JU0FfRVhUX01BUCgiemljYm9tIiwgUklTQ1ZfSVNB X0VYVF9aSUNCT00pOwo+ID4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFNFVF9J U0FfRVhUX01BUCgiemljYm96IiwgUklTQ1ZfSVNBX0VYVF9aSUNCT1opOwo+ID4gPiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIFNFVF9JU0FfRVhUX01BUCgiemloaW50cGF1c2UiLCBS SVNDVl9JU0FfRVhUX1pJSElOVFBBVVNFKTsKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBTRVRfSVNBX0VYVF9NQVAoInprc2VkIiwgUklTQ1ZfSVNBX0VYVF9aS1NFRCk7Cj4g PiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgU0VUX0lTQV9FWFRfTUFQKCJ6a3No IiwgUklTQ1ZfSVNBX0VYVF9aS1NIKTsKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBTRVRfSVNBX0VYVF9NQVAoInprciIsIFJJU0NWX0lTQV9FWFRfWktSKTsKPiA+ID4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBTRVRfSVNBX0VYVF9NQVAoInprdCIsIFJJU0NW X0lTQV9FWFRfWktUKTsKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBTRVRf SVNBX0VYVF9NQVAoInprbiIsIFJJU0NWX0lTQV9FWFRfWkJLQik7Cj4gPiA+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgU0VUX0lTQV9FWFRfTUFQKCJ6a24iLCBSSVNDVl9JU0FfRVhU X1pCS0MpOwo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFNFVF9JU0FfRVhU X01BUCgiemtuIiwgUklTQ1ZfSVNBX0VYVF9aQktYKTsKPiA+ID4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBTRVRfSVNBX0VYVF9NQVAoInprbiIsIFJJU0NWX0lTQV9FWFRfWktORCk7 Cj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgU0VUX0lTQV9FWFRfTUFQKCJ6 a24iLCBSSVNDVl9JU0FfRVhUX1pLTkUpOwo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIFNFVF9JU0FfRVhUX01BUCgiemtuIiwgUklTQ1ZfSVNBX0VYVF9aS05IKTsKPiA+ID4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBTRVRfSVNBX0VYVF9NQVAoInprbmQiLCBS SVNDVl9JU0FfRVhUX1pLTkQpOwo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IFNFVF9JU0FfRVhUX01BUCgiemtuZSIsIFJJU0NWX0lTQV9FWFRfWktORSk7Cj4gPiA+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgU0VUX0lTQV9FWFRfTUFQKCJ6a25oIiwgUklTQ1Zf SVNBX0VYVF9aS05IKTsKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBTRVRf SVNBX0VYVF9NQVAoInprcyIsIFJJU0NWX0lTQV9FWFRfWkJLQik7Cj4gPiA+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgU0VUX0lTQV9FWFRfTUFQKCJ6a3MiLCBSSVNDVl9JU0FfRVhU X1pCS0MpOwo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFNFVF9JU0FfRVhU X01BUCgiemtzIiwgUklTQ1ZfSVNBX0VYVF9aQktYKTsKPiA+ID4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBTRVRfSVNBX0VYVF9NQVAoInprcyIsIFJJU0NWX0lTQV9FWFRfWktTRUQp Owo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFNFVF9JU0FfRVhUX01BUCgi emtzIiwgUklTQ1ZfSVNBX0VYVF9aS1NIKTsKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBTRVRfSVNBX0VYVF9NQVAoInprIiwgUklTQ1ZfSVNBX0VYVF9aQktCKTsKPiA+ID4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBTRVRfSVNBX0VYVF9NQVAoInprIiwgUklT Q1ZfSVNBX0VYVF9aQktDKTsKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBT RVRfSVNBX0VYVF9NQVAoInprIiwgUklTQ1ZfSVNBX0VYVF9aQktYKTsKPiA+ID4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBTRVRfSVNBX0VYVF9NQVAoInprIiwgUklTQ1ZfSVNBX0VY VF9aS05EKTsKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBTRVRfSVNBX0VY VF9NQVAoInprIiwgUklTQ1ZfSVNBX0VYVF9aS05FKTsKPiA+ID4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBTRVRfSVNBX0VYVF9NQVAoInprIiwgUklTQ1ZfSVNBX0VYVF9aS05IKTsK PiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBTRVRfSVNBX0VYVF9NQVAoInpr IiwgUklTQ1ZfSVNBX0VYVF9aS1IpOwo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIFNFVF9JU0FfRVhUX01BUCgiemsiLCBSSVNDVl9JU0FfRVhUX1pLVCk7Cj4gPiAKPiA+IEl0 IHdvdWxkIGJlIG5pY2UgdG8gY29uc29saWRhdGUgdGhlIG9uZXMgdG9nZXRoZXIgdGhhdCBzZWFy Y2ggZm9yIGEKPiA+IHNpbmdsZSBzdHJpbmcgYW5kIHNldCBtdWx0aXBsZSBiaXRzLCB0aG91Z2gg SSBkb24ndCBoYXZlIGFueSBzdXBlcgo+ID4gZWxlZ2FudCBpZGVhcyBmb3IgaG93IG9mZiB0aGUg dG9wIG9mIG15IGhlYWQuCj4gCj4gSSd2ZSBnb3QgYSByZWZhY3RvciBvZiB0aGlzIGNvZGUgaW4g cHJvZ3Jlc3MsIGRyb3BwaW5nIGFsbCBvZiB0aGVzZQo+IGNvcHktcGFzdGUgaW4gcGxhY2Ugb2Yg YSBsb29wLiBJdCBjZXJ0YWlubHkgbG9va3MgbW9yZSBlbGVnYW50IHRoYW4KPiB0aGlzLCBidXQg aXQgd2lsbCBmYWxsIG92ZXIgYSBiaXQgZm9yIHRoZXNlICJvbmUgc3RyaW5nIG1hdGNoZXMgbWFu eQo+IGV4dGVuc2lvbnMiIGNhc2VzLiBTZWUgaGVyZToKPiBodHRwczovL3BhdGNod29yay5rZXJu ZWwub3JnL3Byb2plY3QvbGludXgtcmlzY3YvcGF0Y2gvMjAyMzA2MjYtdGhpZXZpbmctam9ja3N0 cmFwLWQzNWQyMGI1MzVjNUB3ZW5keS8KPiBNeSBpbW1lZGlhdGUgdGhvdWdodCBpcyB0byBhZGQg YW5vdGhlciBlbGVtZW50IHRvIHJpc2N2X2lzYV9leHRfZGF0YSwKPiB0aGF0IGNvbnRhaW5zICJw YXJlbnQiIGV4dGVuc2lvbnMgdG8gY2hlY2sgZm9yLiBTaG91bGQgYmUgZmFpcmx5IGRvYWJsZSwK PiBJJ2xsIHdoaXAgc29tZXRoaW5nIHVwIG9uIHRvcCBvZiB0aGF0Li4uCgpOaWNlLCBhbmQgdGhh bmtzIGZvciB0aGUgcmV2aWV3LgpTaG91bGQgSSB3YWl0IGZvciB5b3VyIHJlZmFjdG9yIHRvIGJl IG1lcmdlZCBiZWZvcmUgcHVzaGluZyB0aGlzIG9uZT8KCkNoZWVycywKU2FtdWVsLgoKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXJpc2N2IG1h aWxpbmcgbGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2F6DEB64DA for ; Wed, 28 Jun 2023 10:17:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230287AbjF1KRu (ORCPT ); Wed, 28 Jun 2023 06:17:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231375AbjF1KG0 (ORCPT ); Wed, 28 Jun 2023 06:06:26 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEB121FFC for ; Wed, 28 Jun 2023 03:01:15 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-4f86fbe5e4fso7708087e87.2 for ; Wed, 28 Jun 2023 03:01:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1687946474; x=1690538474; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=ejpdHA8WxWWd1l59d/A+1U8uDQbHe+EInXg0gY9zi4g=; b=dZvJgVIXVWCBDL5aXGFxsJ5WPmhQgOeJAlYzfhXYBqZRMXc8ZosqV491wGpV9rwfXT ifQDH5Dakn53A1zYa+hu0PCVcBjx85Y6/pGFtusbYPL6Rx2lxZ7z40Jviu/V12KAEt5f OovlwEonF5PUNsLQ0j7raIByy/CI1zrBCRzn32YSr0JPrfVua6nV41dIHmybPwVqnmBj B+ktWhEcsO/3lBnj12kWtMd4xPB06qGyWjI6kb5tkRQKl4WmcxysASNTmy2N4ZEk+8FL bb3OkWJYNL01pKA9Pn8+CPMsW/OIkaS7zHKMejCnj+peNKHRUKoTX9LrDkXU58vze9Lb vx8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687946474; x=1690538474; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ejpdHA8WxWWd1l59d/A+1U8uDQbHe+EInXg0gY9zi4g=; b=TYU3q7EiFdCYB3uFxySa4c03vWfK2+cB2XJBK9+GQyLnonAcldJv4KEVVA4jNyUuEC 31KS7Hc2BG+vjWTL/5v5q/jfX85GHgaXtALFBILwFHxhCzEEAt/S0M6eZCo1EkfP4Ciw /77bDcOABRe10Jl0BWnvpH2mdyxrM2dnw3eHjWTbNaM3KaRJcaD7ufOfByHev2PnbRWv up2HbsY2tq2dad3Q+OgnYYQsnFtMVO4upGdhyG0zbZvex/SShYYbsigd5KQULsikuJes Crb62E0OUrN/qSs6i66PUlp2gukraLG7N40j/8xRJBiwXQpgkgdLNMieCNnsIyfh+uRe TM9Q== X-Gm-Message-State: AC+VfDxZ68gguc025zbvjhRV68cFO92LpZ5t9gdniyJZzmaFkSXV4swl VsIycaFzn5jg0L7kCGE0hlgXYA== X-Google-Smtp-Source: ACHHUZ71Yv4hqMaxWIDwAYtnT7SHbWlkB9oKL4/KN0ocWZiXmvCj0cgNqI0Fj7mNTg6Mq0VXQQD+sA== X-Received: by 2002:a05:6512:3b82:b0:4fb:7be5:4870 with SMTP id g2-20020a0565123b8200b004fb7be54870mr5901035lfv.46.1687946473669; Wed, 28 Jun 2023 03:01:13 -0700 (PDT) Received: from vermeer ([2a01:cb1d:81a9:dd00:b570:b34c:ffd4:c805]) by smtp.gmail.com with ESMTPSA id 21-20020a05600c22d500b003f9cb3c8958sm16399566wmg.3.2023.06.28.03.01.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jun 2023 03:01:13 -0700 (PDT) Date: Wed, 28 Jun 2023 12:01:11 +0200 From: Samuel Ortiz To: Conor Dooley Cc: Evan Green , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-riscv@lists.infradead.org, "Hongren (Zenithal) Zheng" , linux@rivosinc.com, Conor Dooley , Andrew Jones , Heiko Stuebner , Anup Patel , linux-kernel@vger.kernel.org, Guo Ren , Atish Patra , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Jiatai He Subject: Re: [PATCH 1/3] RISC-V: add Bitmanip/Scalar Crypto parsing from DT Message-ID: References: <20230627143747.1599218-1-sameo@rivosinc.com> <20230627143747.1599218-2-sameo@rivosinc.com> <20230627-debating-twelve-da2c1ed60948@spud> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230627-debating-twelve-da2c1ed60948@spud> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 27, 2023 at 07:48:15PM +0100, Conor Dooley wrote: > On Tue, Jun 27, 2023 at 11:14:30AM -0700, Evan Green wrote: > > On Tue, Jun 27, 2023 at 7:38 AM Samuel Ortiz wrote: > > > > > > From: "Hongren (Zenithal) Zheng" > > > > > > This patch parses Zb/Zk related string from DT and > > %s/This patch// > > > > output them in cpuinfo > > > > > > One thing worth noting is that if DT provides zk, > > > all zbkb, zbkc, zbkx and zkn, zkr, zkt would be enabled. > > Please explain why this is okay. > > > > Note that zk is a valid extension name and the current > > > DT binding spec allows this. > > > > > > This patch also changes the logical id of > > > existing multi-letter extensions and adds a statement > > > that instead of logical id compatibility, the order > > > is needed. > > Does it? > > > > There currently lacks a mechanism to merge them when > > > producing cpuinfo. Namely if you provide a riscv,isa > > > "rv64imafdc_zk_zks", the cpuinfo output would be > > > "rv64imafdc_zbkb_zbkc_zbkx_zknd_zkne_zknh_zkr_zksed > > > _zksh_zkt" > > I think this is fine. > > Please re-wrap this all to 72 characters. > > > > > > > Tested-by: Jiatai He > > > Signed-off-by: Hongren (Zenithal) Zheng > > This is missing your SoB Samuel. > > > > --- > > > arch/riscv/include/asm/hwcap.h | 11 +++++++++++ > > > arch/riscv/kernel/cpu.c | 11 +++++++++++ > > > arch/riscv/kernel/cpufeature.c | 30 ++++++++++++++++++++++++++++++ > > > 3 files changed, 52 insertions(+) > > > > > > diff --git a/arch/riscv/include/asm/hwcap.h b/arch/riscv/include/asm/hwcap.h > > > index f041bfa7f6a0..b80ca6e77088 100644 > > > --- a/arch/riscv/include/asm/hwcap.h > > > +++ b/arch/riscv/include/asm/hwcap.h > > > @@ -53,6 +53,17 @@ > > > #define RISCV_ISA_EXT_ZICSR 40 > > > #define RISCV_ISA_EXT_ZIFENCEI 41 > > > #define RISCV_ISA_EXT_ZIHPM 42 > > > +#define RISCV_ISA_EXT_ZBC 43 > > > +#define RISCV_ISA_EXT_ZBKB 44 > > > +#define RISCV_ISA_EXT_ZBKC 45 > > > +#define RISCV_ISA_EXT_ZBKX 46 > > > +#define RISCV_ISA_EXT_ZKND 47 > > > +#define RISCV_ISA_EXT_ZKNE 48 > > > +#define RISCV_ISA_EXT_ZKNH 49 > > > +#define RISCV_ISA_EXT_ZKR 50 > > > +#define RISCV_ISA_EXT_ZKSED 51 > > > +#define RISCV_ISA_EXT_ZKSH 52 > > > +#define RISCV_ISA_EXT_ZKT 53 > > > > > > #define RISCV_ISA_EXT_MAX 64 > > > #define RISCV_ISA_EXT_NAME_LEN_MAX 32 > > > diff --git a/arch/riscv/kernel/cpu.c b/arch/riscv/kernel/cpu.c > > > index a2fc952318e9..10524322a4c0 100644 > > > --- a/arch/riscv/kernel/cpu.c > > > +++ b/arch/riscv/kernel/cpu.c > > > @@ -215,7 +215,18 @@ static struct riscv_isa_ext_data isa_ext_arr[] = { > > > __RISCV_ISA_EXT_DATA(zihpm, RISCV_ISA_EXT_ZIHPM), > > > __RISCV_ISA_EXT_DATA(zba, RISCV_ISA_EXT_ZBA), > > > __RISCV_ISA_EXT_DATA(zbb, RISCV_ISA_EXT_ZBB), > > > + __RISCV_ISA_EXT_DATA(zbc, RISCV_ISA_EXT_ZBC), > > > + __RISCV_ISA_EXT_DATA(zbkb, RISCV_ISA_EXT_ZBKB), > > > + __RISCV_ISA_EXT_DATA(zbkc, RISCV_ISA_EXT_ZBKC), > > > + __RISCV_ISA_EXT_DATA(zbkx, RISCV_ISA_EXT_ZBKX), > > > __RISCV_ISA_EXT_DATA(zbs, RISCV_ISA_EXT_ZBS), > > > + __RISCV_ISA_EXT_DATA(zknd, RISCV_ISA_EXT_ZKND), > > > + __RISCV_ISA_EXT_DATA(zkne, RISCV_ISA_EXT_ZKNE), > > > + __RISCV_ISA_EXT_DATA(zknh, RISCV_ISA_EXT_ZKNH), > > > + __RISCV_ISA_EXT_DATA(zkr, RISCV_ISA_EXT_ZKR), > > > + __RISCV_ISA_EXT_DATA(zksed, RISCV_ISA_EXT_ZKSED), > > > + __RISCV_ISA_EXT_DATA(zksh, RISCV_ISA_EXT_ZKSH), > > > + __RISCV_ISA_EXT_DATA(zkt, RISCV_ISA_EXT_ZKT), > > > __RISCV_ISA_EXT_DATA(smaia, RISCV_ISA_EXT_SMAIA), > > > __RISCV_ISA_EXT_DATA(ssaia, RISCV_ISA_EXT_SSAIA), > > > __RISCV_ISA_EXT_DATA(sscofpmf, RISCV_ISA_EXT_SSCOFPMF), > > > diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c > > > index bdcf460ea53d..447f853a5a4c 100644 > > > --- a/arch/riscv/kernel/cpufeature.c > > > +++ b/arch/riscv/kernel/cpufeature.c > > > @@ -309,10 +309,40 @@ void __init riscv_fill_hwcap(void) > > > SET_ISA_EXT_MAP("svpbmt", RISCV_ISA_EXT_SVPBMT); > > > SET_ISA_EXT_MAP("zba", RISCV_ISA_EXT_ZBA); > > > SET_ISA_EXT_MAP("zbb", RISCV_ISA_EXT_ZBB); > > > + SET_ISA_EXT_MAP("zbc", RISCV_ISA_EXT_ZBC); > > > SET_ISA_EXT_MAP("zbs", RISCV_ISA_EXT_ZBS); > > > + SET_ISA_EXT_MAP("zbkb", RISCV_ISA_EXT_ZBKB); > > This order does not look correct, please add them in alphanumerical > order as the comment these SET_ISA_EXT_MAP()s requests. Ditto below. > > > > + SET_ISA_EXT_MAP("zbkc", RISCV_ISA_EXT_ZBKC); > > > + SET_ISA_EXT_MAP("zbks", RISCV_ISA_EXT_ZBKX); > > > > Should "zbks" be "zbkx"? > > > > > SET_ISA_EXT_MAP("zicbom", RISCV_ISA_EXT_ZICBOM); > > > SET_ISA_EXT_MAP("zicboz", RISCV_ISA_EXT_ZICBOZ); > > > SET_ISA_EXT_MAP("zihintpause", RISCV_ISA_EXT_ZIHINTPAUSE); > > > + SET_ISA_EXT_MAP("zksed", RISCV_ISA_EXT_ZKSED); > > > + SET_ISA_EXT_MAP("zksh", RISCV_ISA_EXT_ZKSH); > > > + SET_ISA_EXT_MAP("zkr", RISCV_ISA_EXT_ZKR); > > > + SET_ISA_EXT_MAP("zkt", RISCV_ISA_EXT_ZKT); > > > + SET_ISA_EXT_MAP("zkn", RISCV_ISA_EXT_ZBKB); > > > + SET_ISA_EXT_MAP("zkn", RISCV_ISA_EXT_ZBKC); > > > + SET_ISA_EXT_MAP("zkn", RISCV_ISA_EXT_ZBKX); > > > + SET_ISA_EXT_MAP("zkn", RISCV_ISA_EXT_ZKND); > > > + SET_ISA_EXT_MAP("zkn", RISCV_ISA_EXT_ZKNE); > > > + SET_ISA_EXT_MAP("zkn", RISCV_ISA_EXT_ZKNH); > > > + SET_ISA_EXT_MAP("zknd", RISCV_ISA_EXT_ZKND); > > > + SET_ISA_EXT_MAP("zkne", RISCV_ISA_EXT_ZKNE); > > > + SET_ISA_EXT_MAP("zknh", RISCV_ISA_EXT_ZKNH); > > > + SET_ISA_EXT_MAP("zks", RISCV_ISA_EXT_ZBKB); > > > + SET_ISA_EXT_MAP("zks", RISCV_ISA_EXT_ZBKC); > > > + SET_ISA_EXT_MAP("zks", RISCV_ISA_EXT_ZBKX); > > > + SET_ISA_EXT_MAP("zks", RISCV_ISA_EXT_ZKSED); > > > + SET_ISA_EXT_MAP("zks", RISCV_ISA_EXT_ZKSH); > > > + SET_ISA_EXT_MAP("zk", RISCV_ISA_EXT_ZBKB); > > > + SET_ISA_EXT_MAP("zk", RISCV_ISA_EXT_ZBKC); > > > + SET_ISA_EXT_MAP("zk", RISCV_ISA_EXT_ZBKX); > > > + SET_ISA_EXT_MAP("zk", RISCV_ISA_EXT_ZKND); > > > + SET_ISA_EXT_MAP("zk", RISCV_ISA_EXT_ZKNE); > > > + SET_ISA_EXT_MAP("zk", RISCV_ISA_EXT_ZKNH); > > > + SET_ISA_EXT_MAP("zk", RISCV_ISA_EXT_ZKR); > > > + SET_ISA_EXT_MAP("zk", RISCV_ISA_EXT_ZKT); > > > > It would be nice to consolidate the ones together that search for a > > single string and set multiple bits, though I don't have any super > > elegant ideas for how off the top of my head. > > I've got a refactor of this code in progress, dropping all of these > copy-paste in place of a loop. It certainly looks more elegant than > this, but it will fall over a bit for these "one string matches many > extensions" cases. See here: > https://patchwork.kernel.org/project/linux-riscv/patch/20230626-thieving-jockstrap-d35d20b535c5@wendy/ > My immediate thought is to add another element to riscv_isa_ext_data, > that contains "parent" extensions to check for. Should be fairly doable, > I'll whip something up on top of that... Nice, and thanks for the review. Should I wait for your refactor to be merged before pushing this one? Cheers, Samuel.