From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F6FCEB64DC for ; Tue, 11 Jul 2023 22:00:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229609AbjGKWA1 (ORCPT ); Tue, 11 Jul 2023 18:00:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229551AbjGKWAY (ORCPT ); Tue, 11 Jul 2023 18:00:24 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2706D1992 for ; Tue, 11 Jul 2023 15:00:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GR7Hgx/W3CR5RFAsNJV3TXtKYoyPG7TJfZgx5GEsN+M=; b=MidStUHHVj31VOhmkApv0W5rnq d+ljJoZBzxMyqfRDmlLz8J/eJ8Prwg/ymcCn7CbEIbfir0lq+u6xDOZlOSrJcPEu285RdV5ffbqzK T8Ty523zDSvIn/tgV8lv5ljlKk2kgG0WGgVQpQGLvlO04GL/ASU/qomZ9B2/qH8Ziuxc3gULoLjm+ tDkExFYrI2+c3UmjtDns3RP0csPUx3hHxIS7lMFmYQtRkHiAxcTOGQf7tH+RnoWpbL8eJ3qDRpl0P 5ch99DieeCY6heDJbhTN0pqDf8jJJX+FgcYwJ3R7Kwrd32nkApF/OPIFzAtu2z/sURYYiIhdBeqQx 0CkQyXCA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qJLOi-00G5K6-W1; Tue, 11 Jul 2023 21:59:53 +0000 Date: Tue, 11 Jul 2023 22:59:52 +0100 From: Matthew Wilcox To: Luis Chamberlain Cc: David Hildenbrand , Ryan Roberts , Andrew Morton , "Kirill A. Shutemov" , Yin Fengwei , Yu Zhao , Catalin Marinas , Will Deacon , Anshuman Khandual , Yang Shi , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 0/5] variable-order, large folios for anonymous memory Message-ID: References: <20230703135330.1865927-1-ryan.roberts@arm.com> <78159ed0-a233-9afb-712f-2df1a4858b22@redhat.com> <4d4c45a2-0037-71de-b182-f516fee07e67@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 11, 2023 at 02:11:19PM -0700, Luis Chamberlain wrote: > On Fri, Jul 07, 2023 at 02:12:01PM +0100, Matthew Wilcox wrote: > > On Fri, Jul 07, 2023 at 01:40:53PM +0200, David Hildenbrand wrote: > > > > > Is swapping working as expected? zswap? > > > > Suboptimally. Swap will split folios in order to swap them. > > Wouldn't that mean if high order folios are used a lot but swap is also > used, until this is fixed you wouldn't get the expected reclaim gains > for high order folios and we'd need compaction more then? They're split in shrink_folio_list(), so they stay intact until that point? > > Somebody needs to fix that, but it should work. > > As we look at shmem stuff it was on the path so something we have > considered doing. Ie, it's on our team's list of items to help with > but currently on a backburner. Something I was thinking about is that you'll need to prohibit swap devices or swap files being created on large block devices. Until we rewrite the entire swap subsystem ... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4CC55EB64DD for ; Tue, 11 Jul 2023 22:00:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LSVAE8tyZ/9c6W9opH2+t7kjbQDa7AUKucOp0vCxSG0=; b=1zVGgIgZbiUNLx XR3XYenWtop/qr1KkUZOANSqJY6Ryb+LZv63CuQHaiMFq04/c4EyxdiPTC5qc3j9d9CZtG7W5ZDZd xZOHDJ1XxJGQfTu4X2ueZLccex6BgoX4fxvcgXV0OuWWZQFGGx0p9NDs3bXi+TaWbCtBxDlE17W2g KA+Fxe3yvrGEwpdl/gQZZ7xSf4tQ+baGBvdk7D5chgmYYLgQZEbAe0Qx000nwUQVpQIGypUph7e1M N+CUD+eL20EVifWa8uCUQ93qd62uHistdE8CfDaL97c9tQBlgKiuztV5sgO2dkariitbxPj3dvXXn XYmJrJFL4zfGkQcuXZWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJLOp-00Fx22-3B; Tue, 11 Jul 2023 21:59:59 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qJLOo-00Fx1u-19 for linux-arm-kernel@bombadil.infradead.org; Tue, 11 Jul 2023 21:59:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GR7Hgx/W3CR5RFAsNJV3TXtKYoyPG7TJfZgx5GEsN+M=; b=MidStUHHVj31VOhmkApv0W5rnq d+ljJoZBzxMyqfRDmlLz8J/eJ8Prwg/ymcCn7CbEIbfir0lq+u6xDOZlOSrJcPEu285RdV5ffbqzK T8Ty523zDSvIn/tgV8lv5ljlKk2kgG0WGgVQpQGLvlO04GL/ASU/qomZ9B2/qH8Ziuxc3gULoLjm+ tDkExFYrI2+c3UmjtDns3RP0csPUx3hHxIS7lMFmYQtRkHiAxcTOGQf7tH+RnoWpbL8eJ3qDRpl0P 5ch99DieeCY6heDJbhTN0pqDf8jJJX+FgcYwJ3R7Kwrd32nkApF/OPIFzAtu2z/sURYYiIhdBeqQx 0CkQyXCA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qJLOi-00G5K6-W1; Tue, 11 Jul 2023 21:59:53 +0000 Date: Tue, 11 Jul 2023 22:59:52 +0100 From: Matthew Wilcox To: Luis Chamberlain Cc: David Hildenbrand , Ryan Roberts , Andrew Morton , "Kirill A. Shutemov" , Yin Fengwei , Yu Zhao , Catalin Marinas , Will Deacon , Anshuman Khandual , Yang Shi , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 0/5] variable-order, large folios for anonymous memory Message-ID: References: <20230703135330.1865927-1-ryan.roberts@arm.com> <78159ed0-a233-9afb-712f-2df1a4858b22@redhat.com> <4d4c45a2-0037-71de-b182-f516fee07e67@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 11, 2023 at 02:11:19PM -0700, Luis Chamberlain wrote: > On Fri, Jul 07, 2023 at 02:12:01PM +0100, Matthew Wilcox wrote: > > On Fri, Jul 07, 2023 at 01:40:53PM +0200, David Hildenbrand wrote: > > > > > Is swapping working as expected? zswap? > > > > Suboptimally. Swap will split folios in order to swap them. > > Wouldn't that mean if high order folios are used a lot but swap is also > used, until this is fixed you wouldn't get the expected reclaim gains > for high order folios and we'd need compaction more then? They're split in shrink_folio_list(), so they stay intact until that point? > > Somebody needs to fix that, but it should work. > > As we look at shmem stuff it was on the path so something we have > considered doing. Ie, it's on our team's list of items to help with > but currently on a backburner. Something I was thinking about is that you'll need to prohibit swap devices or swap files being created on large block devices. Until we rewrite the entire swap subsystem ... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel