All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	linux-iio@vger.kernel.org,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Prabhakar Mahadev Lad" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 5/5] iio: magnetometer: ak8975: Sort OF table
Date: Fri, 18 Aug 2023 14:30:30 +0300	[thread overview]
Message-ID: <ZN9WVvo+pixspCsw@smile.fi.intel.com> (raw)
In-Reply-To: <20230818075600.24277-6-biju.das.jz@bp.renesas.com>

On Fri, Aug 18, 2023 at 08:56:00AM +0100, Biju Das wrote:
> Sort OF table alphabetically by compatibles.

> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Wrong, I haven't suggested that. See comment to the previous patch.

And this is definitely wrong as Geert explained already why.
You need to fix the code that handles the ID table first.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2023-08-18 11:31 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-18  7:55 [PATCH v2 0/5] OF/ACPI/ID Match table improvements for ak8975 driver Biju Das
2023-08-18  7:55 ` [PATCH v2 1/5] iio: magnetometer: ak8975: Convert enum->pointer for data in the match tables Biju Das
2023-08-18 11:25   ` Andy Shevchenko
2023-08-18 11:26     ` Andy Shevchenko
2023-08-18 11:32   ` Andy Shevchenko
2023-10-17 21:11   ` André Apitzsch
2023-10-18  7:04     ` Geert Uytterhoeven
2023-10-18 19:45       ` Jonathan Cameron
2023-10-18 19:53         ` Geert Uytterhoeven
2023-10-18 20:19         ` André Apitzsch
2023-10-19  6:53           ` Biju Das
2023-10-19  7:08             ` Biju Das
2023-10-19  9:18               ` Andy Shevchenko
2023-10-19  9:41                 ` Biju Das
2023-10-19 11:17                   ` Jonathan Cameron
2023-10-19 12:04                     ` Andy Shevchenko
2023-10-19 19:59                   ` André Apitzsch
2023-10-20  7:39                     ` Biju Das
2023-10-20 15:10                       ` Jonathan Cameron
2023-08-18  7:55 ` [PATCH v2 2/5] iio: magnetometer: ak8975: Sort ID and ACPI tables Biju Das
2023-08-18 11:28   ` Andy Shevchenko
2023-08-18 12:12     ` Biju Das
2023-08-18  7:55 ` [PATCH v2 3/5] dt-bindings: iio: magnetometer: asahi-kasei,ak8975: Drop deprecated enums Biju Das
2023-08-18 15:14   ` Geert Uytterhoeven
2023-08-21 20:37   ` Rob Herring
2023-08-28 14:22   ` Jonathan Cameron
2023-08-18  7:55 ` [PATCH v2 4/5] iio: magnetometer: ak8975: Drop deprecated enums from OF table Biju Das
2023-08-18 11:29   ` Andy Shevchenko
2023-08-18 11:40     ` Biju Das
2023-08-18 15:02       ` Andy Shevchenko
2023-08-18 15:10         ` Biju Das
2023-08-18 15:17         ` Geert Uytterhoeven
2023-08-28 14:21           ` Jonathan Cameron
2023-10-06 14:58             ` Rob Herring
2023-10-10  8:48               ` Jonathan Cameron
2023-08-18  7:56 ` [PATCH v2 5/5] iio: magnetometer: ak8975: Sort " Biju Das
2023-08-18 11:30   ` Andy Shevchenko [this message]
2023-08-18 11:39     ` Biju Das
2023-08-18 15:01       ` Andy Shevchenko
2023-08-18 15:06         ` Biju Das
2023-08-18 14:55     ` Geert Uytterhoeven
2023-08-18 15:35       ` Andy Shevchenko
2023-08-18 15:43         ` Geert Uytterhoeven
2023-08-18 17:04           ` Andy Shevchenko
2023-08-18 17:10             ` Biju Das
2023-08-18 17:17             ` Geert Uytterhoeven
2023-08-28 14:27   ` Jonathan Cameron
2023-08-28 14:30     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZN9WVvo+pixspCsw@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.