From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFFE5100B6 for ; Wed, 9 Aug 2023 10:02:47 +0000 (UTC) Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B828C1BFA for ; Wed, 9 Aug 2023 03:02:46 -0700 (PDT) Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-686ed1d2594so6315016b3a.2 for ; Wed, 09 Aug 2023 03:02:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691575366; x=1692180166; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=l3PnAwAhO0hPQux2PIRrbrT++BdxG44s59kqndxfAHE=; b=Rn8qqzTdzlFZiflL6reZctJcZ2J0hfuHKYHAhIl3SchazTwC9/OTaPKgMrbTMNC5KE Wlap09clYnn7rKl8zUhvtBHrRLTAtYwCZP09JtvAGBQ32VTqZznoKE/ZDGsQw/wNJZcb mAF5znEMZEbiyiZkGaOanLqkHJSwdoZWGwWTpqAvfr+en5CelgQg/hOEv86EnASx0ckr FwS/4cwGFi2fPvdcLtlRZvFnCitw/hJM0pEKYhOfBf6rs4aCc9anmxK1HvtWEr1iLa6L RKqY+3Zlx6duF/nbZDyHJuxXm03bTGPRvpBard2LRf8DXF3jt3nRfgkW/OhzTnGag6Qv UqyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691575366; x=1692180166; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=l3PnAwAhO0hPQux2PIRrbrT++BdxG44s59kqndxfAHE=; b=O8ibb7Cfb5S37YnIF3uujYySkTXlbSsWQEONTm7/yAFma01oc5bwUM3fGkReKWyo+r U1QDWU6N7PUA72ZT+quFUR67St+pRfdsOorbM+SwIif9ZrHlBKiUZPJE1tfPfgGctyZW qokQ9tsgc8g+Rx5AkJLfen2IWGKbK4tU2KNOyS/iwUqKxL2Jhow0a5+Tk7itAZ0cCxhl TcEK3HRvl3NL3vdI/bCoXsOSex+BkRA9elFJDbjHcjI6alHebTrWSkbzEMvJ9Hp3uig4 L4nmpR6eAuKyzMXv+pGwCkSLlWBbKDRTEce+q+bWlr2Vbx2t8AZP0Zr+dd7BEl5Y8/Cb TsIg== X-Gm-Message-State: AOJu0YwGnryXbatmqHAFKcqD9rxkZR88YKfl7hK5rwluEMO274J7dOZE GbT/I72PFwEGebOXuCXVXqw= X-Google-Smtp-Source: AGHT+IEA7BrgfRkXYFqRm3NXl9W6CqD3T56FkKIb6z4lzRGesy/RH7Ftdz8F/otrBJP7IfNQPKB0Cg== X-Received: by 2002:a05:6a21:9983:b0:135:293b:9b14 with SMTP id ve3-20020a056a21998300b00135293b9b14mr2796345pzb.55.1691575366048; Wed, 09 Aug 2023 03:02:46 -0700 (PDT) Received: from Laptop-X1 ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id jd20-20020a170903261400b001b9dadf8bd2sm10776390plb.190.2023.08.09.03.02.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Aug 2023 03:02:45 -0700 (PDT) Date: Wed, 9 Aug 2023 18:02:41 +0800 From: Hangbin Liu To: Ido Schimmel Cc: David Ahern , Stephen Hemminger , netdev@vger.kernel.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Thomas Haller Subject: Re: [PATCH net-next] ipv4/fib: send RTM_DELROUTE notify when flush fib Message-ID: References: <20230718085814.4301b9dd@hermes.local> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Wed, Aug 09, 2023 at 10:06:07AM +0300, Ido Schimmel wrote: > We can instead represent fib_nh_is_v6 and nh_updated using a single bit: > > diff --git a/include/net/ip_fib.h b/include/net/ip_fib.h > index a378eff827c7..a91f8a28689a 100644 > --- a/include/net/ip_fib.h > +++ b/include/net/ip_fib.h > @@ -152,8 +152,8 @@ struct fib_info { > #define fib_rtt fib_metrics->metrics[RTAX_RTT-1] > #define fib_advmss fib_metrics->metrics[RTAX_ADVMSS-1] > int fib_nhs; > - bool fib_nh_is_v6; > - bool nh_updated; > + u8 fib_nh_is_v6:1, > + nh_updated:1; > struct nexthop *nh; > struct rcu_head rcu; > struct fib_nh fib_nh[]; > > And then add another bit there to mark a FIB info that is deleted > because of preferred source address deletion. > > I suggest testing with the FIB tests in tools/testing/selftests/net/. Thanks for the suggestion. The discuss in this patch is getting too long. Let me post the new patch and we can discuss there. Hangbin