From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00320C04A94 for ; Mon, 14 Aug 2023 16:18:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231673AbjHNQSX (ORCPT ); Mon, 14 Aug 2023 12:18:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231825AbjHNQRz (ORCPT ); Mon, 14 Aug 2023 12:17:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 246AC1BD; Mon, 14 Aug 2023 09:17:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B5F6B63E1D; Mon, 14 Aug 2023 16:17:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9BACEC433C7; Mon, 14 Aug 2023 16:17:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692029874; bh=R+JfylcDTKNSxp7M/N5Is0OsD+bt7b/rmBp9CTcJ+8c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eZg/p6XyNRoNiYPKWkkVIsZGnn+ehWk42rjMDvLNB1/UGjHN9m3qaazn7q0fookFQ 7VzjnSZnTvGpth+LAPCeE0710QCQkhtqnP8CAmKLyw3vpoMoeZ0PIcb30FIhUjiDp3 lMPBquJYsBXaJGL/CwTf6CQOCUpCI2vdEXOc5pE+RuKvdqAlAHOEOdDJycbZBMScfj dXQKWDJzL+hQxmn6EF5YOCMXHpavWsD6TeT9K+vHidwuSAR7QdekY7GA8jROd+ez6g j/8rvCj4HJ0H3feeTtR9Wq9ttI2KqKRSI9DnGy56eNhv0zImm0s1CNtOG2A9a57C4Q 0J9iukyqV8c2Q== Date: Mon, 14 Aug 2023 18:17:48 +0200 From: Wolfram Sang To: Chengfeng Ye Cc: andi.shyti@kernel.org, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] i2c: bcm-iproc: Fix bcm_iproc_i2c_isr deadlock issue Message-ID: Mail-Followup-To: Wolfram Sang , Chengfeng Ye , andi.shyti@kernel.org, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230707084941.28964-1-dg573847474@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lP44t/20Ow0y+TLX" Content-Disposition: inline In-Reply-To: <20230707084941.28964-1-dg573847474@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --lP44t/20Ow0y+TLX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 07, 2023 at 08:49:41AM +0000, Chengfeng Ye wrote: > iproc_i2c_rd_reg() and iproc_i2c_wr_reg() are called from both > interrupt context (e.g. bcm_iproc_i2c_isr) and process context > (e.g. bcm_iproc_i2c_suspend). Therefore, interrupts should be > disabled to avoid potential deadlock. To prevent this scenario, > use spin_lock_irqsave(). >=20 > Fixes: 9a1038728037 ("i2c: iproc: add NIC I2C support") > Signed-off-by: Chengfeng Ye Applied to for-current, thanks! --lP44t/20Ow0y+TLX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmTaU6wACgkQFA3kzBSg KbaNKRAAtQ5yI2RX3kG1g6Nxx6xQk6u0UG8EvKyZsADukUZxn9ccsUZAuP4vjXOQ RqqwODwaKhGtngnRhqOkbE2rRoNc6NT7YJqLtnWAznDpW2/HMdbDMsmVbybQ7TiL uL+LLtT1HqhF24pZXo3XJZmFZI9W5/5ez3oGBgH0RhiSb/7znTX/bqHPpQnoYFHP tk0NJ6HpiUqHYYjT9ogUBH07CfXgUfW1phYyPZICSGjGdK+wzVlsFLWCEXyVNh8E hilzIQj3uz1PzuLty1VeJQpFhp+PDvtgZzh402iR/vn1wAELsFki/a5qGl5RQq5u auNzbT8HGLLlAG8Dfcm9wIdJ64OWnfYKE3WIEptaIYwwDQKBoFyzdr63Au2ShupU m3V+7he7urtUibjWe+ogWmLOVJEbXMOnCBhfsd5Zt/3uu3dqbnRnT5AWynLRuOKd RmLuiDx4Ahfx8VRbJ+TpmPjckoVdX7xKUN/crkRpFPORtKRRXHGfshwQE9t4amY0 4QqAu/z44qHoWQ8BUb1OkZyxKcpdwMfIu5IbsjqszHYLG9zQztVuu9wuXDFwghtL uVU4lQ62CjtzU41BeAKDxmlAZqt+3woZzsZwgXPkZVz5IuAh6st8CGizRno/SA+9 lXX0hZfjldqWMiXuG6grd6O80ZobZHq78CngCDXaBYB4FIHKmhM= =zNjM -----END PGP SIGNATURE----- --lP44t/20Ow0y+TLX-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2A59C001B0 for ; Mon, 14 Aug 2023 16:18:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7ZsGhP0c4V3Ti0nOB2gFlm0qoaQjMtrNjBCveYNxIxg=; b=eOQ5sV/m2O3pzXaSL45CZf30iw jIYgis/t8OUAh37hmcHLox0qadXIumDlHeT3RnmPOPBHosO9+a1JixJpzNQtiOzCSygZDCFznP/Xt oI3iFuuKL1i9If+iq31NycUApZeXlp7LI0rFjumOKF5DLvDpmh7PVjj5Equ2RYGydjh134YCuXkis EF+8jA7gQ83hXdAxmI0kXFE1DfcwSKqBpf/RDVWxKsOHT5yERaRxCCbkUg9XVUj1eNbu+GWGrnbsp ITr1re2LCyurizZIRnRPTPtHA1+sHRyQaOpwOMZ4jNhNb2h9pbZ0Oy91qbBFf6Zqacy6uxfrFFGxX w3XNRwuw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qVaGU-00HXaV-15; Mon, 14 Aug 2023 16:17:58 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qVaGR-00HXa5-0s for linux-arm-kernel@lists.infradead.org; Mon, 14 Aug 2023 16:17:56 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B29816114F; Mon, 14 Aug 2023 16:17:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9BACEC433C7; Mon, 14 Aug 2023 16:17:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692029874; bh=R+JfylcDTKNSxp7M/N5Is0OsD+bt7b/rmBp9CTcJ+8c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eZg/p6XyNRoNiYPKWkkVIsZGnn+ehWk42rjMDvLNB1/UGjHN9m3qaazn7q0fookFQ 7VzjnSZnTvGpth+LAPCeE0710QCQkhtqnP8CAmKLyw3vpoMoeZ0PIcb30FIhUjiDp3 lMPBquJYsBXaJGL/CwTf6CQOCUpCI2vdEXOc5pE+RuKvdqAlAHOEOdDJycbZBMScfj dXQKWDJzL+hQxmn6EF5YOCMXHpavWsD6TeT9K+vHidwuSAR7QdekY7GA8jROd+ez6g j/8rvCj4HJ0H3feeTtR9Wq9ttI2KqKRSI9DnGy56eNhv0zImm0s1CNtOG2A9a57C4Q 0J9iukyqV8c2Q== Date: Mon, 14 Aug 2023 18:17:48 +0200 From: Wolfram Sang To: Chengfeng Ye Cc: andi.shyti@kernel.org, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] i2c: bcm-iproc: Fix bcm_iproc_i2c_isr deadlock issue Message-ID: Mail-Followup-To: Wolfram Sang , Chengfeng Ye , andi.shyti@kernel.org, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230707084941.28964-1-dg573847474@gmail.com> MIME-Version: 1.0 In-Reply-To: <20230707084941.28964-1-dg573847474@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230814_091755_348890_8521FF1B X-CRM114-Status: GOOD ( 10.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8060657140789450293==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8060657140789450293== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lP44t/20Ow0y+TLX" Content-Disposition: inline --lP44t/20Ow0y+TLX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 07, 2023 at 08:49:41AM +0000, Chengfeng Ye wrote: > iproc_i2c_rd_reg() and iproc_i2c_wr_reg() are called from both > interrupt context (e.g. bcm_iproc_i2c_isr) and process context > (e.g. bcm_iproc_i2c_suspend). Therefore, interrupts should be > disabled to avoid potential deadlock. To prevent this scenario, > use spin_lock_irqsave(). >=20 > Fixes: 9a1038728037 ("i2c: iproc: add NIC I2C support") > Signed-off-by: Chengfeng Ye Applied to for-current, thanks! --lP44t/20Ow0y+TLX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmTaU6wACgkQFA3kzBSg KbaNKRAAtQ5yI2RX3kG1g6Nxx6xQk6u0UG8EvKyZsADukUZxn9ccsUZAuP4vjXOQ RqqwODwaKhGtngnRhqOkbE2rRoNc6NT7YJqLtnWAznDpW2/HMdbDMsmVbybQ7TiL uL+LLtT1HqhF24pZXo3XJZmFZI9W5/5ez3oGBgH0RhiSb/7znTX/bqHPpQnoYFHP tk0NJ6HpiUqHYYjT9ogUBH07CfXgUfW1phYyPZICSGjGdK+wzVlsFLWCEXyVNh8E hilzIQj3uz1PzuLty1VeJQpFhp+PDvtgZzh402iR/vn1wAELsFki/a5qGl5RQq5u auNzbT8HGLLlAG8Dfcm9wIdJ64OWnfYKE3WIEptaIYwwDQKBoFyzdr63Au2ShupU m3V+7he7urtUibjWe+ogWmLOVJEbXMOnCBhfsd5Zt/3uu3dqbnRnT5AWynLRuOKd RmLuiDx4Ahfx8VRbJ+TpmPjckoVdX7xKUN/crkRpFPORtKRRXHGfshwQE9t4amY0 4QqAu/z44qHoWQ8BUb1OkZyxKcpdwMfIu5IbsjqszHYLG9zQztVuu9wuXDFwghtL uVU4lQ62CjtzU41BeAKDxmlAZqt+3woZzsZwgXPkZVz5IuAh6st8CGizRno/SA+9 lXX0hZfjldqWMiXuG6grd6O80ZobZHq78CngCDXaBYB4FIHKmhM= =zNjM -----END PGP SIGNATURE----- --lP44t/20Ow0y+TLX-- --===============8060657140789450293== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8060657140789450293==--