From: Sean Young <sean@mess.org>
To: Rob Herring <robh@kernel.org>
Cc: linux-media@vger.kernel.org, Sicelo <absicsz@gmail.com>,
"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
"Pali Rohár" <pali.rohar@gmail.com>,
"Pavel Machek" <pavel@ucw.cz>,
"Timo Kokkonen" <timo.t.kokkonen@iki.fi>,
"Tony Lindgren" <tony@atomide.com>
Subject: Re: [PATCH 1/2] media: dt-bindings: nokia,n900-ir use generic pwm-ir-tx driver
Date: Mon, 21 Aug 2023 21:20:28 +0100 [thread overview]
Message-ID: <ZOPHDCXG02y09QFg@gofer.mess.org> (raw)
In-Reply-To: <CAL_Jsq+BLdhKZnTZwRN5b3XdkgSHDj53Z1YJfcYxWxTDqzkRRQ@mail.gmail.com>
On Mon, Aug 21, 2023 at 01:56:56PM -0500, Rob Herring wrote:
> Please use get_maintainers.pl and send patches to the right place.
> Like the other DT maintainers and DT list...
Noted, my bad.
> On Mon, Aug 21, 2023 at 10:26 AM Sean Young <sean@mess.org> wrote:
> >
> > The generic pwm-ir-tx driver works for the Nokia n900, so nokia,n900-ir
> > can be removed.
>
> How long has this been true? You are breaking users if they are on a
> version of OS where the pwm-ir-tx driver doesn't work (or didn't exist
> or wasn't enabled). I suspect this is a platform that will care about
> the ABI.
>
> What you should do is make the "nokia,n900-ir" compatible work with
> the generic driver. Then old driver works still, the generic driver
> works on new OS versions, and the DTB doesn't change.
That makes a lot of sense. I'll re-roll.
Thanks for the feedback.
Sean
next prev parent reply other threads:[~2023-08-21 20:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 15:26 [PATCH 0/2] Remove ir-rx51 driver Sean Young
2023-08-21 15:26 ` [PATCH 1/2] media: dt-bindings: nokia,n900-ir use generic pwm-ir-tx driver Sean Young
2023-08-21 18:56 ` Rob Herring
2023-08-21 20:20 ` Sean Young [this message]
2023-08-21 15:26 ` [PATCH 2/2] media: rc: remove ir-rx51 in favour of generic pwm-ir-tx Sean Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOPHDCXG02y09QFg@gofer.mess.org \
--to=sean@mess.org \
--cc=absicsz@gmail.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
--cc=timo.t.kokkonen@iki.fi \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.