All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <briannorris@chromium.org>
To: "Víctor Gonzalo" <victor.gonzalo@anddroptable.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wifi: mwifiex: use MODULE_FIRMWARE to add firmware files metadata
Date: Wed, 20 Sep 2023 16:07:49 -0700	[thread overview]
Message-ID: <ZQt7RS+FdOtkH0c6@google.com> (raw)
In-Reply-To: <20230914211938.28395-1-victor.gonzalo@anddroptable.net>

On Fri, Sep 15, 2023 at 12:19:38AM +0300, Víctor Gonzalo wrote:
> The mwifiex_pcie driver is missing the MODULE_FIRMWARE macro to
> add the firmware files needed to the module metadata.
> 
> Signed-off-by: Víctor Gonzalo <victor.gonzalo@anddroptable.net>
> ---
>  drivers/net/wireless/marvell/mwifiex/pcie.c | 6 ++++++
>  1 file changed, 6 insertions(+)

FWIW, when reviewing the other sub-drivers, I noticed sdio.c is missing
an entry for SD8801_DEFAULT_FW_NAME. Mind sending a patch?

For this:

Acked-by: Brian Norris <briannorris@chromium.org>

  reply	other threads:[~2023-09-20 23:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-14 21:19 [PATCH] wifi: mwifiex: use MODULE_FIRMWARE to add firmware files metadata Víctor Gonzalo
2023-09-20 23:07 ` Brian Norris [this message]
2023-09-21  6:29 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZQt7RS+FdOtkH0c6@google.com \
    --to=briannorris@chromium.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=victor.gonzalo@anddroptable.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.