From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C103CE8FDDE for ; Wed, 4 Oct 2023 09:14:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241979AbjJDJOT (ORCPT ); Wed, 4 Oct 2023 05:14:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241997AbjJDJOQ (ORCPT ); Wed, 4 Oct 2023 05:14:16 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A28DDC; Wed, 4 Oct 2023 02:14:10 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A553BC433C8; Wed, 4 Oct 2023 09:14:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696410849; bh=P2JFyIm0Ru5QudOr5TqNTdeNy8UEQDyF/LCxvxSZOCk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jN0Qg8i6kmwTvjglbFGkRUz4+gkl/w0GqYoCv/CQYeebzokODLnpHbZBrZY72jEU1 qkMDT88LgiorOOh1SOV/RUWUTtKlxKlSeS9mFTGmmzPfX2FOjnn4CSluJglCTrYm5w YZKTKo0XwBTskdZEIHlaEvb0omHJ3jq5gdurTNT5Q0YwHChiTon6bGQ/TEFCeW+fk7 wlA9TA1tqJ8UX6f6GK1BVeBqh79MVc4V4dDSKr3zVxyL48BkEKn9yHtYXvRg9z3ye1 a46jrp6FQUzm5L5MkVzPxJkg+AxQRHPbqzjIpM413swoEi5+KOIkIuyTgMYRtvHYNG Qfy0XgSVtBodQ== Received: from johan by xi.lan with local (Exim 4.96) (envelope-from ) id 1qnxxV-00025S-2O; Wed, 04 Oct 2023 11:14:21 +0200 Date: Wed, 4 Oct 2023 11:14:21 +0200 From: Johan Hovold To: Tony Lindgren Cc: Maximilian Luz , Greg Kroah-Hartman , Jiri Slaby , Andy Shevchenko , Dhruva Gole , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , John Ogness , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-omap@vger.kernel.org, Andy Shevchenko , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v12 1/1] serial: core: Start managing serial controllers to enable runtime PM Message-ID: References: <20230525113034.46880-1-tony@atomide.com> <62d3678a-a23d-4619-95de-145026629ba8@gmail.com> <20231003121455.GB34982@atomide.com> <20231003122137.GC34982@atomide.com> <20231004061708.GD34982@atomide.com> <20231004090320.GE34982@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231004090320.GE34982@atomide.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 04, 2023 at 12:03:20PM +0300, Tony Lindgren wrote: > * Johan Hovold [231004 07:14]: > > The pm_runtime_get_sync() in serdev_device_open() is supposed to prevent > > that from happening by default and if that now longer works, then that > > needs to be fixed. > > No changes there, that all should work just as before. Well, it clearly does not work as before. > What is broken is that the new serial port device can autosuspend while > the serdev device is active. This prevents serial tx in the suspend > path. > > The serial port device and serdev device are siblings of the physical > serial port controller device as seen in the hierarcy printed out by > Maximilian. Yeah, and that's precisely the broken part. Keeping the serdev controller active is supposed to keep the serial controller active. Your serial core rework appears to have broken just that. The new "devices" that you've added (I have still not tried to understand why that was even needed, it looks overly complicated) must not change that. If the serdev controller is active, tx should just work (as it did before). Johan