From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A171C4167B for ; Thu, 30 Nov 2023 10:18:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235131AbjK3KSm (ORCPT ); Thu, 30 Nov 2023 05:18:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231755AbjK3KSk (ORCPT ); Thu, 30 Nov 2023 05:18:40 -0500 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 709D41A3; Thu, 30 Nov 2023 02:18:46 -0800 (PST) Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-50bba1dd05fso1130794e87.0; Thu, 30 Nov 2023 02:18:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701339524; x=1701944324; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=c5FGYC1au+a2xY09Qm1hrPpvUGudmGYI587sIOf2nQU=; b=i1bt4jRaVzh/qQfiI9kPe/qG2sYVIUEKCrcaqfxSgwtnBDinnCqGPWxuWcvBjr6lo1 /M0YSWEh5c219Zkl0AfAMzOUkfRHQZQx7xOB5qN/B+19dY4XQUTZEzTUyChQTpLUtq8J Mh5shUHV7khkfzW7b2Hbbl7qp/hXhEI3s7VknPG6sbtv+i94e8z/FCBHgRh1hNoCpR8o 5i0jTW/Z9LDtyT5K7N5KRLErUcN68xprmyVXDWhRo82+NzmbgCuIf6fPxqNEHwVSeBnO fkZ6oq+ZC6qPKvaM/+HBybP0Nf5Lc4/x3vcYDXJlJ0eTKikC/lZVTsghp0SsFlfRYh7V wFaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701339524; x=1701944324; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=c5FGYC1au+a2xY09Qm1hrPpvUGudmGYI587sIOf2nQU=; b=cCtZLqMw8vvKfmRnMf9EcAfoCLphlYhF3HlffT6lxN0OG7ht/ZXIBpwzPPKbdsgPQI zvEKfR/iqvXwozRc20S8TCYWnQ2DQTaqSVYnPfJKV1NVbAPI14IYA3KeDjcKdII9G7jV L8I6O7Q0EFBAGJOtsp7/sJeOoiI8/kY46Y6EUGZcjzd4LS26rMQ9SfYoWIKawbyTyALC UekwMBl+QgqoCB7sbE6irEcrQUk9okn5817Q7tJrXFjcg0BekdYCnWpfkJSqEyy0wTip PktLbCun0t9y4JzBNlf+4E/ogUuC+X1jDb3S3J9jAhb33Ba5SsmKfuV/hm4C1v4Ds4JO qocA== X-Gm-Message-State: AOJu0YzsyOS3vX6YsEukBnIXhPIdGgfoxsq1gldUuz9JwVtt10CtSmK5 /6OJJRod9Ul4+aoKYK1W2Sw= X-Google-Smtp-Source: AGHT+IEZ+H12n904PcCJ7l4olz+SFWc7iywSBqp3Ai7Zj9ZXEYMer4AAaHhzG9aSVrfDt+Sq3y9b3Q== X-Received: by 2002:ac2:504f:0:b0:50b:bf06:ea0b with SMTP id a15-20020ac2504f000000b0050bbf06ea0bmr4812487lfm.53.1701339524296; Thu, 30 Nov 2023 02:18:44 -0800 (PST) Received: from tom-HP-ZBook-Fury-15-G7-Mobile-Workstation (net-2-39-143-167.cust.vodafonedsl.it. [2.39.143.167]) by smtp.gmail.com with ESMTPSA id hg10-20020a05600c538a00b0040b398f0585sm1566915wmb.9.2023.11.30.02.18.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 02:18:43 -0800 (PST) Date: Thu, 30 Nov 2023 11:18:41 +0100 From: Tommaso Merciai To: Alexander Stein Cc: Kieran Bingham , Paul Elder , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, Dafna Hirschfeld , Laurent Pinchart , Mauro Carvalho Chehab , Heiko Stuebner , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] media: rkisp1: debug: Add register dump for IS Message-ID: References: <20231129092956.250129-1-paul.elder@ideasonboard.com> <170128834260.3048548.11979514587961676400@ping.linuxembedded.co.uk> <4881112.31r3eYUQgx@steina-w> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4881112.31r3eYUQgx@steina-w> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alexander, On Thu, Nov 30, 2023 at 10:54:46AM +0100, Alexander Stein wrote: > Hi Paul, > > Am Donnerstag, 30. November 2023, 10:47:00 CET schrieb Paul Elder: > > On Wed, Nov 29, 2023 at 08:05:42PM +0000, Kieran Bingham wrote: > > > Quoting Paul Elder (2023-11-29 09:29:55) > > > > > > > Add register dump for the image stabilizer module to debugfs. > > > > > > Is the Image Stabilizer on all variants of the ISP? > > > > > > I.e. is it valid register space on the RK3399 implementation? > > > > Yes, it is. > > Is there some public documentation available how this ISP works? For RK3399 or > i.MX8MP. For the ISP there is some public docs into imx8mp reference manual at page 5895 chapter: 13.14 Image Signal Processor (ISP) https://www.nxp.com/webapp/Download?colCode=IMX8MPRM https://www.nxp.com/design/development-boards/i-mx-evaluation-and-development-boards/evaluation-kit-for-the-i-mx-8m-plus-applications-processor:8MPLUSLPD4-EVK This is not the full docs I think but cover some part of the ISP functionality. Hope this help. Regards, Tommaso > > Best regards, > Alexander > > > > > > If so then: > > > Reviewed-by: Kieran Bingham > > > > > > > Signed-off-by: Paul Elder > > > > --- > > > > > > > > .../platform/rockchip/rkisp1/rkisp1-debug.c | 18 ++++++++++++++++++ > > > > 1 file changed, 18 insertions(+) > > > > > > > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c > > > > b/drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c index > > > > 71df3dc95e6f..f66b9754472e 100644 > > > > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c > > > > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c > > > > @@ -139,6 +139,21 @@ static int rkisp1_debug_dump_mi_mp_show(struct > > > > seq_file *m, void *p)> > > > > > } > > > > DEFINE_SHOW_ATTRIBUTE(rkisp1_debug_dump_mi_mp); > > > > > > > > +static int rkisp1_debug_dump_is_show(struct seq_file *m, void *p) > > > > +{ > > > > + static const struct rkisp1_debug_register registers[] = { > > > > + RKISP1_DEBUG_SHD_REG(ISP_IS_H_OFFS), > > > > + RKISP1_DEBUG_SHD_REG(ISP_IS_V_OFFS), > > > > + RKISP1_DEBUG_SHD_REG(ISP_IS_H_SIZE), > > > > + RKISP1_DEBUG_SHD_REG(ISP_IS_V_SIZE), > > > > > > I expect so as you haven't added the register macros in this series so > > > they must already be there ... > > > > Yep :) > > > > > > Paul > > > > > > + { /* Sentinel */ }, > > > > + }; > > > > + struct rkisp1_device *rkisp1 = m->private; > > > > + > > > > + return rkisp1_debug_dump_regs(rkisp1, m, 0, registers); > > > > +} > > > > +DEFINE_SHOW_ATTRIBUTE(rkisp1_debug_dump_is); > > > > + > > > > > > > > #define RKISP1_DEBUG_DATA_COUNT_BINS 32 > > > > #define RKISP1_DEBUG_DATA_COUNT_STEP (4096 / > > > > RKISP1_DEBUG_DATA_COUNT_BINS)> > > > > > @@ -235,6 +250,9 @@ void rkisp1_debug_init(struct rkisp1_device *rkisp1) > > > > > > > > debugfs_create_file("mi_mp", 0444, regs_dir, rkisp1, > > > > > > > > &rkisp1_debug_dump_mi_mp_fops); > > > > > > > > + > > > > + debugfs_create_file("is", 0444, regs_dir, rkisp1, > > > > + &rkisp1_debug_dump_is_fops); > > > > > > > > } > > > > > > > > void rkisp1_debug_cleanup(struct rkisp1_device *rkisp1) > > > -- > TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany > Amtsgericht München, HRB 105018 > Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider > http://www.tq-group.com/ > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F22B8C4167B for ; Thu, 30 Nov 2023 10:19:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=T0qz/dRFqijGz/7gh+25/0OuWk0whgglmcA0to8Yy6Q=; b=cxPkcYAdq8YjaD rfqsziWuIPKT7PjFGTgUmlY5q8M5Hwq7x3T5Brhc4zePfsHBqcCKc4y2SHJCh76FgsWxDuSFFjZJV j0Q/8p2HCwghkhoDBiSIv1Suh8xU16CNhwF+I8kNQJpObZvhXX6o5eWYoxzJxUnnCZnieOyIIiroB 5ClT2w2yz3yWiVivitbHpOVksJRc35jUPbdw4Pisno1joI+ILasG0p19nkWikGYc6ulmoPfs7uXbE nxGp8XSmf+jpquI3XNOhQnOJAVA6EUS67FmK8t2i1ew3O3Qz7e7VogPcbNxl6MpWXQCBiy7Ozurb+ E6UI3gvi8xcsRYTjfuGA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8e8A-00AQLr-1O; Thu, 30 Nov 2023 10:18:50 +0000 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8e86-00AQKl-30; Thu, 30 Nov 2023 10:18:48 +0000 Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2c9afe6e21fso10395101fa.0; Thu, 30 Nov 2023 02:18:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701339524; x=1701944324; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=c5FGYC1au+a2xY09Qm1hrPpvUGudmGYI587sIOf2nQU=; b=JPgT/S/ENTi/dPrHFwY5hbMRXfZbkXFGlZuEDNAzCk6uTw+rj45wYByf19OdM7eUh+ Qv08qe0rAQ08OhtDbk+NRT1rrz4156ZG4l5sIt4yDHDs56hDvgLzianztqQDJeAnnk4z lWUXJj3ULsSJ1b/FJQzUDjZbXn+DlQVihkIalQPqgwoEXo8oWJ/RwmAt/dU3l+Xs7Exb F2cLmceBoPr22P9h/J7mHxUrK/KiNd9k2No+MN3SSjQ0MZS6NQ42uIy0AfNfNEQ16h6v 9lgx7ovhxJ+/+I6dl7ZBjQvVRkzdbiQCd74iqc9WGlRTKkWWUngff/BQEhy0WvG2iSED KbZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701339524; x=1701944324; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=c5FGYC1au+a2xY09Qm1hrPpvUGudmGYI587sIOf2nQU=; b=ZvlzeDYqDV4dR53G/RldtuVlnqH/TeqkYjqG4HQIQz8jHKTsA8C5ToukSRKHPqXO1W BYdyJI37c/yd46hvjoDzd4duTiYd9uxG+KmNtKUCI4qvEiTiBllnlNsGKs8jAe277glA z628P0DLmhAC+B/RHzq6xs6pRDtu1k+VYDnpr4J/0qRxRhg5nsOfzZ0lne/W/J2/Bdo3 dn295Vd4PiRPY1pe3xQrx2qKrybt5zbE1k1gMRHtwhH+3llfjZBSacvII2OrmQDyW/oU zgVB8xpi0CddfCp5k+JGwy1wxKxPyv4O95hxNnph+owD35xMFmDsHBsqJwJSVA4b9HYe hkPA== X-Gm-Message-State: AOJu0Yymtv6qR4vwsfUL7GFo9pQtce8+oXWw7J33SEvtS06yx7cETbxb 2NM8RX/GmquyGY/bwVN2LMD1vxBxH6Q= X-Google-Smtp-Source: AGHT+IEZ+H12n904PcCJ7l4olz+SFWc7iywSBqp3Ai7Zj9ZXEYMer4AAaHhzG9aSVrfDt+Sq3y9b3Q== X-Received: by 2002:ac2:504f:0:b0:50b:bf06:ea0b with SMTP id a15-20020ac2504f000000b0050bbf06ea0bmr4812487lfm.53.1701339524296; Thu, 30 Nov 2023 02:18:44 -0800 (PST) Received: from tom-HP-ZBook-Fury-15-G7-Mobile-Workstation (net-2-39-143-167.cust.vodafonedsl.it. [2.39.143.167]) by smtp.gmail.com with ESMTPSA id hg10-20020a05600c538a00b0040b398f0585sm1566915wmb.9.2023.11.30.02.18.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 02:18:43 -0800 (PST) Date: Thu, 30 Nov 2023 11:18:41 +0100 From: Tommaso Merciai To: Alexander Stein Cc: Kieran Bingham , Paul Elder , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, Dafna Hirschfeld , Laurent Pinchart , Mauro Carvalho Chehab , Heiko Stuebner , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] media: rkisp1: debug: Add register dump for IS Message-ID: References: <20231129092956.250129-1-paul.elder@ideasonboard.com> <170128834260.3048548.11979514587961676400@ping.linuxembedded.co.uk> <4881112.31r3eYUQgx@steina-w> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4881112.31r3eYUQgx@steina-w> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231130_021846_970944_40E61E2C X-CRM114-Status: GOOD ( 30.13 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi Alexander, On Thu, Nov 30, 2023 at 10:54:46AM +0100, Alexander Stein wrote: > Hi Paul, > = > Am Donnerstag, 30. November 2023, 10:47:00 CET schrieb Paul Elder: > > On Wed, Nov 29, 2023 at 08:05:42PM +0000, Kieran Bingham wrote: > > > Quoting Paul Elder (2023-11-29 09:29:55) > > > = > > > > Add register dump for the image stabilizer module to debugfs. > > > = > > > Is the Image Stabilizer on all variants of the ISP? > > > = > > > I.e. is it valid register space on the RK3399 implementation? > > = > > Yes, it is. > = > Is there some public documentation available how this ISP works? For RK33= 99 or = > i.MX8MP. For the ISP there is some public docs into imx8mp reference manual at page = 5895 chapter: 13.14 Image Signal Processor (ISP) https://www.nxp.com/webapp/Download?colCode=3DIMX8MPRM https://www.nxp.com/design/development-boards/i-mx-evaluation-and-developme= nt-boards/evaluation-kit-for-the-i-mx-8m-plus-applications-processor:8MPLUS= LPD4-EVK This is not the full docs I think but cover some part of the ISP functionality. Hope this help. Regards, Tommaso > = > Best regards, > Alexander > = > > = > > > If so then: > > > Reviewed-by: Kieran Bingham > > > = > > > > Signed-off-by: Paul Elder > > > > --- > > > > = > > > > .../platform/rockchip/rkisp1/rkisp1-debug.c | 18 ++++++++++++++= ++++ > > > > 1 file changed, 18 insertions(+) > > > > = > > > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c > > > > b/drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c index > > > > 71df3dc95e6f..f66b9754472e 100644 > > > > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c > > > > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c > > > > @@ -139,6 +139,21 @@ static int rkisp1_debug_dump_mi_mp_show(struct > > > > seq_file *m, void *p)> > = > > > > } > > > > DEFINE_SHOW_ATTRIBUTE(rkisp1_debug_dump_mi_mp); > > > > = > > > > +static int rkisp1_debug_dump_is_show(struct seq_file *m, void *p) > > > > +{ > > > > + static const struct rkisp1_debug_register registers[] =3D { > > > > + RKISP1_DEBUG_SHD_REG(ISP_IS_H_OFFS), > > > > + RKISP1_DEBUG_SHD_REG(ISP_IS_V_OFFS), > > > > + RKISP1_DEBUG_SHD_REG(ISP_IS_H_SIZE), > > > > + RKISP1_DEBUG_SHD_REG(ISP_IS_V_SIZE), > > > = > > > I expect so as you haven't added the register macros in this series so > > > they must already be there ... > > = > > Yep :) > > = > > = > > Paul > > = > > > > + { /* Sentinel */ }, > > > > + }; > > > > + struct rkisp1_device *rkisp1 =3D m->private; > > > > + > > > > + return rkisp1_debug_dump_regs(rkisp1, m, 0, registers); > > > > +} > > > > +DEFINE_SHOW_ATTRIBUTE(rkisp1_debug_dump_is); > > > > + > > > > = > > > > #define RKISP1_DEBUG_DATA_COUNT_BINS 32 > > > > #define RKISP1_DEBUG_DATA_COUNT_STEP (4096 / > > > > RKISP1_DEBUG_DATA_COUNT_BINS)> > = > > > > @@ -235,6 +250,9 @@ void rkisp1_debug_init(struct rkisp1_device *rk= isp1) > > > > = > > > > debugfs_create_file("mi_mp", 0444, regs_dir, rkisp1, > > > > = > > > > &rkisp1_debug_dump_mi_mp_fops); > > > > = > > > > + > > > > + debugfs_create_file("is", 0444, regs_dir, rkisp1, > > > > + &rkisp1_debug_dump_is_fops); > > > > = > > > > } > > > > = > > > > void rkisp1_debug_cleanup(struct rkisp1_device *rkisp1) > = > = > -- = > TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany > Amtsgericht M=FCnchen, HRB 105018 > Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider > http://www.tq-group.com/ > = > = > = _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4553AC4167B for ; Thu, 30 Nov 2023 10:19:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JjWHLc57Cpw34R2GQaZOFkuvS51rN6dfc7g38w711Fs=; b=hfapNyfqVyYfjH MvO6QtGTM6RMuXIa3K7thljXiMCyAvsCtqPeDE++OreWV4ojlQoDtS+vMS/NueexaxcJQY/9g+Y4s 2w30+Xl0iNvCvUilIUrTzhlWbh9TSTJS+NXmNXzKxjQYNpwn59z/cptI3us1vQwdNPCxSOOu9+Xmo mnZjQs58/k0TLD1F3kF8sTd1NVbUQbbGWSrJ0FCS0bc4f07BYXFZyHbI+tLagJmTxmI1x7Y9bwJAd /tHqhQq2eiaksFspzVhak83QPSgogclzqpr2YRLJrIrdIQn/5SL3ghzbGWznv0f21+rss6IRNBX6M oNkn0qphyDaHY4gaHuHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8e8A-00AQM0-2e; Thu, 30 Nov 2023 10:18:50 +0000 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8e86-00AQKl-30; Thu, 30 Nov 2023 10:18:48 +0000 Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2c9afe6e21fso10395101fa.0; Thu, 30 Nov 2023 02:18:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701339524; x=1701944324; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=c5FGYC1au+a2xY09Qm1hrPpvUGudmGYI587sIOf2nQU=; b=JPgT/S/ENTi/dPrHFwY5hbMRXfZbkXFGlZuEDNAzCk6uTw+rj45wYByf19OdM7eUh+ Qv08qe0rAQ08OhtDbk+NRT1rrz4156ZG4l5sIt4yDHDs56hDvgLzianztqQDJeAnnk4z lWUXJj3ULsSJ1b/FJQzUDjZbXn+DlQVihkIalQPqgwoEXo8oWJ/RwmAt/dU3l+Xs7Exb F2cLmceBoPr22P9h/J7mHxUrK/KiNd9k2No+MN3SSjQ0MZS6NQ42uIy0AfNfNEQ16h6v 9lgx7ovhxJ+/+I6dl7ZBjQvVRkzdbiQCd74iqc9WGlRTKkWWUngff/BQEhy0WvG2iSED KbZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701339524; x=1701944324; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=c5FGYC1au+a2xY09Qm1hrPpvUGudmGYI587sIOf2nQU=; b=ZvlzeDYqDV4dR53G/RldtuVlnqH/TeqkYjqG4HQIQz8jHKTsA8C5ToukSRKHPqXO1W BYdyJI37c/yd46hvjoDzd4duTiYd9uxG+KmNtKUCI4qvEiTiBllnlNsGKs8jAe277glA z628P0DLmhAC+B/RHzq6xs6pRDtu1k+VYDnpr4J/0qRxRhg5nsOfzZ0lne/W/J2/Bdo3 dn295Vd4PiRPY1pe3xQrx2qKrybt5zbE1k1gMRHtwhH+3llfjZBSacvII2OrmQDyW/oU zgVB8xpi0CddfCp5k+JGwy1wxKxPyv4O95hxNnph+owD35xMFmDsHBsqJwJSVA4b9HYe hkPA== X-Gm-Message-State: AOJu0Yymtv6qR4vwsfUL7GFo9pQtce8+oXWw7J33SEvtS06yx7cETbxb 2NM8RX/GmquyGY/bwVN2LMD1vxBxH6Q= X-Google-Smtp-Source: AGHT+IEZ+H12n904PcCJ7l4olz+SFWc7iywSBqp3Ai7Zj9ZXEYMer4AAaHhzG9aSVrfDt+Sq3y9b3Q== X-Received: by 2002:ac2:504f:0:b0:50b:bf06:ea0b with SMTP id a15-20020ac2504f000000b0050bbf06ea0bmr4812487lfm.53.1701339524296; Thu, 30 Nov 2023 02:18:44 -0800 (PST) Received: from tom-HP-ZBook-Fury-15-G7-Mobile-Workstation (net-2-39-143-167.cust.vodafonedsl.it. [2.39.143.167]) by smtp.gmail.com with ESMTPSA id hg10-20020a05600c538a00b0040b398f0585sm1566915wmb.9.2023.11.30.02.18.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 02:18:43 -0800 (PST) Date: Thu, 30 Nov 2023 11:18:41 +0100 From: Tommaso Merciai To: Alexander Stein Cc: Kieran Bingham , Paul Elder , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, Dafna Hirschfeld , Laurent Pinchart , Mauro Carvalho Chehab , Heiko Stuebner , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] media: rkisp1: debug: Add register dump for IS Message-ID: References: <20231129092956.250129-1-paul.elder@ideasonboard.com> <170128834260.3048548.11979514587961676400@ping.linuxembedded.co.uk> <4881112.31r3eYUQgx@steina-w> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4881112.31r3eYUQgx@steina-w> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231130_021846_970944_40E61E2C X-CRM114-Status: GOOD ( 30.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Alexander, On Thu, Nov 30, 2023 at 10:54:46AM +0100, Alexander Stein wrote: > Hi Paul, > = > Am Donnerstag, 30. November 2023, 10:47:00 CET schrieb Paul Elder: > > On Wed, Nov 29, 2023 at 08:05:42PM +0000, Kieran Bingham wrote: > > > Quoting Paul Elder (2023-11-29 09:29:55) > > > = > > > > Add register dump for the image stabilizer module to debugfs. > > > = > > > Is the Image Stabilizer on all variants of the ISP? > > > = > > > I.e. is it valid register space on the RK3399 implementation? > > = > > Yes, it is. > = > Is there some public documentation available how this ISP works? For RK33= 99 or = > i.MX8MP. For the ISP there is some public docs into imx8mp reference manual at page = 5895 chapter: 13.14 Image Signal Processor (ISP) https://www.nxp.com/webapp/Download?colCode=3DIMX8MPRM https://www.nxp.com/design/development-boards/i-mx-evaluation-and-developme= nt-boards/evaluation-kit-for-the-i-mx-8m-plus-applications-processor:8MPLUS= LPD4-EVK This is not the full docs I think but cover some part of the ISP functionality. Hope this help. Regards, Tommaso > = > Best regards, > Alexander > = > > = > > > If so then: > > > Reviewed-by: Kieran Bingham > > > = > > > > Signed-off-by: Paul Elder > > > > --- > > > > = > > > > .../platform/rockchip/rkisp1/rkisp1-debug.c | 18 ++++++++++++++= ++++ > > > > 1 file changed, 18 insertions(+) > > > > = > > > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c > > > > b/drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c index > > > > 71df3dc95e6f..f66b9754472e 100644 > > > > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c > > > > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c > > > > @@ -139,6 +139,21 @@ static int rkisp1_debug_dump_mi_mp_show(struct > > > > seq_file *m, void *p)> > = > > > > } > > > > DEFINE_SHOW_ATTRIBUTE(rkisp1_debug_dump_mi_mp); > > > > = > > > > +static int rkisp1_debug_dump_is_show(struct seq_file *m, void *p) > > > > +{ > > > > + static const struct rkisp1_debug_register registers[] =3D { > > > > + RKISP1_DEBUG_SHD_REG(ISP_IS_H_OFFS), > > > > + RKISP1_DEBUG_SHD_REG(ISP_IS_V_OFFS), > > > > + RKISP1_DEBUG_SHD_REG(ISP_IS_H_SIZE), > > > > + RKISP1_DEBUG_SHD_REG(ISP_IS_V_SIZE), > > > = > > > I expect so as you haven't added the register macros in this series so > > > they must already be there ... > > = > > Yep :) > > = > > = > > Paul > > = > > > > + { /* Sentinel */ }, > > > > + }; > > > > + struct rkisp1_device *rkisp1 =3D m->private; > > > > + > > > > + return rkisp1_debug_dump_regs(rkisp1, m, 0, registers); > > > > +} > > > > +DEFINE_SHOW_ATTRIBUTE(rkisp1_debug_dump_is); > > > > + > > > > = > > > > #define RKISP1_DEBUG_DATA_COUNT_BINS 32 > > > > #define RKISP1_DEBUG_DATA_COUNT_STEP (4096 / > > > > RKISP1_DEBUG_DATA_COUNT_BINS)> > = > > > > @@ -235,6 +250,9 @@ void rkisp1_debug_init(struct rkisp1_device *rk= isp1) > > > > = > > > > debugfs_create_file("mi_mp", 0444, regs_dir, rkisp1, > > > > = > > > > &rkisp1_debug_dump_mi_mp_fops); > > > > = > > > > + > > > > + debugfs_create_file("is", 0444, regs_dir, rkisp1, > > > > + &rkisp1_debug_dump_is_fops); > > > > = > > > > } > > > > = > > > > void rkisp1_debug_cleanup(struct rkisp1_device *rkisp1) > = > = > -- = > TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany > Amtsgericht M=FCnchen, HRB 105018 > Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider > http://www.tq-group.com/ > = > = > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel